May 2019 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-10171) Spring Cache sync locking does not work

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10171?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10171. --------------------------------- Fix Version/s: 10.0.0.Beta4 9.4.14.Final Resolution: Done > Spring Cache sync locking does not work > --------------------------------------- > > Key: ISPN-10171 > URL: https://issues.jboss.org/browse/ISPN-10171 > Project: Infinispan > Issue Type: Bug > Components: Spring Integration > Affects Versions: 9.4.11.Final, 10.0.0.Beta4 > Environment: > mvn -version > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00) > Maven home: /usr/local/Cellar/maven/3.6.0/libexec > Java version: 11.0.1, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/openjdk-11.0.1.jdk/Contents/Home > Default locale: en_NL, platform encoding: UTF-8 > OS name: "mac os x", version: "10.14.4", arch: "x86_64", family: "mac" > Reporter: Rens van Leeuwen > Assignee: Katia Aresti > Priority: Major > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > With ISPN-7224/https://github.com/infinispan/infinispan/pull/5262, an implementation was written to support a synchronous get that implements Spring Cache's {{@Cacheable(sync = true)}}. > That seems to work well in isolation, but not in an integrated way. By that I mean, that the implementation of {{SpringCache}} maintains its own {{ReentrantLock}}s in each instance. > Zooming out a bit, this is part of the call stack when the {{SpringCache}} instance is looked up during handling the {{@Cacheable(sync = true)}} annotation: > {noformat} > CacheInterceptor.invoke(MethodInvocation) (org.springframework.cache.interceptor) > CacheAspectSupport.execute(CacheOperationInvoker, Object, Method, Object[]) (org.springframework.cache.interceptor) > CacheOperationContexts in CacheAspectSupport.CacheOperationContexts(Collection<? extends CacheOperation>, Method, Object[], Object, Class<?>) (org.springframework.cache.interceptor) > CacheAspectSupport.getOperationContext(CacheOperation, Method, Object[], Object, Class<?>) (org.springframework.cache.interceptor) > CacheOperationContext in CacheAspectSupport.CacheOperationContext(CacheOperationMetadata, Object[], Object) (org.springframework.cache.interceptor) > CacheAspectSupport.getCaches(CacheOperationInvocationContext<CacheOperation>, CacheResolver) (org.springframework.cache.interceptor) > AbstractCacheResolver.resolveCaches(CacheOperationInvocationContext<?>) (org.springframework.cache.interceptor) > ----->> SpringEmbeddedCacheManager.getCache(String) (org.infinispan.spring.embedded.provider) > SpringCache.SpringCache(BasicCache) (org.infinispan.spring.common.provider) > SpringCache.SpringCache(BasicCache, long, long) (org.infinispan.spring.common.provider) > {noformat} > The problem with this is, that for each turn the interceptor handles the request a *new instance* of the {{SpringCache}} is made in the {{SpringEmbeddedCacheManager}}, rendering the use of the {{ReentrantLock}} mechanism useless to a certain extent, because multiple threads accessing the {{@Cacheable(sync = true)}} method will each have their own {{SpringCache}} and corresponding {{ReentrantLock}}. > In turn, there is no locking at all, and each thread will be executing the (assumed to be) expensive code that is intended to be cached. > -- > I'm intending to write a patch for this, but this would be the first time I commit to an open source project (bear with me ;)). I'll try to provide a pull request for this. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10194) Store Migrator tests should pass when segmentation is disabled

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10194?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10194. --------------------------------- Resolution: Done > Store Migrator tests should pass when segmentation is disabled > -------------------------------------------------------------- > > Key: ISPN-10194 > URL: https://issues.jboss.org/browse/ISPN-10194 > Project: Infinispan > Issue Type: Bug > Components: Loaders and Stores > Reporter: Will Burns > Assignee: Will Burns > Priority: Major > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > The store migrator tests fail when segmentation is disabled when running tests as some set segments for the stores. We need to skip these tests when applicable. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9195) Iterator leak when Hot Rod client crashes

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-9195?page=com.atlassian.jira.plugin.... ] Ryan Emerson resolved ISPN-9195. -------------------------------- Resolution: Done > Iterator leak when Hot Rod client crashes > ----------------------------------------- > > Key: ISPN-9195 > URL: https://issues.jboss.org/browse/ISPN-9195 > Project: Infinispan > Issue Type: Bug > Components: Server > Affects Versions: 9.3.0.Beta1 > Reporter: Radim Vansa > Assignee: Tristan Tarrant > Priority: Major > Labels: memory_leak > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > When the client abruptly terminates, or simply does not close the iterator, iterator resources on server are not released. > Any such resources should be handles with lease-based expiration. Additionally we could remove the resources when the connection that established them is closed. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10029) Transactional invalidation cache with shared store prone to stale reads, even with FORCE_WRITE_LOCK

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10029?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10029. --------------------------------- Resolution: Done > Transactional invalidation cache with shared store prone to stale reads, even with FORCE_WRITE_LOCK > --------------------------------------------------------------------------------------------------- > > Key: ISPN-10029 > URL: https://issues.jboss.org/browse/ISPN-10029 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 9.3.6.Final, 9.4.11.Final, 10.0.0.Beta3 > Reporter: Paul Ferraro > Assignee: Dan Berindei > Priority: Critical > Fix For: 10.0.0.Beta4, 9.3.7.Final, 9.4.14.Final > > Attachments: InvalidationLockingTest.java > > -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10074) DefaultSegmentedDataContainer executeTask() and iterator() include expired entries

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10074?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10074. --------------------------------- Resolution: Done > DefaultSegmentedDataContainer executeTask() and iterator() include expired entries > ---------------------------------------------------------------------------------- > > Key: ISPN-10074 > URL: https://issues.jboss.org/browse/ISPN-10074 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 9.4.10.Final, 10.0.0.Beta2 > Reporter: Dan Berindei > Assignee: Dan Berindei > Priority: Major > Labels: testsuite_stability > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > The {{executeTask()}} javadoc doesn't mention expired entries, but {{iterator()}}'s says they shouldn't be included, and non-segmented containers do not include them. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10157) Counter client does not use CH to locate a counter

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10157?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10157. --------------------------------- Fix Version/s: 10.0.0.Beta4 9.4.14.Final Resolution: Done > Counter client does not use CH to locate a counter > -------------------------------------------------- > > Key: ISPN-10157 > URL: https://issues.jboss.org/browse/ISPN-10157 > Project: Infinispan > Issue Type: Bug > Reporter: Galder Zamarreño > Assignee: Pedro Ruivo > Priority: Major > Labels: rhdemo-2019 > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > So when accessing a counter, a penalty network hop can happen as a result of not using CH data to locate the key. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10155) Counter manager configs not applied on server

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10155?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10155. --------------------------------- Resolution: Done > Counter manager configs not applied on server > --------------------------------------------- > > Key: ISPN-10155 > URL: https://issues.jboss.org/browse/ISPN-10155 > Project: Infinispan > Issue Type: Bug > Components: Clustered Counter, Server > Affects Versions: 9.4.12.Final, 10.0.0.Beta3 > Reporter: Tristan Tarrant > Assignee: Tristan Tarrant > Priority: Major > Labels: rhdemo-2019 > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > The server model for the counter manager is not correctly set up: > * attributes are registered as metrics > * the add handler ignores attributes > * the configurationmanager is not actually configured > * the xml writer attempts to serialize attributes from the wrong model nodes -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10108) Query Project - Store the test results using TestNG

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10108?page=com.atlassian.jira.plugin... ] Ryan Emerson updated ISPN-10108: -------------------------------- Fix Version/s: 9.4.14.Final > Query Project - Store the test results using TestNG > --------------------------------------------------- > > Key: ISPN-10108 > URL: https://issues.jboss.org/browse/ISPN-10108 > Project: Infinispan > Issue Type: Bug > Affects Versions: 9.4.11.Final, 10.0.0.Final > Reporter: Diego Lovison > Assignee: Diego Lovison > Priority: Major > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > Running the command {{mvn verify -pl 'query' -Dtest=MassIndexerAsyncBackendTest}} from the root folder will produce two XMLs > TEST-infinispan-query.xml > TEST-org.infinispan.query.distributed.MassIndexerAsyncBackendTest.xml > One will be the Junit report and the other one will be the Polarion Report. > The query project uses TestNG instead of JUNIT > I would like to fix the following > {code:xml} > <testcase name="query.distributed.MassIndexerAsyncBackendTest" classname="org.infinispan.query.distributed.MassIndexerAsyncBackendTest" time="3.469"/> > {code} -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-10143) Stackoverflow error with computeIfAbsent

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-10143?page=com.atlassian.jira.plugin... ] Ryan Emerson resolved ISPN-10143. --------------------------------- Fix Version/s: 10.0.0.Beta4 9.4.14.Final Resolution: Done > Stackoverflow error with computeIfAbsent > ---------------------------------------- > > Key: ISPN-10143 > URL: https://issues.jboss.org/browse/ISPN-10143 > Project: Infinispan > Issue Type: Bug > Components: Core > Reporter: Katia Aresti > Assignee: Katia Aresti > Priority: Major > Fix For: 10.0.0.Beta4, 9.4.14.Final > > > Some compute if absent method in the AbstractDelegatingCache.java does not delegate to the underlying cache object, so the stackoverflow error happens -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9621) Split global marshaller into Persistence and Internal marshaller

by Ryan Emerson (Jira)

[ https://issues.jboss.org/browse/ISPN-9621?page=com.atlassian.jira.plugin.... ] Ryan Emerson updated ISPN-9621: ------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/6240, https://github.com/infinispan/infinispan/pull/6906 (was: https://github.com/infinispan/infinispan/pull/6240) > Split global marshaller into Persistence and Internal marshaller > ---------------------------------------------------------------- > > Key: ISPN-9621 > URL: https://issues.jboss.org/browse/ISPN-9621 > Project: Infinispan > Issue Type: Sub-task > Components: Core, Loaders and Stores > Affects Versions: 9.4.0.Final > Reporter: Ryan Emerson > Assignee: Ryan Emerson > Priority: Major > Fix For: 10.0.0.Beta4 > > > Currently the internal marshaller is used for marshalling key/value/metadata in store implementations. This means that it is possible for internal classes to be marshalled to a user store, which can cause compatibility issues if an internal classes serialization format changes (due to marshaller changes or addition/removal of fields). > We should separate the internal and persistence marshaller, only exposing the latter to stores via the InitializationContext. The persistence marshaller should only be able to serialize user key/values and the metadata/version data. -- This message was sent by Atlassian Jira (v7.12.1#712002)

6 years, 10 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues May 2019