[JBoss JIRA] (ISPN-9027) Distinguishing different Cache Store configurations is impossible
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-9027?page=com.atlassian.jira.plugin.... ]
Ryan Emerson updated ISPN-9027:
-------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/6905
> Distinguishing different Cache Store configurations is impossible
> -----------------------------------------------------------------
>
> Key: ISPN-9027
> URL: https://issues.jboss.org/browse/ISPN-9027
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 9.2.1.Final
> Reporter: Sebastian Laskawiec
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta4, 9.4.14.Final
>
> Attachments: clustered.xml
>
>
> h3. Problem description
> One of our users reported that when using two Deployed Cache Stores, their configuration gets overridden and both behaves as if they had the same configuration. Here's an example:
> {code}
> <distributed-cache name="cassandracache1" owners="2" segments="256" mode="SYNC">
> <store name="store1" class="org.infinispan.persistence.cassandra.CassandraStore" preload="true">
> <property name="autoCreateKeyspace">
> true
> </property>
> <property name="keyspace">
> Infinispan
> </property>
> <property name="entryTable">
> InfinispanEntries
> </property>
> <property name="servers">
> 172.17.0.2[9042]
> </property>
> </store>
> </distributed-cache>
> <distributed-cache name="cassandracache2" owners="2" segments="256" mode="SYNC">
> <store name="store2" class="org.infinispan.persistence.cassandra.CassandraStore" preload="true">
> <property name="autoCreateKeyspace">
> true
> </property>
> <property name="keyspace">
> Infinispan
> </property>
> <property name="entryTable">
> InfinispanEntries1
> </property>
> <property name="servers">
> 172.17.0.2[9042]
> </property>
> </store>
> </distributed-cache>
> {code}
> Both caches ({{cassandracache1}} and {{cassandracache2}}) use the same {{entryTable}} which is set to {{InfinispanEntries1}}.
> h3. Investigation
> {{CacheStoreFactory}} implementation were created to fabricate Loader/Writer instance based on parsed configuration (via {{createInstance}} method). This method receives from {{PersistenceManagerImpl}} an instance of an {{AbstractStoreConfiguration}} (here's an example (1)) two times - once per each parsed configuration. The parsing part seems OK but we do not parse Cache Store Name, which makes differentiating both configuration impossible.
> h3. Proposed fix
> * Add {{name}} attribute to {{StoreConfiguration}}.
> * Either add an explicit parameter to {{CacheStoreFactory#createInstance(StoreConfiguration cfg, String cacheStoreName)}} or scan for Cache Store name in both implementations ({{DeployedCacheStoreFactory}} and {{LocalClassLoaderCacheStoreFactory}}.
> {code}
> (1) AbstractStoreConfiguration [attributes=DeployedStoreConfiguration = [fetchPersistentState=false, purgeOnStartup=false, ignoreModifications=false, preload=true, shared=false, transactional=false, maxBatchSize=100, properties={keyspace=Infinispan, connectionPool.poolTimeoutMillis=5, entryTable=InfinispanEntries, connectionPool.idleTimeoutSeconds=120, connectionPool.heartbeatIntervalSeconds=30, autoCreateKeyspace=true, servers=172.17.0.2[9042]}, customStoreClassName=org.infinispan.persistence.cassandra.CassandraStore], async=AsyncStoreConfiguration [attributes=AsyncStoreConfiguration = [enabled=false, modificationQueueSize=1024, threadPoolSize=1]], singletonStore=SingletonStoreConfiguration [attributes=SingletonStoreConfiguration = [enabled=false, push-state-timeout=10000, push-state-when-coordinator=true]]]
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (IPROTO-51) ProtoSchemaBuilder fails on required property of type bytes
by Nistor Adrian (Jira)
[ https://issues.jboss.org/browse/IPROTO-51?page=com.atlassian.jira.plugin.... ]
Nistor Adrian updated IPROTO-51:
--------------------------------
Fix Version/s: 4.3.0.Alpha3
(was: 4.3.0.Alpha1)
> ProtoSchemaBuilder fails on required property of type bytes
> -----------------------------------------------------------
>
> Key: IPROTO-51
> URL: https://issues.jboss.org/browse/IPROTO-51
> Project: Infinispan ProtoStream
> Issue Type: Bug
> Affects Versions: 3.0.5.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.3.0.Final, 4.1.5.Final, 4.3.0.Alpha3
>
>
> {code}
> @ProtoField(number = 10, required = true)
> public byte[] getName() {
> return name;
> }
> {code}
> reults in
> Failure: org.infinispan.protostream.annotations.ProtoSchemaBuilderException: Repeated field 'name' of class app.model.Train cannot be marked required.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (IPROTO-91) Allow SerializationContextInitializer dependencies
by Nistor Adrian (Jira)
[ https://issues.jboss.org/browse/IPROTO-91?page=com.atlassian.jira.plugin.... ]
Nistor Adrian resolved IPROTO-91.
---------------------------------
Fix Version/s: 4.3.0.Alpha2
Resolution: Done
Resolved by commit https://github.com/infinispan/protostream/commit/2a2c09646ad6a57b4ae51fdd...
> Allow SerializationContextInitializer dependencies
> --------------------------------------------------
>
> Key: IPROTO-91
> URL: https://issues.jboss.org/browse/IPROTO-91
> Project: Infinispan ProtoStream
> Issue Type: Enhancement
> Affects Versions: 4.3.0.Alpha1
> Reporter: Ryan Emerson
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 4.3.0.Alpha2
>
>
> In order to avoid split-packages across multiple maven modules and the resulting jars, it's necessary for Protostream to provide a mechanism for {{SerializationContextInitializer}} implementations in one module to depend on those defined in dependent modules.
> For example, the {{org.infinispan.commons.io.ByteBufferImpl}} class is defined in the Infinispan commons module, but is required by several annotated Pojos in the core module. In order for the core module to compile, it is necessary for {{ByteBufferImpl.class}} to be added to the {{classes}} field in the core modules {{AutoProtoSchemaBuilder}} annotation with {{autoImportClasses == false}} or for {{autoImportClasses == true}}. Either way, this results in {{org.infinispan.commons.io.ByteBufferImp$_Marshaller.class}} being added to the core jar.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months
[JBoss JIRA] (ISPN-10181) Async Cross Site replication statistics
by Pedro Ruivo (Jira)
Pedro Ruivo created ISPN-10181:
----------------------------------
Summary: Async Cross Site replication statistics
Key: ISPN-10181
URL: https://issues.jboss.org/browse/ISPN-10181
Project: Infinispan
Issue Type: Enhancement
Components: Cross-Site Replication, JMX, reporting and management
Affects Versions: 9.4.13.Final, 10.0.0.Beta3
Reporter: Pedro Ruivo
Assignee: Pedro Ruivo
Add average replication time to the cross-site statistics.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 11 months