[JBoss JIRA] (ISPN-10423) RocksDB ReadOptions memory leak
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-10423?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-10423:
--------------------------------
Sprint: DataGrid Sprint #31
> RocksDB ReadOptions memory leak
> -------------------------------
>
> Key: ISPN-10423
> URL: https://issues.jboss.org/browse/ISPN-10423
> Project: Infinispan
> Issue Type: Bug
> Components: Loaders and Stores
> Affects Versions: 10.0.0.Beta4, 9.4.15.Final
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.0.0.Beta5, 9.4.16.Final
>
>
> Currently our rocksdb store impl creates a new ReadOptions instance per iterator created. As per the RocksDB we should be calling {{dispose()}} on this once it goes out of scope, so that the c++ underlying impl can free the memory. Currently we're not doing this, resulting in a memory leak.
> As we only ever use the same ReadOptions for all iterators, we should simply re-use a singleton for all iterators and then dispose of this on shutdown.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (ISPN-10423) RocksDB ReadOptions memory leak
by Ryan Emerson (Jira)
Ryan Emerson created ISPN-10423:
-----------------------------------
Summary: RocksDB ReadOptions memory leak
Key: ISPN-10423
URL: https://issues.jboss.org/browse/ISPN-10423
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 9.4.15.Final, 10.0.0.Beta4
Reporter: Ryan Emerson
Assignee: Ryan Emerson
Fix For: 10.0.0.Beta5, 9.4.16.Final
Currently our rocksdb store impl creates a new ReadOptions instance per iterator created. As per the RocksDB we should be calling {{dispose()}} on this once it goes out of scope, so that the c++ underlying impl can free the memory. Currently we're not doing this, resulting in a memory leak.
As we only ever use the same ReadOptions for all iterators, we should simply re-use a singleton for all iterators and then dispose of this on shutdown.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months
[JBoss JIRA] (ISPN-10352) Externalize all code and config samples in docs
by Tristan Tarrant (Jira)
[ https://issues.jboss.org/browse/ISPN-10352?page=com.atlassian.jira.plugin... ]
Tristan Tarrant updated ISPN-10352:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 10.0.0.Beta5
Resolution: Done
> Externalize all code and config samples in docs
> -----------------------------------------------
>
> Key: ISPN-10352
> URL: https://issues.jboss.org/browse/ISPN-10352
> Project: Infinispan
> Issue Type: Enhancement
> Components: Documentation-Core
> Reporter: Donald Naro
> Assignee: Donald Naro
> Priority: Optional
> Fix For: 10.0.0.Beta5
>
>
> All code samples in docs should be run and tested at build time. Externalize all code samples to a separate directory and include them. Do the same for all config samples in any format, yaml, xml, and so on.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 8 months