[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Gustavo Fernandes (Jira)
[ https://issues.redhat.com/browse/ISPN-8628?page=com.atlassian.jira.plugin... ]
Gustavo Fernandes reopened ISPN-8628:
-------------------------------------
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.redhat.com/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Nistor Adrian
> Priority: Minor
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Gustavo Fernandes (Jira)
[ https://issues.redhat.com/browse/ISPN-8628?page=com.atlassian.jira.plugin... ]
Gustavo Fernandes commented on ISPN-8628:
-----------------------------------------
My mistake, I saw RemoteQueryDefinition is gone and though it was solved
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.redhat.com/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Nistor Adrian
> Priority: Minor
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-11291) MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11291?page=com.atlassian.jira.plugi... ]
Ryan Emerson updated ISPN-11291:
--------------------------------
Status: Pull Request Sent (was: Reopened)
> MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
> -----------------------------------------------------------------------------------
>
> Key: ISPN-11291
> URL: https://issues.redhat.com/browse/ISPN-11291
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1, 10.1.3.Final
>
>
> Actually it fails pretty constantly in CI:
> {noformat}
> 18:59:06,673 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy[DIST_SYNC, DENY_READ_WRITES]
> java.lang.RuntimeException: Cache Test timed out waiting for rebalancing to complete on node Test-NodeA, current topology is CacheTopology{id=8, phase=CONFLICT_RESOLUTION, rebalanceId=4, currentCH=PartitionerConsistentHash:DefaultConsistentHash{ns=256, owners = (2)[Test-NodeB: 256+0, Test-NodeA: 0+256]}, pendingCH=null, unionCH=null, actualMembers=[Test-NodeB, Test-NodeA], persistentUUIDs=[95c5afaf-de70-49f5-a494-4ae634425e9b, 73824c63-18cb-4de3-a714-b1b1b3fe5713]}. rebalanceInProgress=true, currentChIsBalanced=true
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:435) ~[test-classes/:?]
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:502) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.waitForPartitionToForm(BasePartitionHandlingTest.java:336) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:316) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:305) ~[test-classes/:?]
> at org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy(MultipleCachesDuringConflictResolutionTest.java:60) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-11291) MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11291?page=com.atlassian.jira.plugi... ]
Ryan Emerson updated ISPN-11291:
--------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/7854, https://github.com/infinispan/infinispan/pull/7885 (was: https://github.com/infinispan/infinispan/pull/7854)
> MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
> -----------------------------------------------------------------------------------
>
> Key: ISPN-11291
> URL: https://issues.redhat.com/browse/ISPN-11291
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1, 10.1.3.Final
>
>
> Actually it fails pretty constantly in CI:
> {noformat}
> 18:59:06,673 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy[DIST_SYNC, DENY_READ_WRITES]
> java.lang.RuntimeException: Cache Test timed out waiting for rebalancing to complete on node Test-NodeA, current topology is CacheTopology{id=8, phase=CONFLICT_RESOLUTION, rebalanceId=4, currentCH=PartitionerConsistentHash:DefaultConsistentHash{ns=256, owners = (2)[Test-NodeB: 256+0, Test-NodeA: 0+256]}, pendingCH=null, unionCH=null, actualMembers=[Test-NodeB, Test-NodeA], persistentUUIDs=[95c5afaf-de70-49f5-a494-4ae634425e9b, 73824c63-18cb-4de3-a714-b1b1b3fe5713]}. rebalanceInProgress=true, currentChIsBalanced=true
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:435) ~[test-classes/:?]
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:502) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.waitForPartitionToForm(BasePartitionHandlingTest.java:336) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:316) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:305) ~[test-classes/:?]
> at org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy(MultipleCachesDuringConflictResolutionTest.java:60) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-11291) MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11291?page=com.atlassian.jira.plugi... ]
Ryan Emerson updated ISPN-11291:
--------------------------------
Fix Version/s: 10.1.3.Final
> MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
> -----------------------------------------------------------------------------------
>
> Key: ISPN-11291
> URL: https://issues.redhat.com/browse/ISPN-11291
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1, 10.1.3.Final
>
>
> Actually it fails pretty constantly in CI:
> {noformat}
> 18:59:06,673 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy[DIST_SYNC, DENY_READ_WRITES]
> java.lang.RuntimeException: Cache Test timed out waiting for rebalancing to complete on node Test-NodeA, current topology is CacheTopology{id=8, phase=CONFLICT_RESOLUTION, rebalanceId=4, currentCH=PartitionerConsistentHash:DefaultConsistentHash{ns=256, owners = (2)[Test-NodeB: 256+0, Test-NodeA: 0+256]}, pendingCH=null, unionCH=null, actualMembers=[Test-NodeB, Test-NodeA], persistentUUIDs=[95c5afaf-de70-49f5-a494-4ae634425e9b, 73824c63-18cb-4de3-a714-b1b1b3fe5713]}. rebalanceInProgress=true, currentChIsBalanced=true
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:435) ~[test-classes/:?]
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:502) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.waitForPartitionToForm(BasePartitionHandlingTest.java:336) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:316) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:305) ~[test-classes/:?]
> at org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy(MultipleCachesDuringConflictResolutionTest.java:60) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-11291) MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11291?page=com.atlassian.jira.plugi... ]
Ryan Emerson reopened ISPN-11291:
---------------------------------
> MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy random failures
> -----------------------------------------------------------------------------------
>
> Key: ISPN-11291
> URL: https://issues.redhat.com/browse/ISPN-11291
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1, 10.1.3.Final
>
>
> Actually it fails pretty constantly in CI:
> {noformat}
> 18:59:06,673 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy[DIST_SYNC, DENY_READ_WRITES]
> java.lang.RuntimeException: Cache Test timed out waiting for rebalancing to complete on node Test-NodeA, current topology is CacheTopology{id=8, phase=CONFLICT_RESOLUTION, rebalanceId=4, currentCH=PartitionerConsistentHash:DefaultConsistentHash{ns=256, owners = (2)[Test-NodeB: 256+0, Test-NodeA: 0+256]}, pendingCH=null, unionCH=null, actualMembers=[Test-NodeB, Test-NodeA], persistentUUIDs=[95c5afaf-de70-49f5-a494-4ae634425e9b, 73824c63-18cb-4de3-a714-b1b1b3fe5713]}. rebalanceInProgress=true, currentChIsBalanced=true
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:435) ~[test-classes/:?]
> at org.infinispan.test.TestingUtil.waitForNoRebalance(TestingUtil.java:502) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.waitForPartitionToForm(BasePartitionHandlingTest.java:336) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:316) ~[test-classes/:?]
> at org.infinispan.partitionhandling.BasePartitionHandlingTest$Partition.merge(BasePartitionHandlingTest.java:305) ~[test-classes/:?]
> at org.infinispan.conflict.impl.MultipleCachesDuringConflictResolutionTest.testPartitionMergePolicy(MultipleCachesDuringConflictResolutionTest.java:60) ~[test-classes/:?]
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ISPN-8628) Simplify QueryEngine handling of Broadcast vs Fetch queries
by Nistor Adrian (Jira)
[ https://issues.redhat.com/browse/ISPN-8628?page=com.atlassian.jira.plugin... ]
Nistor Adrian commented on ISPN-8628:
-------------------------------------
Are the culprits gone, or why is this 'out of date'? The title may be out of date but the description seems to reflect current state .
> Simplify QueryEngine handling of Broadcast vs Fetch queries
> -----------------------------------------------------------
>
> Key: ISPN-8628
> URL: https://issues.redhat.com/browse/ISPN-8628
> Project: Infinispan
> Issue Type: Task
> Reporter: Gustavo Fernandes
> Assignee: Nistor Adrian
> Priority: Minor
>
> [~anistor] commented
> The existence of RemoteQueryDefinition and HsQueryRequest seems to be a symptom of misplaced responsibility. It all starts with QueryDefinition.initialize, which IMO should actually be placed inside QueryEngine, not QueryDefinition. Doing that refactoring will remove the need for RemoteQueryDefinition, which now exists just to differentiate between embedded and remote case, but that differentiation can be done inside the query engine itself. Also, HsQueryRequest is just a data holder that carries the return value of QueryEngine.createHsQuery. If QueryDefinition.initialize is moved to QueryEngine we would also not need this anymore.
> I did not think about it in detail but maybe we would also need to make QueryDefinition mutable for QueryEngine and immutable for external parties. In that case we can extract QueryDefinition as an immutable interface (exposing getters only) and it's implementation class could have package local setters accessible to QueryEngine only.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month