[JBoss JIRA] (ISPN-11993) Allow automatic registration of Protobuf schemas and marshallers
by Ryan Emerson (Jira)
Ryan Emerson created ISPN-11993:
-----------------------------------
Summary: Allow automatic registration of Protobuf schemas and marshallers
Key: ISPN-11993
URL: https://issues.redhat.com/browse/ISPN-11993
Project: Infinispan
Issue Type: Feature Request
Components: Hot Rod, Marshalling
Affects Versions: 11.0.0.CR1
Reporter: Ryan Emerson
Assignee: Ryan Emerson
Fix For: 12.0.0.Final
Currently it's necessary for users to automatically add {{SerializationContextIntializer}} instances to the client via {{addContextInitializers}} and for .proto files to be registered like so:
{code:java}
Path proto = Paths.get(Query.class.getClassLoader().getResource("proto/sheep.proto").toURI());
cacheManager.getCache(ProtobufMetadataManagerConstants.PROTOBUF_METADATA_CACHE_NAME).put("sheep.proto", Files.readString(proto));
{code}
Instead we should allow users to configure the client so that:
# {{SerializationContextInitalizer}} services are automatically registerd if {{builder.autoAddAllContextInitializers()}} is configured.
# {{*.proto}} files on the classpath and in available {{SerializationContextInitializers}} are automatically registered with the server if {{.autoRegisterSchemas()}} is configured.
ProtoStreams {{AutoProtoSchemaBuilder}} already provides a `service` attribute to generate the service files for {{SerializationContextInitiailizer}}, however this is false by default. We should update this to true so that users have one less knob to confgure.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (ISPN-11993) Allow automatic registration of Protobuf schemas and marshallers
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-11993?page=com.atlassian.jira.plugi... ]
Ryan Emerson updated ISPN-11993:
--------------------------------
Description:
Currently it's necessary for users to automatically add {{SerializationContextIntializer}} instances to the client via {{addContextInitializers}} and for .proto files to be registered like so:
{code:java}
Path proto = Paths.get(Query.class.getClassLoader().getResource("proto/sheep.proto").toURI());
cacheManager.getCache(ProtobufMetadataManagerConstants.PROTOBUF_METADATA_CACHE_NAME).put("sheep.proto", Files.readString(proto));
{code}
Instead we should allow users to configure the client so that:
# {{SerializationContextInitalizer}} services are automatically registerd if {{builder.autoAddAllContextInitializers()}} is configured.
# {{*.proto}} files on the classpath and in available {{SerializationContextInitializers}} are automatically registered with the server if {{.autoRegisterSchemas()}} is configured.
ProtoStreams {{AutoProtoSchemaBuilder}} already provides a `service` attribute to generate the service files for {{SerializationContextInitiailizer}}, however this is false by default. We should update this to true so that users have one less knob to confgure.
was:
Currently it's necessary for users to automatically add {{SerializationContextIntializer}} instances to the client via {{addContextInitializers}} and for .proto files to be registered like so:
{code:java}
Path proto = Paths.get(Query.class.getClassLoader().getResource("proto/sheep.proto").toURI());
cacheManager.getCache(ProtobufMetadataManagerConstants.PROTOBUF_METADATA_CACHE_NAME).put("sheep.proto", Files.readString(proto));
{code}
Instead we should allow users to configure the client so that:
# {{SerializationContextInitalizer}} services are automatically registerd if {{builder.autoAddAllContextInitializers()}} is configured.
# {{*.proto}} files on the classpath and in available {{SerializationContextInitializers}} are automatically registered with the server if {{.autoRegisterSchemas()}} is configured.
ProtoStreams {{AutoProtoSchemaBuilder}} already provides a `service` attribute to generate the service files for {{SerializationContextInitiailizer}}, however this is false by default. We should update this to true so that users have one less knob to confgure.
> Allow automatic registration of Protobuf schemas and marshallers
> ----------------------------------------------------------------
>
> Key: ISPN-11993
> URL: https://issues.redhat.com/browse/ISPN-11993
> Project: Infinispan
> Issue Type: Feature Request
> Components: Hot Rod, Marshalling
> Affects Versions: 11.0.0.CR1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 12.0.0.Final
>
>
> Currently it's necessary for users to automatically add {{SerializationContextIntializer}} instances to the client via {{addContextInitializers}} and for .proto files to be registered like so:
> {code:java}
> Path proto = Paths.get(Query.class.getClassLoader().getResource("proto/sheep.proto").toURI());
> cacheManager.getCache(ProtobufMetadataManagerConstants.PROTOBUF_METADATA_CACHE_NAME).put("sheep.proto", Files.readString(proto));
> {code}
> Instead we should allow users to configure the client so that:
> # {{SerializationContextInitalizer}} services are automatically registerd if {{builder.autoAddAllContextInitializers()}} is configured.
> # {{*.proto}} files on the classpath and in available {{SerializationContextInitializers}} are automatically registered with the server if {{.autoRegisterSchemas()}} is configured.
> ProtoStreams {{AutoProtoSchemaBuilder}} already provides a `service` attribute to generate the service files for {{SerializationContextInitiailizer}}, however this is false by default. We should update this to true so that users have one less knob to confgure.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (ISPN-11992) Convert RemoteStore to use new SPI
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11992?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11992:
------------------------------
Fix Version/s: 11.0.1.Final
> Convert RemoteStore to use new SPI
> ----------------------------------
>
> Key: ISPN-11992
> URL: https://issues.redhat.com/browse/ISPN-11992
> Project: Infinispan
> Issue Type: Enhancement
> Components: Loaders and Stores
> Reporter: Will Burns
> Priority: Major
> Fix For: 12.0.0.Final, 11.0.1.Final
>
>
> The RemoteStore already uses a non blocking client. We should convert it to the new SPI to utilize this.
> We also need to add in a check for the old server to see how many segments it has. If the number is different than the current server we need to disable the segmentation characteristic and instead do the costlier iteration.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months
[JBoss JIRA] (ISPN-11991) Docs: Iteration during RU returns incorrect values if numSegments does not match
by Donald Naro (Jira)
[ https://issues.redhat.com/browse/ISPN-11991?page=com.atlassian.jira.plugi... ]
Donald Naro updated ISPN-11991:
-------------------------------
Description: {color:#172b4d}make sure it is documented that while a rolling upgrade procedure is occurring iteration upon the new server may result in incorrect values if the # of segments has changed{color} (was: Unfortunately retrieveEntries method always chooses a random server to send a request to. This is fine when segments is not provided. However if an explicit set of segments is provided we should route the request to the address that has the most segments of the set and hasn't failed yet.)
> Docs: Iteration during RU returns incorrect values if numSegments does not match
> --------------------------------------------------------------------------------
>
> Key: ISPN-11991
> URL: https://issues.redhat.com/browse/ISPN-11991
> Project: Infinispan
> Issue Type: Bug
> Components: Hot Rod
> Reporter: Donald Naro
> Assignee: Will Burns
> Priority: Major
>
> {color:#172b4d}make sure it is documented that while a rolling upgrade procedure is occurring iteration upon the new server may result in incorrect values if the # of segments has changed{color}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 10 months