[JBoss JIRA] (ISPN-12103) Improve ContainerDatabase to add custom wait strategy
by Gustavo Lira e Silva (Jira)
Gustavo Lira e Silva created ISPN-12103:
-------------------------------------------
Summary: Improve ContainerDatabase to add custom wait strategy
Key: ISPN-12103
URL: https://issues.redhat.com/browse/ISPN-12103
Project: Infinispan
Issue Type: Enhancement
Components: Test Suite
Affects Versions: 11.0.1.Final
Reporter: Gustavo Lira e Silva
Assignee: Gustavo Lira e Silva
Some databases needs extra container privilege and also needs a custom {{waitstrategy}} instead of just use the default {{Wait.forListeningPort()}}, for example DB2 needs an extra time after the ListeningPorts be available to create the datasource and finish the setup.
The idea is to implement a {{LogMessageWaitStrategy}} with a regex expression to identify when the container is ready indeed.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo updated ISPN-11336:
-------------------------------
Sprint: DataGrid Sprint #46
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Assignee: Pedro Ruivo
> Priority: Major
> Fix For: 12.0.0.Dev01
>
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo updated ISPN-11336:
-------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/8536
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Assignee: Pedro Ruivo
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo reassigned ISPN-11336:
----------------------------------
Assignee: Pedro Ruivo
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Assignee: Pedro Ruivo
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo updated ISPN-11336:
-------------------------------
Fix Version/s: 12.0.0.Dev01
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Assignee: Pedro Ruivo
> Priority: Major
> Fix For: 12.0.0.Dev01
>
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo updated ISPN-11336:
-------------------------------
Status: Open (was: New)
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Stéphane Nicoll (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Stéphane Nicoll commented on ISPN-11336:
----------------------------------------
Thanks for the reply. Yeah it's ignored by Maven,I agree.
It's been too long and I should have attached a sample project that reproduces the problem. I don't remember what I did to trigger this but I didn't use this plugin directly or override its version.
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Pedro Ruivo commented on ISPN-11336:
------------------------------------
I agree on the {{pluginManagement}} shouldn't be there. But, on other hand, it is ignored by Maven so it shouldn't cause any issues (at least, it isn't cause any issues in other our projects).
You have the wrong version set. The plugin version to use with Infinispan 10.1.1.Final is 1.0.1.Final (see https://github.com/infinispan/infinispan/blob/10.1.1.Final/build-configur...). Are you replacing the property somewhere?
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-11336) Infinispan BOM should only have dependency management
by Stéphane Nicoll (Jira)
[ https://issues.redhat.com/browse/ISPN-11336?page=com.atlassian.jira.plugi... ]
Stéphane Nicoll edited comment on ISPN-11336 at 7/9/20 8:42 AM:
----------------------------------------------------------------
This issue prevents the Spring Boot project to use the BOM for its dependency management. As we have to copy over all modules, fixing this issue would help us be consistent with what this project wants to promote.
Edit: I was unable to reproduce those warnings although the original description is still valid. Removing plugin management for that plugin that is no longer published as well as the referenced entry in dependency management would be nice regardless.
was (Author: snicoll):
This issue prevents the Spring Boot project to use the BOM for its dependency management. As we have to copy over all modules, fixing this issue would help us be consistent with what this project wants to promote.
> Infinispan BOM should only have dependency management
> -----------------------------------------------------
>
> Key: ISPN-11336
> URL: https://issues.redhat.com/browse/ISPN-11336
> Project: Infinispan
> Issue Type: Bug
> Components: Build
> Affects Versions: 10.1.2.Final
> Reporter: Stéphane Nicoll
> Priority: Major
>
> The BOM has a {{pluginManagement}} section that's a bit misleading since Maven isn't going to do anything with it.
> It is also invalid at the moment per the following:
> {code:xml}
> <plugin>
> <groupId>org.infinispan.maven-plugins</groupId>
> <artifactId>protocol-parser-generator</artifactId>
> <version>${version.infinispan.maven-plugins}</version>
> </plugin>
> {code}
> This artifact does not seem to be published anymore. Using the BOM with resolution leads to
> {noformat}
> [WARNING] The POM for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final is missing, no dependency information available
> [WARNING] Failed to retrieve plugin descriptor for org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final: Plugin org.infinispan:infinispan-protocol-parser-generator-maven-plugin:10.1.1.Final or one of its dependencies could not be resolved: Failure to find org.infinispan:infinispan-protocol-parser-generator-maven-plugin:jar:10.1.1.Final in https://repo.spring.io/milestone was cached in the local repository, resolution will not be reattempted until the update interval of spring-milestones has elapsed or updates are forced
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months
[JBoss JIRA] (ISPN-12096) ConfigurationBuilder::withProperties should not overwrite the transactionMode
by Ryan Emerson (Jira)
[ https://issues.redhat.com/browse/ISPN-12096?page=com.atlassian.jira.plugi... ]
Ryan Emerson resolved ISPN-12096.
---------------------------------
Resolution: Done
> ConfigurationBuilder::withProperties should not overwrite the transactionMode
> -----------------------------------------------------------------------------
>
> Key: ISPN-12096
> URL: https://issues.redhat.com/browse/ISPN-12096
> Project: Infinispan
> Issue Type: Bug
> Components: Hot Rod
> Affects Versions: 11.0.1.Final
> Reporter: Diego Lovison
> Assignee: Pedro Ruivo
> Priority: Major
> Fix For: 12.0.0.Dev01
>
>
> ConfigurationBuilder::withProperties should not overwrite the transactionMode
>
> {noformat}
> if (transactionMode != null) {
> config.transaction().transactionMode(TransactionMode.valueOf(transactionMode));
> }
> config.maxRetries(maxRetries).socketTimeout(connectionTimeout).connectionTimeout(connectionTimeout);
> if (propertiesPath != null) {
> Properties p = new Properties();
> try (Reader r = new FileReader(propertiesPath)) {
> p.load(r);
> config.withProperties(p);
> } catch (IOException e) {
> throw new IllegalStateException("Something went wrong with provided properties file:" + propertiesPath, e);
> }
> }
> return config;
> }{noformat}
>
> {noformat}
> infinispan.client.hotrod.auth_username=admin
> infinispan.client.hotrod.auth_password=password
> infinispan.client.hotrod.auth_realm=default
> infinispan.client.hotrod.sasl_mechanism=SCRAM-SHA-512{noformat}
>
>
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 9 months