1:56 a.m.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Manik Surtani
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1205:
----------------------------------------
@Manik, I know this code well, so feel free to assign it to me.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Manik Surtani
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:29 a.m.
New subject: [JBoss JIRA] Assigned: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Pete Muir reassigned ISPN-1205:
-------------------------------
Assignee: Galder Zamarreño (was: Manik Surtani)
Galder, if you can take this, I can then work in the classloader changes. I can discuss
with you what I see if the current problem if that helps.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:14 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1205:
----------------------------------------
Sure Pete. Let me get familiar with your comments in ISPN-1096 and I'll ping you if I
have any doubts or other ideas.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:20 p.m.
New subject: [JBoss JIRA] Work started: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Work on ISPN-1205 started by Galder Zamarreño.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:50 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1205:
----------------------------------------
Some important considerations:
- Transport (global component), requires a marshaller to be set on startup (JGroups
mandates this) as part of the RpcDispatcher initialization.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño edited comment on ISPN-1205 at 7/25/11 1:12 PM:
-----------------------------------------------------------------
Correction:
Some important considerations:
- Transport (global component), requires a marshaller to be set on the given
RpcDispatcher. It's not clear when this needs doing, but could deferred to a cache
component startup (i.e. RpcManager) rather than rely on the global component startup (i.e.
Transport)
was (Author: galder.zamarreno):
Some important considerations:
- Transport (global component), requires a marshaller to be set on startup (JGroups
mandates this) as part of the RpcDispatcher initialization.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:57 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1205:
----------------------------------------
A bit of restructuring of marshallers is needed here and hence it's not a trivial
task. Basically, two types of marshallers are needed here: one global, one per cache. The
global one is needed for JGroups marshaller, because when it gets JGroups message and it
needs to unmarshall it, it has no clue which cache's marshaller to use and you
can't just give any cache's marshaller to it. The per cache marshaller is the one
that can be associated with a classloader via AdvancedCache.with() and the one that can
marshalling for MarshalledValues...etc.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1205:
----------------------------------------
Noting a future improvement that is not likely to go in this version because it'd
require a fairly big restructuring:
Enable a multiplexing marshaller architecture where the cache name is marshalled before
any CacheRpcCommand which then can be read by the unmarshalling side and select the
unmarshaller to unmarshall the rest of the command. Currently the cache name is embedded
within the command's parameters, which means that it is marshalled by
ReplicableCommandExternalizer, if the cache name is amongst the parameters. At the moment
the cache name is embedded far enough in the marshalling chain that is not easy to carry
on reading the stream with a different marshaller.
If I resolve this JIRA and this is not in, I'll create a JIRA for future improvements
in this area. To clarify, the aim of this JIRA is to solve the use case where lazy
deserialization can be done using the cache loader provided by the user. This, and the
fact that a cache can now be associated with a classloader means that we need a marshaller
per cache.
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:06 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1205:
-----------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/infinispan/infinispan/pull/503
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:08 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1205:
-----------------------------------
Fix Version/s: 5.1.0.ALPHA1
(was: 5.1.0.BETA1)
Git Pull Request: https://github.com/infinispan/infinispan/pull/503 (was:
https://github.com/infinispan/infinispan/pull/503)
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.ALPHA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-1205) Redesign marshallers to be per named cache instance, per thread
[
https://issues.jboss.org/browse/ISPN-1205?page=com.atlassian.jira.plugin....
]
Manik Surtani updated ISPN-1205:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Redesign marshallers to be per named cache instance, per thread
---------------------------------------------------------------
Key: ISPN-1205
URL: https://issues.jboss.org/browse/ISPN-1205
Project: Infinispan
Issue Type: Feature Request
Affects Versions: 5.0.0.CR6
Reporter: Pete Muir
Assignee: Galder Zamarreño
Fix For: 5.1.0.ALPHA1
Since we have switched to explicit classloaders in Infinispan 5.0, we can now pass the
correct classloader to use into JBoss Marshalling, rather than rely on the TCCL. However
at the moment marshallers are per thread, not per named cache instance. We will need to
change the way marshallers are created to make a marshaller
per-thread-per-named-cache-instance. This will also require investigation of the best way
of propagating this through the DI system. Dan has previously suggested using the
InvocationContext
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4652
days inactive
4698
days old
infinispan-issues@lists.jboss.org
11 comments
3 participants
participants (3)
-
Galder Zamarreño (JIRA) -
Manik Surtani (JIRA)
-
Pete Muir (JIRA)