[JBoss JIRA] Created: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
1:57 p.m.
JdbcStringBasedCacheStore loads previous data from store before an insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.2.0.ALPHA2, 4.1.0.Final, 4.0.0.Final
Reporter: Sanne Grinovero
Assignee: Manik Surtani
Fix For: 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Sanne Grinovero updated ISPN-686:
---------------------------------
Assignee: Mircea Markus (was: Manik Surtani)
Fix Version/s: 4.2.0.BETA1
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Sanne Grinovero commented on ISPN-686:
--------------------------------------
Instead of using "ON DUPLICATE KEY UPDATE" I'm now using MySQL's other
proprietary extension: "REPLACE". In case people wished to use MyISAM engine,
they could even use "REPLACE DELAYED" which seems to nicely fit the requirements
for this.
To use these I had to implement a new custom CacheStore extending
JdbcStringBasedCacheStore; I could contribute this if there's interest, but I think
there would be more value in fixing the existing JdbcStringBasedCacheStore and letting
users override the full SQL statement, or plug this logic in the existing database
autodetect: I guess other RDBMS could have similar tricks to use.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Trustin Lee commented on ISPN-686:
----------------------------------
I think I can take this issue. Feel free to assign it to me unless someone is already
working on it.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [JBoss JIRA] Assigned: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Sanne Grinovero reassigned ISPN-686:
------------------------------------
Assignee: Trustin Lee (was: Mircea Markus)
great! thanks
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:53 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Trustin Lee commented on ISPN-686:
----------------------------------
Infinispan already has an abstraction called TableManipulation which is basically a
factory of SQL strings. I think we can add TableManipulation.getInsertOrUpdateRowSql().
The default implementation could return null (i.e. no proprietary extension), and a user
could override it.
Another possible optimization is to attempt an UPDATE first instead of SELECT. If the
number of updated rows is 0, we can execute an INSERT. Assuming UPDATE is more common
than INSERT, we save one statement.
WDYT? (Just making sure because I'm not sure I'm so familiar with the codebase
yet :)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:12 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Sanne Grinovero commented on ISPN-686:
--------------------------------------
+1 for the new tablemanipulation method.
I won't assume update is more common, in the case of the LuceneDirectory it's
extremely unlikely, it's picking a new key for each write; (that's why I'm
attempting to avoid the return value at all costs, totally pointless).
Assuming we go for the UPDATE + INSERT strategy, is there a lock on the key held to
protect from a race condition?
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:51 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Mircea Markus updated ISPN-686:
-------------------------------
Fix Version/s: 4.2.0.BETA1
(was: 4.2.0.ALPHA4)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final, 4.2.0.ALPHA2
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 4.2.0.BETA1, 4.2.0.Final, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:53 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://jira.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.sys...
]
Trustin Lee updated ISPN-686:
-----------------------------
Fix Version/s: 5.0.0.BETA1
(was: 4.2.0.Final)
(was: 4.2.0.BETA1)
Affects Version/s: (was: 4.2.0.ALPHA2)
Will fix this issue along with TableManipulation redesign which is going to occur in 5.0
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://jira.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 5.0.0.BETA1, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [JBoss JIRA] Assigned: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Mircea Markus reassigned ISPN-686:
----------------------------------
Assignee: Mircea Markus (was: Trustin Lee)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 5.0.0.BETA1, 5.0.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:39 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño updated ISPN-686:
----------------------------------
Fix Version/s: 5.0.0.BETA2
(was: 5.0.0.BETA1)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 5.0.0.BETA2, 5.0.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño updated ISPN-686:
----------------------------------
Fix Version/s: 5.0.0.CR1
(was: 5.0.0.BETA2)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Mircea Markus
Fix For: 5.0.0.CR1, 5.0.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 p.m.
New subject: [JBoss JIRA] Assigned: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero reassigned ISPN-686:
------------------------------------
Assignee: Trustin Lee (was: Mircea Markus)
re-assigning back to Trustin.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 5.0.0.CR1, 5.0.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño updated ISPN-686:
----------------------------------
Fix Version/s: 5.0.0.CR2
(was: 5.0.0.CR1)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 5.0.0.CR2, 5.0.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:36 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Trustin Lee updated ISPN-686:
-----------------------------
Fix Version/s: 5.1.0.BETA1
5.1.0.Final
(was: 5.0.0.FINAL)
(was: 5.0.0.CR2)
Rescheduling to 5.1.0.BETA1 to be in line with ISPN-701
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Trustin Lee
Fix For: 5.1.0.BETA1, 5.1.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Manik Surtani updated ISPN-686:
-------------------------------
Assignee: Galder Zamarreño (was: Trustin Lee)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Galder Zamarreño
Fix For: 5.1.0.BETA1, 5.1.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño updated ISPN-686:
----------------------------------
Fix Version/s: 5.2.0.FINAL
(was: 5.1.0.BETA1)
(was: 5.1.0.FINAL)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Galder Zamarreño
Fix For: 5.2.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:35 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño reassigned ISPN-686:
-------------------------------------
Assignee: Tristan Tarrant (was: Galder Zamarreño)
@Tristan, assigning this to you since you're already looking into ISPN-701, Ok? Cheers
:)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Tristan Tarrant
Fix For: 5.2.0.FINAL
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:24 a.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm reassigned ISPN-686:
---------------------------------
Assignee: Thomas Fromm (was: Tristan Tarrant)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:26 a.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm commented on ISPN-686:
-----------------------------------
I took this one, since I need a optimization shortly. My simple approach is just execute
Select ID w/o unmarshall maybe existing stuff to decide of insert/update should be used.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm edited comment on ISPN-686 at 8/29/12 9:08 AM:
------------------------------------------------------------
I took this one, since I need a optimization shortly. My simple approach is just execute
Select ID w/o unmarshall maybe existing stuff to decide of insert/update should be used.
Bonus TODO: Encapsulate the select and insert/update into one transaction to avoid
SQLIntegrityConstraintViolationExceptions...
was (Author: tfromm):
I took this one, since I need a optimization shortly. My simple approach is just
execute Select ID w/o unmarshall maybe existing stuff to decide of insert/update should be
used.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:26 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero commented on ISPN-686:
--------------------------------------
Hi Thomas,
"select ID" looks like a good compromise, but which DB are you using? As I
mentioned above (years ago!) MySQL is able to deal with it in a single statement; Back in
that time I was an external contributor, but shared my custom implementation using MySQL
as a patch - should be in the mailing lists archive, but worth looking for only if you
intend to MySQL.
I'm glad that someone finally volunteers on this :)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:32 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm commented on ISPN-686:
-----------------------------------
I'm aware about the Insert or Update stuff of some databases. Due customers the main
use case for me is the good old Oracle :-) And there I'd need to create a pl/sql
procedure to get this :-|
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:52 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm updated ISPN-686:
------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/1269
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm commented on ISPN-686:
-----------------------------------
The mentioned sultion with "select ... for update" in a transaction makes in
this case no sense, because this would only affect of the entry exists. So the risk with
"SQLIntegrityConstraintViolationExceptions." still exists with this generic
solution. Luckily I did not run anymore in this exception under load ;-)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm edited comment on ISPN-686 at 8/30/12 7:53 AM:
------------------------------------------------------------
The mentioned sultion with "select ... for update" in a transaction makes in
this case no sense, because this would only affect of the entry exists. So the risk with
"SQLIntegrityConstraintViolationExceptions." still exists with this generic
solution. Luckily I did not run anymore in this exception under load ;-) So seems to be
better now...
was (Author: tfromm):
The mentioned sultion with "select ... for update" in a transaction makes in
this case no sense, because this would only affect of the entry exists. So the risk with
"SQLIntegrityConstraintViolationExceptions." still exists with this generic
solution. Luckily I did not run anymore in this exception under load ;-)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Tristan Tarrant updated ISPN-686:
---------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/1269 (was:
https://github.com/infinispan/infinispan/pull/1269)
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Alpha3, 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:37 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Tristan Tarrant updated ISPN-686:
---------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 5.2.0.Alpha3
Resolution: Done
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Alpha3, 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero commented on ISPN-686:
--------------------------------------
I wonder if the race condition is really possible with a write-through configuration: in
theory the writing node owns a lock on the written entry.
I guess it's more tricky for async cacheloader: it's unlikely because of the
de-duplication of writes on the same key, but still possible.
Yes for Oracle you need a stored procedure to implement it properly, but what's wrong
with suggesting & documenting that? Especially as many other databases do have a
solution, like UPSERT or MERGE.
I don't like the Transactions approach as it could interfere with other transactions
integration; this doesn't look like the proper layer to manage transactions.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Alpha3, 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:48 p.m.
New subject: [JBoss JIRA] (ISPN-686) JdbcStringBasedCacheStore loads previous data from store before an insert
[
https://issues.jboss.org/browse/ISPN-686?page=com.atlassian.jira.plugin.s...
]
Thomas Fromm commented on ISPN-686:
-----------------------------------
I think this can be done within ISPN-701. If API design is finished, I can provide Oracle
specific stuff if wanted.
JdbcStringBasedCacheStore loads previous data from store before an
insert
-------------------------------------------------------------------------
Key: ISPN-686
URL: https://issues.jboss.org/browse/ISPN-686
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 4.0.0.Final, 4.1.0.Final
Reporter: Sanne Grinovero
Assignee: Thomas Fromm
Fix For: 5.2.0.Alpha3, 5.2.0.Final
The JdbcStringBasedCacheStore implementation loads the previous data on an insert to find
out if it should generate an UPDATE or INSERT statement, while it would perform much
better to just verify if the primary key exists.
On top of this, some databases provide ways to avoid the need to check at all, like
MySQL's " INSERT ... ON DUPLICATE KEY UPDATE"
[http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4256
days inactive
4953
days old
infinispan-issues@lists.jboss.org
29 comments
7 participants
participants (7)
-
Galder Zamarreño (JIRA) -
Manik Surtani (JIRA)
-
Mircea Markus (JIRA)
-
Sanne Grinovero (JIRA)
-
Thomas Fromm (JIRA)
-
Tristan Tarrant (JIRA)
-
Trustin Lee (JIRA)