[ https://issues.jboss.org/browse/ISPN-1369?page=com.atlassian.jira.plugin.... ] Paul Ferraro updated ISPN-1369: ------------------------------- Description: Since c3p0 is only used for pooled connection factories, it should not be a required runtime dependency. Specifically, AS7 would rather not pull in c3p0 since AS7 will always use this cache store in conjunction with a managed connection factory. To make c3p0 optional, c3p0 classes should only be imported by the PooledConnectionFactory itself. Currently, there are c3p0 import statements within org.infinispan.loaders.jdbc.logging.Log which prevent c3p0 from being "optional". N.B. To indicate an optional dependency in maven: <dependency> <groupId>c3p0</groupId> <artifactId>c3p0</artifactId> <version>...</version> <optional>true</optional> </dependency> This will prevent c3p0 from being treated as a transient dependency of org.infinispan:infinispan-cachestore-jdbc. was: Since c3p0 is only used for pooled connection factories, it should not be a required runtime dependency. Specifically, AS7 would rather not pull in c3p0 since AS7 will always use this cache store in conjunction with a managed connection factory. To make c3p0 optional, c3p0 classes should only be imported by the PooledConnectionFactory itself. Currently, there are c3p0 import statements within org.infinispan.loaders.jdbc.logging.Log which prevent c3p0 from being "optional". N.B. To indicate a optional dependency in maven: <dependency> <groupId>c3p0</groupId> <artifactId>c3p0</artifactId> <version>...</version> <optional>true</optional> </dependency> This will prevent c3p0 from being treated as a transient dependency of org.infinispan:infinispan-cachestore-jdbc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1369?page=com.atlassian.jira.plugin.... ] Tristan Tarrant updated ISPN-1369: ---------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/infinispan/infinispan/pull/621 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1369?page=com.atlassian.jira.plugin.... ] Sanne Grinovero updated ISPN-1369: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira