[JBoss JIRA] Created: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
10:12 a.m.
Cache store modification types Prepare and Commit and related classes should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
[
https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño commented on ISPN-913:
---------------------------------------
PurgeExpired also needs looking into. org.infinispan.loaders.modifications.PurgeExpired is
no longer in use, and so the case statements for PURGE_EXPIRED are not used any more,
since PurgeExpired is never created anywhere in the production code. Since AsyncStore does
not override purgeExpired(), this means that purging is directly directed to the
underlying cache store.
Cache store modification types Prepare and Commit and related classes
should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Task
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
[
https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero commented on ISPN-913:
--------------------------------------
??Since AsyncStore does not override purgeExpired(), this means that purging is directly
directed to the underlying cache store.??
I believe that was a conscious design choice, to avoid wasting resources and such. You
think I should make that async?
Cache store modification types Prepare and Commit and related classes
should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Task
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:30 p.m.
New subject: [JBoss JIRA] Resolved: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
[
https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero resolved ISPN-913.
----------------------------------
Resolution: Done
Cache store modification types Prepare and Commit and related classes
should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Task
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:31 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
[
https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño commented on ISPN-913:
---------------------------------------
No at all, I think it's fine as is. I was just trying to see if the actual
org.infinispan.loaders.modifications.PurgeExpired was in use.
Cache store modification types Prepare and Commit and related classes
should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Task
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.Final, 5.0.0.ALPHA3, 5.0.0.Final
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:43 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-913) Cache store modification types Prepare and Commit and related classes should be removed
[
https://issues.jboss.org/browse/ISPN-913?page=com.atlassian.jira.plugin.s...
]
Galder Zamarreño updated ISPN-913:
----------------------------------
Fix Version/s: 4.2.1.CR2
(was: 4.2.1.Final)
(was: 5.0.0.Final)
Cache store modification types Prepare and Commit and related classes
should be removed
---------------------------------------------------------------------------------------
Key: ISPN-913
URL: https://issues.jboss.org/browse/ISPN-913
Project: Infinispan
Issue Type: Task
Components: Loaders and Stores
Reporter: Galder Zamarreño
Assignee: Sanne Grinovero
Fix For: 4.2.1.CR2, 5.0.0.ALPHA3
What are the roles of Modification.Type: PREPARE, COMMIT ? These are no longer used for
anything, including their correspondent org.infinispan.loaders.modifications.Prepare and
org.infinispan.loaders.modifications.Commit classes. Since these are internal classes, we
should get rid of them directly.
It appears that since Sanne added ModificationList as type of modification in 4.1
(ISPN-618), Prepare/Commit are no longer in use.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4828
days inactive
4839
days old
infinispan-issues@lists.jboss.org
5 comments
2 participants
participants (2)
-
Galder Zamarreño (JIRA) -
Sanne Grinovero (JIRA)