[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-1190: ----------------------------------- Description: ModuleProperties can create class memory leaks, because it contains static collections with references to user defined classes: {code}private static Map<Byte,Class<? extends ModuleCommandInitializer>> commandInitializers; private static Collection<Class<? extends ReplicableCommand>> moduleCommands;{code} Also, the following two collections could contain references to instances of user defined classes in static collections: {code}private static Map<String,ModuleProperties> moduleProperties; private static Map<Byte,ModuleCommandFactory> commandFactories;{code} These collections should not be static, and their clearing should be guaranteed at stoppage time. Even if there's any issues at stoppage time, they should not leak and so any collections containing Class instances should be weakly referenced. was: ModuleProperties can create class memory leaks, because it contains static collections with references to user defined class instances: {code}private static Map<Byte,Class<? extends ModuleCommandInitializer>> commandInitializers; private static Collection<Class<? extends ReplicableCommand>> moduleCommands;{code} Also, the following two collections could contain references to instances user defined classes in static collections: {code}private static Map<String,ModuleProperties> moduleProperties; private static Map<Byte,ModuleCommandFactory> commandFactories;{code} These collections should not be static, and their clearing should be guaranteed at stoppage time. Even if there's any issues at stoppage time, they should not leak and so any collections containing Class instances should be weakly referenced. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-1190: ---------------------------------------- True, most likely it'd be used by other Infinispan modules, but nothing really stops ends users from defining their own commands. So, the option is always there to cause some havoc. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Manik Surtani commented on ISPN-1190: ------------------------------------- Hmm, this needs more thought. Generally, end users making use of module properties should be unsupported and if this results in a classloader leak, well, you were told not to use it. :) A weak map won't help since the keys are typically Strings or bytes, which will be around for the lifetime of the JVM. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Galder Zamarreño commented on ISPN-1190: ---------------------------------------- Yeah, weak maps won't help for moduleProperties and commandFactories, but they would with the first two. I'm fine with it being unsupported for end users. We need to make sure though that EDG reflects this. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Manik Surtani commented on ISPN-1190: ------------------------------------- Another alternative would be to not use the static map at all, but to make this a per-cache map. But this means re-scanning for each cache instance which isn't so nice in terms of performance. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Manik Surtani commented on ISPN-1190: ------------------------------------- Repurposing this jira to cover ISPN-1374 too: {quote} The class org.infinispan.util.ModuleProperties is being invoked with a classloader parameter, but will cache whatever it builds in static fields, and the cached values are returned to subsequent invocations whatever the classloader being used at the new invocation. Seems related to ISPN-1190: I think the ModuleProperties should not use static fields at all. {quote} -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-1190?page=com.atlassian.jira.plugin.... ] Sanne Grinovero updated ISPN-1190: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira