[ https://jira.jboss.org/jira/browse/ISPN-435?page=com.atlassian.jira.plugi... ] Daniel Cullender updated ISPN-435: ---------------------------------- Description: A simple test case shows what the subtlety is : Properties p = new Properties(); p.put("hi", "there"); System.out.println(p.get("hi")); System.out.println(p.containsKey("hi")); /* * creates a defensive copy of p - however, this creates a reference in the * properties object to the properties, so direct calls to the parent map do * not work as expected */ Properties p2 = new Properties(p); System.out.println(p2.get("hi")); System.out.println(p2.containsKey("hi")); This produces the following output there true null false Now, Infinispan does the following org.infinispan.factories.NamedExecutorsFactory : private ExecutorService buildAndConfigureExecutorService(String factoryName, Properties p, String componentName) throws Exception { Properties props = new Properties(p); // defensive copy ExecutorFactory f = (ExecutorFactory) Util.getInstance(factoryName); setComponentName(componentName, props); setDefaultThreads(KnownComponentNames.getDefaultThreads(componentName), props); setDefaultThreadPrio(KnownComponentNames.getDefaultThreadPrio(componentName), props); return f.getExecutor(props); } ... private void setDefaultThreadPrio(int prio, Properties props) { if (!props.containsKey("threadPriority")) props.setProperty("threadPriority", String.valueOf(prio)); } private void setDefaultThreads(int numThreads, Properties props) { if (!props.containsKey("maxThreads")) props.setProperty("maxThreads", String.valueOf(numThreads)); } The buildAndConfigureExecutorService method makes a defensive copy of the properties, but the helper methods (example : setDefaultThreads) uses the containsKey method from java.util.Properties which will return false based on the previous example. This means that the properties specified for the Async Listeners will not be set, but rather defaulted because of this subtlety. was: A simple test case shows what the subtlety is : Properties p = new Properties(); p.put("hi", "there"); System.out.println(p.get("hi")); System.out.println(p.containsKey("hi")); /* * creates a defensive copy of p - however, this creates a reference in the * properties object to the properties, so direct calls to the parent map do * not work as expected */ Properties p2 = new Properties(p); System.out.println(p2.get("hi")); System.out.println(p2.containsKey("hi")); This produces the following output there true null false Now, Infinispan does the following org.infinispan.factories.NamedExecutorsFactory : private ExecutorService buildAndConfigureExecutorService(String factoryName, Properties p, String componentName) throws Exception { Properties props = new Properties(p); // defensive copy ExecutorFactory f = (ExecutorFactory) Util.getInstance(factoryName); setComponentName(componentName, props); setDefaultThreads(KnownComponentNames.getDefaultThreads(componentName), props); setDefaultThreadPrio(KnownComponentNames.getDefaultThreadPrio(componentName), props); return f.getExecutor(props); } ... private void setDefaultThreadPrio(int prio, Properties props) { if (!props.containsKey("threadPriority")) props.setProperty("threadPriority", String.valueOf(prio)); } private void setDefaultThreads(int numThreads, Properties props) { if (!props.containsKey("maxThreads")) props.setProperty("maxThreads", String.valueOf(numThreads)); } The buildAndConfigureExecutorService method makes a defensive copy of the properties, but the helper methods (example : setDefaultThreads) uses the containsKey method from java.util.Properties which will return false based on the previous example. This means that the properties specified for the Async Listeners will not be set, but rather defaulted because of this subtlety. Before logging a Jira, does anyone know if this has been fixed and there is a patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/ISPN-435?page=com.atlassian.jira.plugi... ] Daniel Cullender updated ISPN-435: ---------------------------------- Description: A simple test case shows what the subtlety is : Properties p = new Properties(); p.put("hi", "there"); System.out.println(p.get("hi")); System.out.println(p.containsKey("hi")); /* * attempt a defensive copy of p - however, this only sets the defaults in the new * properties object, so direct calls to the parent map do * not work as expected */ Properties p2 = new Properties(p); System.out.println(p2.get("hi")); System.out.println(p2.containsKey("hi")); This produces the following output there true null false Now, Infinispan does the following org.infinispan.factories.NamedExecutorsFactory : private ExecutorService buildAndConfigureExecutorService(String factoryName, Properties p, String componentName) throws Exception { Properties props = new Properties(p); // defensive copy ExecutorFactory f = (ExecutorFactory) Util.getInstance(factoryName); setComponentName(componentName, props); setDefaultThreads(KnownComponentNames.getDefaultThreads(componentName), props); setDefaultThreadPrio(KnownComponentNames.getDefaultThreadPrio(componentName), props); return f.getExecutor(props); } ... private void setDefaultThreadPrio(int prio, Properties props) { if (!props.containsKey("threadPriority")) props.setProperty("threadPriority", String.valueOf(prio)); } private void setDefaultThreads(int numThreads, Properties props) { if (!props.containsKey("maxThreads")) props.setProperty("maxThreads", String.valueOf(numThreads)); } The buildAndConfigureExecutorService method attempts a defensive copy of the properties (but just sets the defaults for props instead), and the helper methods (example : setDefaultThreads) uses the containsKey method from java.util.Properties which will return false based on the previous example. This means that the properties specified for the Async Listeners will not be set, but rather defaulted because of this subtlety. was: A simple test case shows what the subtlety is : Properties p = new Properties(); p.put("hi", "there"); System.out.println(p.get("hi")); System.out.println(p.containsKey("hi")); /* * creates a defensive copy of p - however, this creates a reference in the * properties object to the properties, so direct calls to the parent map do * not work as expected */ Properties p2 = new Properties(p); System.out.println(p2.get("hi")); System.out.println(p2.containsKey("hi")); This produces the following output there true null false Now, Infinispan does the following org.infinispan.factories.NamedExecutorsFactory : private ExecutorService buildAndConfigureExecutorService(String factoryName, Properties p, String componentName) throws Exception { Properties props = new Properties(p); // defensive copy ExecutorFactory f = (ExecutorFactory) Util.getInstance(factoryName); setComponentName(componentName, props); setDefaultThreads(KnownComponentNames.getDefaultThreads(componentName), props); setDefaultThreadPrio(KnownComponentNames.getDefaultThreadPrio(componentName), props); return f.getExecutor(props); } ... private void setDefaultThreadPrio(int prio, Properties props) { if (!props.containsKey("threadPriority")) props.setProperty("threadPriority", String.valueOf(prio)); } private void setDefaultThreads(int numThreads, Properties props) { if (!props.containsKey("maxThreads")) props.setProperty("maxThreads", String.valueOf(numThreads)); } The buildAndConfigureExecutorService method makes a defensive copy of the properties, but the helper methods (example : setDefaultThreads) uses the containsKey method from java.util.Properties which will return false based on the previous example. This means that the properties specified for the Async Listeners will not be set, but rather defaulted because of this subtlety. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira