[ https://jira.jboss.org/browse/ISPN-772?page=com.atlassian.jira.plugin.sys... ] Scott Marlow updated ISPN-772: ------------------------------ Description: I'm seeing the following sequence of invocations during AS cluster classloader leak unit tests: 1. InvocationContextContainerImpl.createInvocationContext creates a new LocalTxInvocationContext (lets call it #3011) and sets thread local (icTL) to it. 2. InvocationContextContainerImpl.suspend() LocalTxInvocationContext #3011 which clears the thread local reference. 3. We InvocationContextContainerImpl.resume() LocalTxInvocationContext #3011 which sets the thread local reference. 4. We InvocationContextContainerImpl.suspend() LocalTxInvocationContext #3011 which clears the thread local reference. 5. We InvocationContextContainerImpl.resume() LocalTxInvocationContext #3011 which sets the thread local reference. I don't see another suspend call, so LocalTxInvocationContext #3011 is still referenced by the thread local InvocationContextContainerImpl.icTL which keeps the classloader in memory (the icTL reference is the only reference to the classloader). Call stack showing where the LocalTxInvocationContext was created from http://pastie.org/1300157 was: I'm seeing the following sequence of invocations during AS cluster classloader leak unit tests: 1. InvocationContextContainerImpl.createInvocationContext creates a new LocalTxInvocationContext (lets call it #3011) and sets thread local (icTL) to it. 2. InvocationContextContainerImpl.suspend() LocalTxInvocationContext #3011 which clears the thread local reference. 3. We InvocationContextContainerImpl.resume() LocalTxInvocationContext #3011 which sets the thread local reference. 4. We InvocationContextContainerImpl.suspend() LocalTxInvocationContext #3011 which clears the thread local reference. 5. We InvocationContextContainerImpl.resume() LocalTxInvocationContext #3011 which sets the thread local reference. I don't see another suspend call, so LocalTxInvocationContext #3011 is still referenced by the thread local InvocationContextContainerImpl.icTL which keeps the classloader in memory (the icTL reference is the only reference to the classloader). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/ISPN-772?page=com.atlassian.jira.plugin.sys... ] Scott Marlow reassigned ISPN-772: --------------------------------- Assignee: Scott Marlow (was: Manik Surtani) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/ISPN-772?page=com.atlassian.jira.plugin.sys... ] Scott Marlow commented on ISPN-772: ----------------------------------- I'll push a patch in the morning for org.infinispan.transaction.xa.TransactionXaAdapter. I changed commit & rollback methods to call icc.suspend(). icc.suspend is currently the only way to clear the thread local storage. With my current patch, the AS clustered class loader leak test failures are fixed. One alternative would be to register a synchronization callback to handle calling icc.suspend after the transaction ends. It looks like InvocationContextContainerImpl has a reference to the TM but that might be null (InvocationContextContainerImpl.getRunningTx() tests tm for nulll). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/ISPN-772?page=com.atlassian.jira.plugin.sys... ] Manik Surtani reopened ISPN-772: -------------------------------- Assignee: Manik Surtani (was: Scott Marlow) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/ISPN-772?page=com.atlassian.jira.plugin.sys... ] Manik Surtani resolved ISPN-772. -------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira