[jboss-remoting-issues] [JBoss JIRA] Closed: (JBREM-1166) Possible race condition in ConnectionValidator

Possible race condition in ConnectionValidator ---------------------------------------------- Key: JBREM-1166 URL: https://jira.jboss.org/jira/browse/JBREM-1166 Project: JBoss Remoting Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 2.2.3, 2.2.3.SP1, 2.5.2 (Flounder) Reporter: Takayoshi Kimura Assignee: Ron Sigal Fix For: 2.5.2.SP2 (Flounder), 2.2.3.SP2, 2.5.2.SP1 (Flounder) The 2.2.3 has a minor regression. The ConnectionValidator#start() has been moved outside of synchronized block in this release, this leads a race condition problem. ConnectionValidator#start(): TimerUtil.schedule(this, pingPeriod); // will call ConnectionValidator.run() timer = new Timer(true); // is used in ConnectionValidator.run() These 2 lines looks odd, because it initializes the timer for new thread after spawn the thread. In 2.2.2-SP11 the timer variable is protected by synchronized blocks, so it's not the case.