[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Richard Achmatowicz commented on JBREM-1164: -------------------------------------------- 1. The -b command-line parameter gets substituted into the system property jboss.bind_address. Many Connector MBeans construct their InvokerLocator URL by simply substituting $jboss.bind_address into a URL string, like this: <bean name="org.jboss.ejb3.RemotingConnector" class="org.jboss.remoting.transport.Connector"> <property name="invokerLocator"> <value-factory bean="ServiceBindingManager" method="getStringBinding"> <parameter> jboss.remoting:type=Connector,name=DefaultEjb3Connector,handler=ejb3</parameter> <parameter><null /></parameter> <parameter>socket://${jboss.bind.address}:${port}</parameter> <parameter><null /></parameter> <parameter>3873</parameter> </value-factory> </property> <property name="serverConfiguration"><inject bean="ServerConfiguration" /></property> </bean> The InvokerLocator is then initialised with the URL socket://${jboss.bind.address}:${port}. 2. The InvokerLocator has a constuctor InvokerLocator(String uri) which takes a URI string and does one of two things: (i) parses the URI using the URI constructor, plus a few pieces of magic (ii) parses the URI using a legacy parsing algorithm The URI constructor assumes that if the URI invoves a IPv6 host name, that the hostname is enclosed in brackets. If the hostname is not enclosed in brackets, it does not throw a URISyntaxException (which I would have hoped) but instead returns host == null, port == -1. The legacy parsing code does not handle IPv6 addresses, from what I can see, based on how it deals with colons. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Richard Achmatowicz commented on JBREM-1164: -------------------------------------------- Because the URI constructor returns null for the host, the method resolveHost() sets the host to localhost or 127.0.0.1. This is what I am seeing when I start AS 5 with IPv6 addresses not enclosed in brackets. If the URI contains an IPv6 address which is enclosed in brackets, the host is correctly set to the IPv6 address with the brackets remaining. Here are some results of a test done: URI components for http://192.168.0.100:8080/a/b/c?key=val: protocol: http ,host: 192.168.0.100 ,port: 8080 ,path: /a/b/c ,query: key=val URI components for http://3ffe:ffff:100:f101::2:8080/a/b/c?key=val: protocol: http ,host: 127.0.0.1 ,port: -1 ,path: /a/b/c ,query: key=val URI components for http://[3ffe:ffff:100:f101::2]:8080/a/b/c?key=val: protocol: http ,host: [3ffe:ffff:100:f101::2] ,port: 8080 ,path: /a/b/c ,query: key=val URI components for http://[fe80::60d1:6eff:fe9d:f87b%eth0]:8080/a/b/c?key=val: protocol: http ,host: [fe80::60d1:6eff:fe9d:f87b%eth0] ,port: 8080 ,path: /a/b/c ,query: key=val It would be nice to be able the InvokerLocator to check for the special case where an IPv6 address is not enclosed in brackets in a URL and add them. But this would require separating the IPv6 host from the rest of the URL by hand. Even if the URISyntaxException were raised, we would still have to do this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal commented on JBREM-1164: ---------------------------------- There are two ways InvokerLocators are created in the Application Server environment: 1. An InvokerLocator can be constructed from the pieces specified in an XML file. (a) For JBossMessaging, the InvokerLocator is created from an MBean configuration in remoting-bisocket-service.xml: <invoker transport="bisocket"> ... <attribute name="serverBindAddress">${jboss.bind.address}</attribute> <attribute name="serverBindPort">${jboss.messaging.connector.bisocket.port:4457}</attribute> ... (b) For EJB2s, the InvokerLocator is created from a ServerConfiguration POJO in remoting-jboss-beans.xml: <property name="invokerLocatorParameters"> <map keyClass="java.lang.String" valueClass="java.lang.String"> <entry> <key>serverBindAddress</key> <value> <value-factory bean="ServiceBindingManager" method="getStringBinding"> <parameter>UnifiedInvokerConnector</parameter> <parameter>${host}</parameter> </value-factory> </value> </entry> <entry> <key>serverBindPort</key> <value> <value-factory bean="ServiceBindingManager" method="getStringBinding"> <parameter>UnifiedInvokerConnector</parameter> <parameter>${port}</parameter> </value-factory> </value> </entry> In each of these cases, the InvokerLocator is assembled by the org.jboss.remoting.transport.Connector being configured, and it would be easy to test for an IPv6 address and add brackets as appropriate. 2. An InvokerLocator can be specified explicitly and injected into the Connector. EJB3 does that in ejb3-connectors-jboss-beans.xml: <value-factory bean="ServiceBindingManager" method="getStringBinding"> <parameter> jboss.remoting:type=Connector,name=DefaultEjb3Connector,handler=ejb3 </parameter> <parameter> <null /> </parameter> <parameter>socket://${jboss.bind.address}:${port}</parameter> <parameter> <null /> </parameter> <parameter>3873</parameter> </value-factory> If the value of ${jboss.bind.address} is an IPv6 address, then the resulting InvokerLocator will be ill-formed; e.g., socket://::127.0.0.1:3873. In this case, Connector could check for the presence of more than one ":" in the "host/port" part, and, if there are more than one ":", then it could treat the last ":" delimited field as the port, the rest as the host, and add brackets accordingly. Richard, what do you think? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Richard Achmatowicz commented on JBREM-1164: -------------------------------------------- Apolgies for the delay in responding to your posting, Ron. Got bogged down a bit. I am in complete agreement with your analysis. In the interim, I was working on JBPAPP-3018, and found that all Remoting IPv6 issues could be solved with two mechanisms: (i) a change to Connector to cause it to check for and properly construct InvokerLocator URIs, assuming that the serverBindAddress does not contain enclosing brackets (as you rightly pointed out that it should not) (ii) when specifying InvokerLocator URLs explicitly, use a newly defined system property jboss.bind.url.address in place of jboss.bind.address in the URL (e.g socket://${jboss.bind.url.address}:${port}) where the function of this system property is to provide a hostname suitable for enclosure in a URL. This was suggested by DML. Only the former requires a change, and I gave an example patch on JBPAPP-3018. With these two changes in place, the AS 4.2.x CP branch seems to start OK. Checking JNDIView and the logs reveals no remoting related IPv4 addresses when binding with an IPv6 bind address. This isn't a guarantee that all is well, but its a good start. Unfortunately, there are other issues to work out before we can run the testsuite with IPv6 bind addresses and no brackets. The change also does not affect existing IPv4 usage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal updated JBREM-1164: ----------------------------- Fix Version/s: 2.2.3.SP2 Affects Version/s: 2.2.3.SP1 I've added fix version 2.2.3.SP2 since we're also talking about EAP 4.2/4.3. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal commented on JBREM-1164: ---------------------------------- We've applied Richard's patch to org.jboss.remoting.transport.Connector on branches 2.2 and 2.x. Unit tests: org.jboss.test.remoting.ipv6.IPv6HostWithNoBracketsTestCase. Waiting for hudson results. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal commented on JBREM-1164: ---------------------------------- Note. java.net.URI parsing in jdk 1.4 doesn't handle a trailing % field properly, e.g. "3ffe:1900:4545:3:200:f8ff:fe21:67cf%5". Those tests are omitted in the presence of jdk 1.4. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal reopened JBREM-1164: ------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBREM-1164?page=com.atlassian.jira.plu... ] Ron Sigal closed JBREM-1164. ---------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira