Hi!
Wonderful job! It looks familiar now, since it's following the same
quickstarts structure and patterns.
Congrats to everyone.
Some considerations or things to be discussed:
- Removal of
https://github.com/jboss-fuse/quickstarts/tree/master/template folder
- Maybe add instructions to the root README about the need to install
the
https://github.com/jboss-fuse/quickstarts/tree/master/bom
- Add instructions to the root README about adding repository URLs to
settings.xml and remove it from pom.xml
https://github.com/jboss-fuse/quickstarts/blob/master/cbr/pom.xml#L99-L122
- Add reference to each README to an setup (install bom, add
repositories to settings.xml) prior running the example. Example:
https://github.com/jboss-jdf/jboss-as-quickstart/tree/master/helloworld-j...
- It seems that the name are not following the pattern "JBoss Fuse
Quickstart: <folder-name>"
https://github.com/jboss-fuse/quickstarts/blob/master/jms/pom.xml#L26
- I think we should use "fuse" as the artifact prefix like we did for
BRMS, WFK and sandbox - QSTools config:
https://github.com/jboss-jdf/qstools/blob/master/config/qstools_config.ya...
Besides that small things, it's excellent! Good job!!!
Em 13/08/13 06:12, Antoine Sabot-Durand escreveu:
Hi all,
Hanneli and I have just finished to refactor Fuse example in JDF quick start format.
You'll find them here :
https://github.com/jboss-fuse/quickstarts
Your feedback is most welcome.
Antoine