4:57 a.m.
On Tue, Aug 06, 2013 at 02:31:44PM +0200, Eric D. Schabell wrote:
https://github.com/eschabell/brms-customer-evaluation-demo/blob/master/Qu...
https://github.com/eschabell/brms-rewards-demo/blob/master/Quick%20Start%...
https://github.com/eschabell/brms-coolstore-demo/blob/master/Quick%20Star...
Thanks, and now github stopped showing angry unicorns so I can actually see the examples.
First of, i'm all for getting more examples in, but I'm also really not a fan of
handing out instructions/urls that is known to be bad/too temporary.
But lets see what we can do about them - if this just stays in the sandbox and are clearly
marked experimental I don't have a problem, having it available is better than to hide
it completely.
Non-stable plugin updatesite url
================================
First issue is the use of
http://download.jboss.org/jbosstools/updates/integration/kepler/integration-
stack/aggregate/4.1.0/ as the updatesite url to add. This url is *not* a stable url and
will not be guaranteed to exist nor contain what will work with your examples. I've
asked SOA tooling guys to provide a stable url for community usage but that have not
happened yet and thus i'm stuck waiting for them to release a JBDS 7 update url.
Besides the url being non-stable it definitely should not be used together with JBDS 5 and
6 since if you add this updatesite to JBDS 5 and 6 and you run Help > Update it will
pick up newer versions of eclipse/jbds which probably is *not* what the user
wanted/expected. (note, the instructions just seem to talk about JBDS 7so thats fine, just
referring to you saying it works on JBDS 5 and 6 too).
Finally, that url contains *more* than what is supported - i.e. savara tooling is not a
supported tech yet. It's the community version as opposed to the supported version.
Non-clean pom versioning
========================
Second issue is that the GAV's seem to be using the BRMS version for the jars instead
of the actual base community version of the jars.
i.e. 5.3.1.BRMS seem to be the base for all in here but org.drools and org.jbpm wasn't
released under a 5.3.1.* version afaics.
Can't these be updated to actually use the proper versions following the Project Wolf
guidelines ?
Note: if jbpm and drools actually released 5.3.1 and that is what BRMS 5.3.1 is based on
then we are all good - but that is just not
my understanding on how BRMS was built, i.e. jbpm was 5.2.x and drools 5.3.x (according to
Julien from productization)
wdyt ?
/max
On Aug 6, 2013, at 14:03 , Max Rydahl Andersen
<manderse(a)redhat.com> wrote:
> On Tue, Aug 06, 2013 at 10:20:18AM +0200, Eric D. Schabell wrote:
>> Hey Max,
>>
>> I have run the originals on JBDS 5, 6 and 7.
>>
>> The current ones we branched for this will work on JBDS 6 or 7, as stated in the
docs included (QuickStartGuides).
>
> neither of those have brms included out of box - which updatesite did you use ?
>
> Can you link me to the docs ?
>
> /max
>
>> -- erics
>>
>> On Aug 6, 2013, at 09:39 , Max Rydahl Andersen <manderse(a)redhat.com>
wrote:
>>
>>> github is currently serving angry unicorns so can't see these but I'm
wondering how well these loads in jbt/jbds and what versions of JBTIS is needed for these
to run out-of-the-box ?
>>>
>>> Anyone knows ?
>>>
>>> /max
>>>
>>> On Thu, Jul 25, 2013 at 05:19:39PM -0300, Rafael Benevides wrote:
>>>> This is the first PR of the BRMS quickstarts to align it to JDF
Guidelines.
>>>>
>>>> I would like a detailed review on this quickstart (specially on the way
it is organized since it is a little bit different from all other quickstarts).
>>>>
>>>> This are the changes made:
>>>>
>>>> - Removed eclipse files (.project, .classpath, .settings)
>>>> - Added License Headers
>>>> - Added License to pom.xml
>>>> - Changed groupId, version and name to match JDF rules
>>>> - Changed pom property from brms-version to version.brms
>>>> - Added Readme.md file ( I tried to keep it simple )
>>>> - Format source code as https://github.com/jboss/ide-config definition
>>>>
>>>> The Pull Request with the changes is
https://github.com/eschabell/brms-customer-evaluation-demo/pull/3
>>>>
>>>> I'd like your revision and opinion and since we get an approval (and
merge) those changes, I can move forward to update all other quickstarts using the same
criteria.
>>>>
>>>> For the last, we will add them as git submodule (for each quickstart
under a brms-quickstarts folder) on https://github.com/jboss-jdf/jboss-as-quickstart
>>>>
>>>> Eric,
>>>>
>>>> You did a nice job on those quickstarts!
>>>>
>>>> --
>>>> Rafael Benevides | Senior Software Engineer
>>>> Red Hat Brazil
>>>> +55-61-9269-6576
>>>>
>>>> Better technology. Faster innovation. Powered by community
collaboration.
>>>> See how it works at redhat.com
>>>>
>>>
>>>> _______________________________________________
>>>> jdf-dev mailing list
>>>> jdf-dev(a)lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jdf-dev
>>>
>>