Just an additional thought. This is already possible with the jboss-as-maven-plugin. The one thing we could add to the plugin would be to allow for wildcard files which could be beneficial anyway. Example*: <plugin> <groupId>org.jboss.as.plugins</groupId> <artifactId>jboss-as-maven-plugin</artifactId> <version>${version.jboss.maven.plugin}</version> <inherited>true</inherited> <configuration> <skip>true</skip> </configuration> <executions> <execution> <id>start-server</id> <phase>process-resources</phase> <goals> <goal>start</goal> </goals> <configuration> <jboss-as-version>${version.org.jboss.as.dist}</jboss-as-version> </configuration> </execution> <execution> <id>validate-scripts</id> <phase>process-resources</phase> <goals> <goal>execute-commands</goal> </goals> <configuration> <execute-commands> <scripts> <script>${project.basedir}/deltaspike-helloworld-jms/configure-jms.cli</script> <script>${project.basedir}/deltaspike-helloworld-jms/remove-jms.cli</script> </scripts> </execute-commands> </configuration> </execution> <execution> <id>shutdown-server</id> <phase>process-resources</phase> <goals> <goal>shutdown</goal> </goals> </execution> </executions> </plugin> * Note: This uses the 7.4.Final version of the plugin On 05/14/2013 09:52 AM, James R. Perkins wrote: > I started a conversion on a PR, https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., about creating a maven plugin to validate the CLI scripts in the Quickstarts. > > Pete suggested this might be a good thing for Arquillian to support. I did find and arquillian-maven plugin [1], but it looks like it hasn't been updated in a while. I'm also not sure if the ARQ API can handle scripts. I don't mind helping update the plugin if that seems like a viable solution. Also I don't mind adding support to the WildFly ARQ to allow for scripts. > > If anyone has any thoughts or opinions on this feel free to express them. I'm not sure if we even want to do the validation, but it does seem it would be useful. Especially as quickstart targeted servers change. > > [1]: https://github.com/arquillian/arquillian-maven > -- > James R. Perkins > JBoss by Red Hat > -- James R. Perkins JBoss by Red Hat _______________________________________________ jdf-dev mailing list jdf-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jdf-dev

...are these scripts *required* to run the examples the projects ? Or are they just custom goals you can run as a one-off to change the server or would they *always* be executed ? And i'm wondering if we should add a "Run on server" feature in eclipse to run these easily from the IDE against a server already configured... /max On Tue, May 14, 2013 at 09:52:48AM -0700, James R. Perkins wrote: > I started a conversion on a PR, https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., > about creating a maven plugin to validate the CLI scripts in the > Quickstarts. > > Pete suggested this might be a good thing for Arquillian to support. I > did find and arquillian-maven plugin [1], but it looks like it hasn't > been updated in a while. I'm also not sure if the ARQ API can handle > scripts. I don't mind helping update the plugin if that seems like a > viable solution. Also I don't mind adding support to the WildFly ARQ > to allow for scripts. > > If anyone has any thoughts or opinions on this feel free to express > them. I'm not sure if we even want to do the validation, but it does > seem it would be useful. Especially as quickstart targeted servers > change. > > [1]: https://github.com/arquillian/arquillian-maven > > -- > James R. Perkins > JBoss by Red Hat > > _______________________________________________ > jdf-dev mailing list > jdf-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jdf-dev _______________________________________________ jdf-dev mailing list jdf-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jdf-dev

...and never mind - this is in quickstarts which are server specific...dont need to be portable. /max On Wed, May 15, 2013 at 08:16:21AM -0400, Sande Gilda wrote: > As background, this all started as a requirement for the quickstarts. > Some require specific server configuration. Originally we provided > XML snippets to paste into the server configuration file. Then we > added the jboss-cli commands to achieve the same goal. Now I have an > outstanding pull with CLI scripts that configure the server and > remove the configuration after testing is complete. I tested the > scripts, but asked James to take a look at them to make sure they > looked OK. > > > On 05/15/2013 06:26 AM, Max Rydahl Andersen wrote: >> ...are these scripts *required* to run the examples the projects ? >> >> Or are they just custom goals you can run as a one-off to change the >> server >> or would they *always* be executed ? >> >> And i'm wondering if we should add a "Run on server" feature in >> eclipse to >> run these easily from the IDE against a server already configured... >> >> /max >> >> On Tue, May 14, 2013 at 09:52:48AM -0700, James R. Perkins wrote: >>> I started a conversion on a PR, >>> https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., >>> about creating a maven plugin to validate the CLI scripts in the >>> Quickstarts. >>> >>> Pete suggested this might be a good thing for Arquillian to support. I >>> did find and arquillian-maven plugin [1], but it looks like it hasn't >>> been updated in a while. I'm also not sure if the ARQ API can handle >>> scripts. I don't mind helping update the plugin if that seems like a >>> viable solution. Also I don't mind adding support to the WildFly ARQ >>> to allow for scripts. >>> >>> If anyone has any thoughts or opinions on this feel free to express >>> them. I'm not sure if we even want to do the validation, but it does >>> seem it would be useful. Especially as quickstart targeted servers >>> change. >>> >>> [1]: https://github.com/arquillian/arquillian-maven >>> >>> -- >>> James R. Perkins >>> JBoss by Red Hat >>> >>> _______________________________________________ >>> jdf-dev mailing list >>> jdf-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jdf-dev >> _______________________________________________ >> jdf-dev mailing list >> jdf-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jdf-dev >

As Sande said the new, unmerged, scripts aren't required. They're just there for convenience instead of having to manually edit XML. Being able to run a CLI script on a server from the IDE would be pretty awesome. Do you guys use the CLI public API at all? If not that would work quite well for a feature like this. On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: > ...are these scripts *required* to run the examples the projects ? > Or are they just custom goals you can run as a one-off to change the > server or would they *always* be executed ? > > And i'm wondering if we should add a "Run on server" feature in > eclipse to > run these easily from the IDE against a server already configured... > > /max > > On Tue, May 14, 2013 at 09:52:48AM -0700, James R. Perkins wrote: >> I started a conversion on a PR, >> https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., >> about creating a maven plugin to validate the CLI scripts in the >> Quickstarts. >> >> Pete suggested this might be a good thing for Arquillian to support. >> I did find and arquillian-maven plugin [1], but it looks like it >> hasn't been updated in a while. I'm also not sure if the ARQ API can >> handle scripts. I don't mind helping update the plugin if that seems >> like a viable solution. Also I don't mind adding support to the >> WildFly ARQ to allow for scripts. >> >> If anyone has any thoughts or opinions on this feel free to express >> them. I'm not sure if we even want to do the validation, but it does >> seem it would be useful. Especially as quickstart targeted servers >> change. >> >> [1]: https://github.com/arquillian/arquillian-maven >> >> -- >> James R. Perkins >> JBoss by Red Hat >> >> _______________________________________________ >> jdf-dev mailing list >> jdf-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jdf-dev

On Wed, May 15, 2013 at 12:08:50PM -0400, Sande Gilda wrote: > I think Pete considered scripts a requirement for testing. The pull > is based on this issue he created: > https://github.com/jboss-jdf/jboss-as-quickstart/issues/243 testing by the user, or testing by us of the quickstarts?

> I consider them a requirement because some of the configuration are > extensive and you need to not only configure the server, but remove > the configurations when testing is complete. Some requre more than 10 > separate commands, and, not only do you get tired of copying and > pasting that many individual CLI commands, the process can be error > prone. With scripts, you can be assured the server will be configured > and restored correctly. :-) If they match the exact server version I reckon ? or are these cli scripts somewhat compatible ?

/max > On 05/15/2013 11:23 AM, James R. Perkins wrote: >> As Sande said the new, unmerged, scripts aren't required. They're just >> there for convenience instead of having to manually edit XML. >> >> Being able to run a CLI script on a server from the IDE would be pretty >> awesome. Do you guys use the CLI public API at all? If not that would >> work quite well for a feature like this. >> >> On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: >>> ...are these scripts *required* to run the examples the projects ? >>> Or are they just custom goals you can run as a one-off to change the >>> server or would they *always* be executed ? >>> >>> And i'm wondering if we should add a "Run on server" feature in >>> eclipse to >>> run these easily from the IDE against a server already configured... >>> >>> /max >>> >>> On Tue, May 14, 2013 at 09:52:48AM -0700, James R. Perkins wrote: >>>> I started a conversion on a PR, >>>> https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., >>>> >>>> about creating a maven plugin to validate the CLI scripts in the >>>> Quickstarts. >>>> >>>> Pete suggested this might be a good thing for Arquillian to support. >>>> I did find and arquillian-maven plugin [1], but it looks like it >>>> hasn't been updated in a while. I'm also not sure if the ARQ API can >>>> handle scripts. I don't mind helping update the plugin if that seems >>>> like a viable solution. Also I don't mind adding support to the >>>> WildFly ARQ to allow for scripts. >>>> >>>> If anyone has any thoughts or opinions on this feel free to express >>>> them. I'm not sure if we even want to do the validation, but it does >>>> seem it would be useful. Especially as quickstart targeted servers >>>> change. >>>> >>>> [1]: https://github.com/arquillian/arquillian-maven >>>> >>>> -- >>>> James R. Perkins >>>> JBoss by Red Hat >>>> >>>> _______________________________________________ >>>> jdf-dev mailing list >>>> jdf-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jdf-dev > > _______________________________________________ > jdf-dev mailing list > jdf-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jdf-dev

On Wed, 15 May 2013 19:43:17 -0400 Sande Gilda <sgilda(a)redhat.com&gt; wrote: > On 05/15/2013 06:43 PM, Max Rydahl Andersen wrote: >> On Wed, May 15, 2013 at 12:08:50PM -0400, Sande Gilda wrote: >>> I think Pete considered scripts a requirement for testing. The pull >>> is based on this issue he created: >>> https://github.com/jboss-jdf/jboss-as-quickstart/issues/243 >> testing by the user, or testing by us of the quickstarts? >> > I think by QA: Karel and team. Pete can correct me if I'm wrong. This is an interesting point. We usually do not run cli per example, but per whole testsuite. However, I we had CLI script example, we could isolate examples better. The question is, which testing model covers real world better, whether is it to enable everything together from the beginning or whether to change configuration in less intrusive manner. I'm slightly leaning towards the first variant.

>>> I consider them a requirement because some of the configuration are >>> extensive and you need to not only configure the server, but remove >>> the configurations when testing is complete. Some requre more than 10 >>> separate commands, and, not only do you get tired of copying and >>> pasting that many individual CLI commands, the process can be error >>> prone. With scripts, you can be assured the server will be configured >>> and restored correctly. :-) >> If they match the exact server version I reckon ? or are these cli >> scripts >> somewhat compatible ? > Well, the quickstart README file files list which versions of the server > they work with, so the scripts are expected to work with those versions. :-) >> /max >> >>> On 05/15/2013 11:23 AM, James R. Perkins wrote: >>>> As Sande said the new, unmerged, scripts aren't required. They're just >>>> there for convenience instead of having to manually edit XML. >>>> >>>> Being able to run a CLI script on a server from the IDE would be pretty >>>> awesome. Do you guys use the CLI public API at all? If not that would >>>> work quite well for a feature like this. >>>> >>>> On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: >>>>> ...are these scripts *required* to run the examples the projects ? >>>>> Or are they just custom goals you can run as a one-off to change the >>>>> server or would they *always* be executed ? >>>>> >>>>> And i'm wondering if we should add a "Run on server" feature in >>>>> eclipse to >>>>> run these easily from the IDE against a server already configured... >>>>> >>>>> /max >>>>> >>>>> On Tue, May 14, 2013 at 09:52:48AM -0700, James R. Perkins wrote: >>>>>> I started a conversion on a PR, >>>>>> https://github.com/jboss-jdf/jboss-as-quickstart/pull/500#issuecomment-17..., >>>>>> >>>>>> about creating a maven plugin to validate the CLI scripts in the >>>>>> Quickstarts. >>>>>> >>>>>> Pete suggested this might be a good thing for Arquillian to support. >>>>>> I did find and arquillian-maven plugin [1], but it looks like it >>>>>> hasn't been updated in a while. I'm also not sure if the ARQ API can >>>>>> handle scripts. I don't mind helping update the plugin if that seems >>>>>> like a viable solution. Also I don't mind adding support to the >>>>>> WildFly ARQ to allow for scripts. >>>>>> >>>>>> If anyone has any thoughts or opinions on this feel free to express >>>>>> them. I'm not sure if we even want to do the validation, but it does >>>>>> seem it would be useful. Especially as quickstart targeted servers >>>>>> change. >>>>>> >>>>>> [1]: https://github.com/arquillian/arquillian-maven >>>>>> >>>>>> -- >>>>>> James R. Perkins >>>>>> JBoss by Red Hat >>>>>> >>>>>> _______________________________________________ >>>>>> jdf-dev mailing list >>>>>> jdf-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/jdf-dev >>> _______________________________________________ >>> jdf-dev mailing list >>> jdf-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jdf-dev > _______________________________________________ > jdf-dev mailing list > jdf-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jdf-dev

On Wed, May 15, 2013 at 08:23:18AM -0700, James R. Perkins wrote: > Being able to run a CLI script on a server from the IDE would be > pretty awesome. Do you guys use the CLI public API at all? If not > that would work quite well for a feature like this. what is the public API ? I just know about jboss-cli executable that can take parameters. I assume all this .cli stuff is done via these ?

Is that the API you think we should use if we did this ?

p.s. We don't bundle any jboss-cli jars in our tools since we would proably need one for each version (EAP 6.0,6.1, AS7.0, AS7.1. etc) /max > On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: >> ...are these scripts *required* to run the examples the projects ? >> Or are they just custom goals you can run as a one-off to change the >> server or would they *always* be executed ? >> >> And i'm wondering if we should add a "Run on server" feature in >> eclipse to >> run these easily from the IDE against a server already configured... >> >> /max >

> On 05/15/2013 03:42 PM, Max Rydahl Andersen wrote: >> On Wed, May 15, 2013 at 08:23:18AM -0700, James R. Perkins wrote: >>> Being able to run a CLI script on a server from the IDE would be >>> pretty awesome. Do you guys use the CLI public API at all? If not >>> that would work quite well for a feature like this. >> >> what is the public API ? >> I just know about jboss-cli executable that can take parameters. >> I assume all this .cli stuff is done via these ? > For some reason I didn't think about just passing the script to the > executable JAR :) It would require a process to be launched though. > Maybe that easy in an eclipse plugin though. Yeah - and it's in many cases preferable since it won't be able to leak memory etc. also if it uses JBoss modules it can't run embedded in a jvm without a bunch of hacks. >> >> Is that the API you think we should use if we did this ? > No I was thinking more about this one > https://community.jboss.org/wiki/JBossAS7Command-linePublicAPI. I use > it in the maven and forge plugins to execute commands on the server. > It works out quite well and you don't have to use the same version as > the target runtime. Interesting - but it does require cli jars in addition to the normal management client, right ?

/max >> >> p.s. We don't bundle any jboss-cli jars in our tools since we would >> proably >> need one for each version (EAP 6.0,6.1, AS7.0, AS7.1. etc) >> /max >> >>> On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: >>>> ...are these scripts *required* to run the examples the projects ? >>>> Or are they just custom goals you can run as a one-off to change >>>> the server or would they *always* be executed ? >>>> >>>> And i'm wondering if we should add a "Run on server" feature in >>>> eclipse to >>>> run these easily from the IDE against a server already configured... >>>> >>>> /max >>> > > -- > James R. Perkins > JBoss by Red Hat

On Wed, 15 May 2013 16:50:16 -0700 "James R. Perkins" <jperkins(a)redhat.com&gt; wrote: > On 05/15/2013 04:42 PM, Max Andersen wrote: > Yeah it would require the dependencies, but not JBoss modules. If those I Maven dependencies, they can be automatically fetched based on some metadata (where metadata equals Server associated with the project for instance) via ShrinkWrap Maven Resolver.

>> /max

On Fri, May 17, 2013 at 01:28:44PM +0200, Karel Piwko wrote: >> > >> > Interesting - but it does require cli jars in addition to the normal >> > management client, right ? >> Yeah it would require the dependencies, but not JBoss modules. > >If those I Maven dependencies, they can be automatically fetched based on >some metadata (where metadata equals Server associated with the project for >instance) via ShrinkWrap Maven Resolver. not sure how that helps ?

/max >> > >> > /max >> >>> >> >>> p.s. We don't bundle any jboss-cli jars in our tools since we would >> >>> proably >> >>> need one for each version (EAP 6.0,6.1, AS7.0, AS7.1. etc) >> >>> /max >> >>> >> >>>> On 05/15/2013 03:26 AM, Max Rydahl Andersen wrote: >> >>>>> ...are these scripts *required* to run the examples the projects ? >> >>>>> Or are they just custom goals you can run as a one-off to change >> >>>>> the server or would they *always* be executed ? >> >>>>> >> >>>>> And i'm wondering if we should add a "Run on server" feature in >> >>>>> eclipse to >> >>>>> run these easily from the IDE against a server already configured... >> >>>>> >> >>>>> /max >> >>>> >> >> >> >> -- >> >> James R. Perkins >> >> JBoss by Red Hat >> >