[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] Rafael Benevides reassigned JDF-147: ------------------------------------ Assignee: Rafael Benevides -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated JDF-147: -------------------------- Labels: deltaspike (was: ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] James Perkins commented on JDF-147: ----------------------------------- It does indeed. It uses the same annotation {{@MessageBundle}}. I know Solder originally used the shade plugin to bring in JBoss Logging and the logging tooling. One difference I see is you wouldn't use the resource bundles in the JSF page. I'm not certain the best approach there, but I'm sure there is something that could be done. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] Sande Gilda commented on JDF-147: --------------------------------- We would need to resolve how to localize labels in the JSF page though. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] James Perkins commented on JDF-147: ----------------------------------- You could still use the resource bundles used to generate the implementation classes. They follow the standard resource bundle naming convention. If I get some time on the weekend I'll do a version of the PR using JBoss Logging so we can see the differences. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] Pete Muir commented on JDF-147: ------------------------------- IMO we should go with the JBoss Logging version. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JDF-147?page=com.atlassian.jira.plugin.sy... ] Rafael Benevides updated JDF-147: --------------------------------- Status: Closed (was: Pull Request Sent) Resolution: Deferred We will update the KS to use JBoss Logging -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira