4 a.m.
Fail-fast when an <alternative> declaration in beans.xml is unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:18 a.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Ales Justin commented on WELD-1023:
-----------------------------------
@Geoffrey: can you provide an ARQ test for this?
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Geoffrey De Smet updated WELD-1023:
-----------------------------------
Priority: Optional (was: Major)
@Ales: There are a couple of other weld-seam issues with a higher priority for us. Once I
find some time, I 'll write test for those first and then maybe afterwards for this.
I've adjusted the priority of this issue accordingly to optional. Other issues like
WELD-964 are far more important. Just wanted to note this one into jira too, because it
could have saved me (and other weld users I presume) some time and confusion :)
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
Priority: Optional
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 p.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Jozef Hartinger commented on WELD-1023:
---------------------------------------
What does "unused" mean? Isn't the alternative enabled in the deployment
archive?
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
Priority: Optional
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 a.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Geoffrey De Smet commented on WELD-1023:
----------------------------------------
@Jozef: Unused means that it is not injected anywhere.
Basically, I was doing <alternatives> configuration in the wrong beans.xml
and because it didn't fail-fast is mistakenly supposed the alternative was activated,
while it was not.
Feel free to resolve this issue as won't fix if you believe it's too far fetched.
PS: I 've replaced my @Alternative usage with @Specializes (which doesn't suffer
from CDI-18) and that works like a charm.
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
Priority: Optional
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:27 a.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Jozef Hartinger commented on WELD-1023:
---------------------------------------
I don't think that failing the deployment is the right thing to do. I would suggest
issuing a warning instead. Note that this would probably work only for alternative beans
with no EL name.
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
Priority: Optional
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:52 a.m.
[
https://issues.jboss.org/browse/WELD-1023?page=com.atlassian.jira.plugin....
]
Ales Justin resolved WELD-1023.
-------------------------------
Resolution: Won't Fix
Fail-fast when an <alternative> declaration in beans.xml is
unused
------------------------------------------------------------------
Key: WELD-1023
URL: https://issues.jboss.org/browse/WELD-1023
Project: Weld
Issue Type: Enhancement
Reporter: Geoffrey De Smet
Priority: Optional
I have this in my beans.xml:
<alternatives>
<class>org.drools.guvnor.server.repository.TestRepositoryStartupService</class>
</alternatives>
The class exists, but because of whatever reason (CDI-18 in this case), it's not
used.
Yet, everything starts up happily and I think I am using my alternative (while I am not).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4678
days inactive
4760
days old
6 comments
6 participants
participants (6)
-
Ales Justin (Commented) (JIRA) -
Ales Justin (JIRA)
-
Geoffrey De Smet (Commented) (JIRA)
-
Geoffrey De Smet (Created) (JIRA)
-
Geoffrey De Smet (Updated) (JIRA)
-
Jozef Hartinger (Commented) (JIRA)