[JBoss JIRA] Created: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
by Hong Zhang (JIRA)
ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Priority: Critical
I am investigating the deployment failure when running org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that produceLightYellowPear method of LightYellowPearTree is not declared in LightYellowPearTree business interface. But LightYellowTree implements LightYellowPearTreeLocal which extends from PearTreeLocal which delares the produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for its implemented interface and super class for whether they declared this business method. But the problem is it only goes to its direct implemented interface and not the interface hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does declare this method. The RI code should be modified to check for the whole interface hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 4 months
[JBoss JIRA] Created: (WELD-308) Event errors not checked
by Santiago Pericas-Geertsen (JIRA)
Event errors not checked
------------------------
Key: WELD-308
URL: https://jira.jboss.org/jira/browse/WELD-308
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.0.0.GA
Environment: Solaris x86 / JDK 6u16 / GF v3
Reporter: Santiago Pericas-Geertsen
The following TCK test,
*.deployment.lifecycle.broken.addDefinitionError.AddDefinitionErrorTest.testObserverDefinitionErrorTreatedAsDefinitionError
fails because no exception is reported when app is deployed. There is an extension class, BeanDiscoveryObserver, which calls,
event.addDefinitionError(new AssertionError(...))
in a method that observes the AfterBeanDiscovery event. The spec says that if such an error is reported, the deployment should fail, so the tests appears to be correct.
I cannot find any code in Weld that would check the list of errors in an instance of AfterBeanDiscoveryImpl, though. This suggests that an error check is missing in Weld. The method WeldBootstrap.deployBeans() calls,
AfterBeanDiscoveryImp.fire(...)
which is a static method that creates a new instance of AfterBeanDiscoveryImpl. However, that instance is discarded after its fire() method is called.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 4 months
[JBoss JIRA] Closed: (WELD-11) Support setter injection
by Gavin King (JIRA)
[ https://jira.jboss.org/jira/browse/WELD-11?page=com.atlassian.jira.plugin... ]
Gavin King closed WELD-11.
--------------------------
Resolution: Out of Date
CDI supports setter injection:
@Inject
setFoo(Foo foo) { .... }
> Support setter injection
> ------------------------
>
> Key: WELD-11
> URL: https://jira.jboss.org/jira/browse/WELD-11
> Project: Weld
> Issue Type: Feature Request
> Components: Class Beans (Managed and Session)
> Reporter: Kabir Khan
> Fix For: 1.0.1.CR1
>
>
> On 15 Aug 2009, at 10:17, Pete Muir wrote:
> It's pretty straightforward, probably 2h work, inc. a few tests.
> Essentially, we just have to add some MethodInjectionPoints when the class based beans are created, and call them when a bean is injected. The only hard part is deciding on the exact semantics - like do the method names have to be JavaBean compliant (always start isXXX) and have void return type? what are the error conditions (can't put @Produces, @Disposes, @Observes on them) etc.
> Put a feature request in JIRA for CR2 I guess (until CR1 I have to concentrate on spec features really).
> On 14 Aug 2009, at 18:12, Kabir Khan wrote:
> kkhan:pmuir: How much work would it be to support setter injection
> [17:58]kkhan:?
> [17:59]kkhan:I know you said it is not required for 1.0 of CDI, but I think it would be nice to have
> [17:59]kkhan:especially from the MC side
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 4 months