8:18 a.m.
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [JBoss JIRA] Assigned: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Ales Justin reassigned WELD-834:
--------------------------------
Assignee: Ales Justin
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:22 p.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Manuel Hartl commented on WELD-834:
-----------------------------------
fix suggestion: change line #135 of URLScanner (v1.1.0FINAL) to
File file = new File(URLDecoder.decode(urlPath,Charset.defaultCharset().name()));
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Mickael Sauvee commented on WELD-834:
-------------------------------------
This issue does also occur for web apps deployed in tomcat 6 with # in name of the context
(multi level context). The hashes are replaced by %23.
This is a regression from 1.0.1-final and is suggest a different change (similar to the
code in 1.0.1-final) than the previous one:
In URLScanner of 1.1.1-final, add the following line #90 :
urlPath = URLDecoder.decode(urlPath, "UTF-8");
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 a.m.
New subject: [JBoss JIRA] Updated: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Ales Justin updated WELD-834:
-----------------------------
Fix Version/s: 1.2.0.Beta1
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.2.0.Beta1
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:58 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-834:
----------------------------------
URLDecoder is bad for OSX env, as it "eats" '+' chars.
Would this work?
String urlPath = urlEnum.nextElement().getFile();
// WELD-834
urlPath = urlPath.replaceAll("%", "%25");
urlPath = urlPath.replaceAll(" ", "%20");
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:15 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Manuel Hartl commented on WELD-834:
-----------------------------------
only replacing "%" and " " would work in my last problem case, yes.
but i assume we have to take for all special characters that can occur in filesystem
paths?
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:38 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-834:
----------------------------------
> but i assume we have to take for all special characters that can
occur in filesystem paths?
I agree, but otoh, I don't wanna hand-code all of this.
Yet, there is no common (& decent) util to fix this; e.g. URLDecoder is completely
broken ...
I'll extract the replace code, so in the worst case user can set its own Scanner,
overriding this replace code.
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:44 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Štěpán Mík commented on WELD-834:
---------------------------------
I don't know much about broken URLDecoder for OSX, but it seem to me like problem of
OSX Java implementation not JBoss. Clearly, URLScanner works with URLs. URLDecoder is
intended to be used for converting URL to plain String. Therefore URLScanner should use
URLDecoder. If URLDecoder implementation is wrong for OSX, then some set of URLs is not
permitted for the whole platform. These URLs would fail in another applications too. Using
custom scanner or another workarounds are (IMHO) out of scope of this bug and also out of
scope of Weld itself.
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:48 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Štěpán Mík edited comment on WELD-834 at 6/15/11 11:47 AM:
-----------------------------------------------------------
I don't know much about broken URLDecoder for OSX, but it seem to me like problem of
OSX Java implementation not JBoss. Clearly, URLScanner works with URLs. URLDecoder is
intended to be used for converting URL to plain String. Therefore URLScanner should use
URLDecoder. If URLDecoder implementation is wrong for OSX, then some set of URLs is not
permitted for the whole platform. These URLs would fail in another applications too. Using
custom scanner or another workarounds are (IMHO) out of scope of this bug and also out of
scope of Weld itself.
So I'm suggesting to use URLDecoder and let OSX users be responsible for becoming OSX
users and let them deal with their Java implementation.
was (Author: stepanmik):
I don't know much about broken URLDecoder for OSX, but it seem to me like problem
of OSX Java implementation not JBoss. Clearly, URLScanner works with URLs. URLDecoder is
intended to be used for converting URL to plain String. Therefore URLScanner should use
URLDecoder. If URLDecoder implementation is wrong for OSX, then some set of URLs is not
permitted for the whole platform. These URLs would fail in another applications too. Using
custom scanner or another workarounds are (IMHO) out of scope of this bug and also out of
scope of Weld itself.
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 a.m.
New subject: [JBoss JIRA] Resolved: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Ales Justin resolved WELD-834.
------------------------------
Resolution: Done
I don't agree with OSX comments, while also URLDecoder is one bad piece of code.
If we find something better, we can always use that,
till then this is the fix.
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 a.m.
New subject: [JBoss JIRA] Commented: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Emond Papegaaij commented on WELD-834:
--------------------------------------
The fix in this issue can cause double-escaped paths, which causes errors like: Error
handling file
/var/lib/jenkins/jobs/Wicket%2520Weld/workspace/wicket-cdi-examples/target/classes
https://github.com/papegaaij/wicket-cdi demonstrates the problem, clone the project in a
directory with a space in the name, and run 'mvn install
-Dwicket.version=1.5-RC5.1'
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:24 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Emond Papegaaij edited comment on WELD-834 at 8/25/11 8:23 AM:
---------------------------------------------------------------
The fix in this issue can cause double-escaped paths, which causes errors like: Error
handling file
/var/lib/jenkins/jobs/Wicket%2520Weld/workspace/wicket-cdi-examples/target/classes
https://github.com/papegaaij/wicket-cdi demonstrates the problem, clone the project in a
directory with a space in the name, and run 'mvn install
-Dwicket.version=1.5-RC5.1'
I've opend WELD-954 to track this.
was (Author: papegaaij):
The fix in this issue can cause double-escaped paths, which causes errors like: Error
handling file
/var/lib/jenkins/jobs/Wicket%2520Weld/workspace/wicket-cdi-examples/target/classes
https://github.com/papegaaij/wicket-cdi demonstrates the problem, clone the project in a
directory with a space in the name, and run 'mvn install
-Dwicket.version=1.5-RC5.1'
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:10 a.m.
New subject: [JBoss JIRA] (WELD-834) URLScanner can not handle paths containing spaces
[
https://issues.jboss.org/browse/WELD-834?page=com.atlassian.jira.plugin.s...
]
Manuel Hartl commented on WELD-834:
-----------------------------------
the current implementation of URLScanner. decodeURLPath(String)
does ENCODING of the URL, not decoding.
how is this supposed to work? :)
URLScanner can not handle paths containing spaces
-------------------------------------------------
Key: WELD-834
URL: https://issues.jboss.org/browse/WELD-834
Project: Weld
Issue Type: Bug
Components: Bootstrap and Metamodel API
Affects Versions: 1.1.0.Final
Environment: Windows, Jetty 7.2.2
Reporter: Štěpán Mík
Assignee: Ales Justin
Fix For: 1.1.2.Final
When actual classpath includes folder that contains spaces, URLScanner throws an
exception (java.io.FileNotFoundException). Problem is at line 93 where string holding URL
is "converted" to path just by stripping URL scheme prefix. Unfortunately,
spaces in URL are expressed either by plus sing or %20 escape sequence, which remains in
file path instead of proper URL decoding. For example "file:/C:/with%20space" is
converted to "/C:/with%20space" instead of "C:/with space".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4645
days inactive
4971
days old
13 comments
6 participants
participants (6)
-
Ales Justin (JIRA) -
Emond Papegaaij (JIRA)
-
Manuel Hartl (Commented) (JIRA)
-
Manuel Hartl (JIRA)
-
Mickael Sauvee (JIRA)
-
Štěpán Mík (JIRA)