8:59 a.m.
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:01 a.m.
New subject: [JBoss JIRA] Updated: (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Christian Bauer updated WELD-904:
---------------------------------
Description:
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
was:
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:05 a.m.
New subject: [JBoss JIRA] Updated: (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Christian Bauer updated WELD-904:
---------------------------------
Description:
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
was:
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:28 a.m.
New subject: [JBoss JIRA] Updated: (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Christian Bauer updated WELD-904:
---------------------------------
Component/s: Events
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:14 a.m.
New subject: [JBoss JIRA] Commented: (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-904:
--------------------------------
To answer your point about why the confusion - this area of the spec received heavy
editing just before the spec was submitted (in an ideal world there would be a period
during which the spec is not changed to allow the TCK to catch up, this didn't happen
in this case) so quite a few resources were out of date and it took a while to get it
correct.
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:12 a.m.
New subject: [JBoss JIRA] Commented: (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-904:
--------------------------------
Agreed. The certainly shouldn't get EVENT BAR printed twice in the second case, and I
don't think you should get it in the first case either
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:58 a.m.
New subject: [JBoss JIRA] (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Ales Justin commented on WELD-904:
----------------------------------
The problem is in @Specializes not being properly applied.
Foo's onEvent method is the only proper resolver in this case.
And that's what gets matched -- where it probably shouldn't since Foo is
specialized, hence should be excluded?
But since Bar specializes Foo, this observer method is invoked against Bar instance.
@Pete: how do we treat beans that have specialized sub-beans? Completely exclude them in
the BDA on their specialized sub-bean?
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 a.m.
New subject: [JBoss JIRA] (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on WELD-904:
--------------------------------
No, they should not be enabled, but they should still be there. Just like alternatives.
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Priority: Minor
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [JBoss JIRA] (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Ales Justin updated WELD-904:
-----------------------------
Assignee: Ales Justin
Fix Version/s: 1.1.4.Final
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Assignee: Ales Justin
Priority: Minor
Fix For: 1.1.4.Final
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:08 a.m.
New subject: [JBoss JIRA] (WELD-904) Observer method inheritance broken
[
https://issues.jboss.org/browse/WELD-904?page=com.atlassian.jira.plugin.s...
]
Ales Justin resolved WELD-904.
------------------------------
Resolution: Done
Observer method inheritance broken
----------------------------------
Key: WELD-904
URL: https://issues.jboss.org/browse/WELD-904
Project: Weld
Issue Type: Bug
Components: Events
Affects Versions: 1.1.1.Final
Reporter: Christian Bauer
Assignee: Ales Justin
Priority: Minor
Fix For: 1.1.4.Final
{code}
/*
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/beans_1_0.xsd">
<alternatives>
<class>Foo$Bar</class>
</alternatives>
</beans>
*/
@ApplicationScoped
public class Foo {
public static void main(String[] args) {
WeldContainer weld = new Weld().initialize();
weld.event().select(MyEvent.class).fire(new MyEvent());
}
static class MyEvent {
}
@Qualifier
@Target({FIELD, PARAMETER})
@Retention(RUNTIME)
public @interface SomeQualifier {
}
@PostConstruct
void init() {
System.out.println("INIT FOO");
}
void onEvent(@Observes MyEvent e) {
System.out.println("EVENT FOO");
}
@Alternative
@Specializes
static public class Bar extends Foo {
@Override
void init() {
System.out.println("INIT BAR");
}
@Override
void onEvent(@Observes @SomeQualifier MyEvent e) {
System.out.println("EVENT BAR");
}
}
}
{code}
The expected output is:
INIT BAR
The actual output is:
INIT BAR
EVENT BAR
Removing the @SomeQualifier annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
EVENT BAR
Removing also the @Observes annotation on the Bar#onEvent() method results in:
INIT BAR
EVENT BAR
One or several of these outcomes is wrong. Also, section 4.2 of the spec says that
observer methods are only inherited if the subclass doesn't override the method.
I'm confused why everyone (e.g. https://issues.jboss.org/browse/CDITCK-186) seems to
assume the exact opposite.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4544
days inactive
4733
days old
9 comments
6 participants
participants (6)
-
Ales Justin (Commented) (JIRA) -
Ales Justin (Resolved) (JIRA)
-
Ales Justin (Updated) (JIRA)
-
Christian Bauer (JIRA)
-
Pete Muir (Commented) (JIRA)
-
Pete Muir (JIRA)