[JBoss JIRA] Created: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
11:25 a.m.
Remove custom equality for AnnotatedType and rely on cache/object equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR1
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:25 a.m.
New subject: [JBoss JIRA] Updated: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Pete Muir updated WELD-409:
---------------------------
Fix Version/s: 1.0.1.CR2
(was: 1.0.1.CR1)
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:26 p.m.
New subject: [JBoss JIRA] Commented: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Stuart Douglas commented on WELD-409:
-------------------------------------
Removing the equals and hashCode errors results in the following failures:
testConstructorInjectionPoint(org.jboss.weld.tests.builtinBeans.BuiltInBeanPassivationCapableTest)
testFieldInjectionPoint(org.jboss.weld.tests.builtinBeans.BuiltInBeanPassivationCapableTest)
testMethodInjectionPoint(org.jboss.weld.tests.builtinBeans.BuiltInBeanPassivationCapableTest)
testNewBeanHasSameConstructorAsWrappedBean(org.jboss.weld.tests.managed.newBean.NewSimpleBeanTest)
All of these seem to be related to the fact that .equals for InjectionPoint was delegating
to .equals for WeldAnnotated
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:46 p.m.
New subject: [JBoss JIRA] Updated: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Stuart Douglas updated WELD-409:
--------------------------------
Attachment: remove-equality-1.diff
Here is a patch, the changes to BeanDeployerEnvironment are a bit of a hack, as we cannot
rely on object equality all the time sometimes a brute force search of the map is
required.
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] Commented: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-409:
--------------------------------
Why not alter producerMethodBeanMap itself, so that it's key is unique? Then you can
construct the key inside getProducerMethod, and keep the speed of this being a hashmap
lookup. With this change, please apply.
Otherwise, good work, and I am very glad to see that this assumption didn't pervade
too deep :-)
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [JBoss JIRA] Updated: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Stuart Douglas updated WELD-409:
--------------------------------
Attachment: remove-equality-2.diff
Here is a fixed version, should this go in for 1.0.1.CR2?
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff, remove-equality-2.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:02 a.m.
New subject: [JBoss JIRA] Commented: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-409:
--------------------------------
Yes please.
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff, remove-equality-2.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 a.m.
New subject: [JBoss JIRA] Resolved: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Stuart Douglas resolved WELD-409.
---------------------------------
Resolution: Done
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff, remove-equality-2.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
New subject: [JBoss JIRA] Closed: (WELD-409) Remove custom equality for AnnotatedType and rely on cache/object equality
[
https://jira.jboss.org/jira/browse/WELD-409?page=com.atlassian.jira.plugi...
]
Pete Muir closed WELD-409.
--------------------------
Remove custom equality for AnnotatedType and rely on cache/object
equality
--------------------------------------------------------------------------
Key: WELD-409
URL: https://jira.jboss.org/jira/browse/WELD-409
Project: Weld
Issue Type: Bug
Components: Reflection layer
Reporter: Pete Muir
Assignee: Stuart Douglas
Fix For: 1.0.1.CR2
Attachments: remove-equality-1.diff, remove-equality-2.diff
Currently we use the underlying class to perform equality, this is wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5207
days inactive
5226
days old
8 comments
2 participants
participants (2)
-
Pete Muir (JIRA) -
Stuart Douglas (JIRA)