[ https://jira.jboss.org/jira/browse/WELDSE-25?page=com.atlassian.jira.plug... ] Pete Muir commented on WELDSE-25: --------------------------------- Yes, this was the exact intent of providing a pluggable ResourceLoader. Can you describe how you are trying to specify the service? Pete R, we should reuse the ResourceLoader stuff when doing reflections in Weld SE. Morten, can you describe why you want to pass a CL to the Weld class? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELDSE-25?page=com.atlassian.jira.plug... ] Morten Christensen commented on WELDSE-25: ------------------------------------------ As for how I tried to use ResourceLoader, I added the class below to my app + make the appropriate file under META-INF/services + called setClassLoader with the above class loader from the OSGI activator (notice the use of a static variable which I don't like). In addition, when Weld SE ignored my class, I did a manual test in my Activator as follows and it would my service - so my service was installed: java.util.ServiceLoader<org.jboss.weld.resources.spi.ResourceLoader> osgiServiceLoader = java.util.ServiceLoader.load(org.jboss.weld.resources.spi.ResourceLoader.class); Iterator<org.jboss.weld.resources.spi.ResourceLoader> iter = osgiServiceLoader.iterator(); while (iter.hasNext()) System.out.println("Found ResourceLoader: "+iter.next()); My OSGI ResourceLoader loader below. Please be free to use this code for whatever purpose you want. public class OsgiLoader implements ResourceLoader { private static ClassLoader classLoader; public static void setClassLoader(ClassLoader classLoader) { OsgiLoader.classLoader=classLoader; } public static void removeClassLoader() { OsgiLoader.classLoader=null; } public OsgiLoader() { System.err.println("OsgiLoader CTR called"); } @Override public Class<?> classForName(String name) { System.err.println("OsgiLoader.classForName called"); try { return classLoader.loadClass(name); } catch (ClassNotFoundException e) { throw new ResourceLoadingException(e); } catch (NoClassDefFoundError e) { throw new ResourceLoadingException(e); } } @Override public URL getResource(String name) { System.err.println("OsgiLoader.getResource called"); return classLoader.getResource(name); } @Override public Collection<URL> getResources(String name) { System.err.println("OsgiLoader.getResources called"); try { return toCollection(classLoader.getResources(name)); } catch (IOException e) { throw new ResourceLoadingException(e); } } @Override public void cleanup() { classLoader=null; } private static Collection<URL> toCollection(Enumeration<URL> urls) { ArrayList<URL> urlCollection = new ArrayList<URL>(); while (urls.hasMoreElements()) urlCollection.add(urls.nextElement()); return urlCollection; } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELDSE-25?page=com.atlassian.jira.plug... ] Pete Muir updated WELDSE-25: ---------------------------- Summary: Weld class should be easier to extend to introduce custom behavior, for example the ability to replace the ResourceLoader (was: Weld SE ignores org.jboss.weld.resources.spi.ResourceLoader) Issue Type: Feature Request (was: Bug) Priority: Major (was: Critical) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELDSE-25?page=com.atlassian.jira.plug... ] Morten Christensen commented on WELDSE-25: ------------------------------------------ Thanks for the feedback. I did get the impression from the Weld docs + javadocs that it was a Java 6 style service, but now I know better and I can see how to avoid the statics and you say. Actually, it is not only about replacing Weld but also the class org.jboss.weld.environment.se.util.Reflections and other classes + there are other bugs that I will then run into. I send you a personal email today about what can be done - did you see it ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELDSE-25?page=com.atlassian.jira.plug... ] Peter Royle commented on WELDSE-25: ----------------------------------- Weld now contains a method configureDeployment() which is called before Weld is booted up. Developers can subclass Weld and override this method to configure the deployment programatically. Eg: public class MyWeld extends Weld { ... @Override protected void configureDeployment(Deployment deployment) { deployment.getServices().add(ResourceLoader.class, new OSGIResourceLoader(myClassloader)); } } I've also updated URLScanner to use either the configured ResourceLoader (if any) or an instance of DefaultResourceLoader. Morten, if you have already improved on this level of customisation I'll be happy to incorporate any patches you have. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELDSE-25?page=com.atlassian.jira.plugin.sy... ] Pete Muir updated WELDSE-25: ---------------------------- Component/s: Java SE Support -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-597?page=com.atlassian.jira.plugin.sys... ] Pete Muir closed WELD-597. -------------------------- Fix Version/s: 1.1.0.Beta1 (was: 1.1.0.Beta2) Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira