4:44 p.m.
double slash in Converstaion test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:46 p.m.
New subject: [JBoss JIRA] Updated: (CDITCK-191) double slash in Converstaion test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
David Jencks updated CDITCK-191:
--------------------------------
Attachment: CDITCK-191.diff
patch that removes initial / from all calls to getPath including the one where the test
breaks.
double slash in Converstaion test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:50 p.m.
New subject: [JBoss JIRA] Updated: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
David Jencks updated CDITCK-191:
--------------------------------
Summary: double slash in Conversation test urls break redirect (was: double slash in
Converstaion test urls break redirect)
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:27 a.m.
New subject: [JBoss JIRA] Updated: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
Pete Muir updated CDITCK-191:
-----------------------------
Fix Version/s: 1.0.3.CR4
We will apply your patch. Could you sign a JBoss Contributor Agreement for Weld at
http://cla.jboss.org ?
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Fix For: 1.0.3.CR4
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 p.m.
New subject: [JBoss JIRA] Commented: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
David Jencks commented on CDITCK-191:
-------------------------------------
I think it's unlikely I'll get approval from my employer to sign a CLA in a
reasonable amount of time. I apologize for supplying the patch without realizing a CLA
was needed. While I have a hard time imagining anyone could find copyrightable content in
the patch, is there any chance someone can re-fix the problem without reference to the
patch?
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Fix For: 1.0.3.CR4
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 a.m.
New subject: [JBoss JIRA] Commented: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
Pete Muir commented on CDITCK-191:
----------------------------------
If you can explicitly license the patch under the ASL 2.0 then that is also ok?
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Fix For: 1.0.3.CR4
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:24 p.m.
New subject: [JBoss JIRA] Commented: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://jira.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin.s...
]
David Jencks commented on CDITCK-191:
-------------------------------------
We're working on the CCLA but I can explicitly license this particular patch under ASL
2.0 so I'm hereby doing so.
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://jira.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Fix For: 1.0.3.CR4
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:19 p.m.
New subject: [JBoss JIRA] Closed: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
Pete Muir closed CDITCK-191.
----------------------------
Assignee: Pete Muir
Fix Version/s: 1.1.0.CR1
Resolution: Done
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 p.m.
New subject: [JBoss JIRA] Reopened: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
David Jencks reopened CDITCK-191:
---------------------------------
AFAICT this is not yet excluded from 1.0.1-Final?
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:49 a.m.
New subject: [JBoss JIRA] Closed: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
Pete Muir closed CDITCK-191.
----------------------------
Resolution: Done
Hi David, unfortunately we don't have the resources to maintain multiple exclude
lists, and so only maintain exclude lists against the latest released (final) TCK. I just
cleared out the exclude list since we just releaed 1.0.2.Final (SP1 as well actually).
We are looking at ways of maintaining full exclude lists in the future.
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.1.0.CR1, 1.0.3.Final
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 a.m.
New subject: [JBoss JIRA] Commented: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
David Jencks commented on CDITCK-191:
-------------------------------------
Ok, but could you update
http://anonsvn.jboss.org/repos/weld/cdi-tck/branches/1.0/impl/src/main/re...
to indicate the actual latest release version it applies to? It says 1.0.1-Final at the
moment so that's what I've been using. Better still might be a url to the maven
repo folder that contains the latest release so you can't forget to update it again
:-) Assuming that this is actually the official exclusion list, a comment that says so
would be helpful to me also.
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 p.m.
New subject: [JBoss JIRA] Reopened: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
David Jencks reopened CDITCK-191:
---------------------------------
Rev 7124 added the testNonexistentConversationExceptionThrown method apparently ported
from trunk to the 1.0 branch, but did not include the rest of this test from CDITCK-114,
namely a filter and a change to web.xml. Rev. 7132 changed the test to apparently work
with weld without the missing parts of the test. Is adding this new method to the 1.0 tck
intentional or should it be excluded?
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:27 a.m.
New subject: [JBoss JIRA] Commented: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
Pete Muir commented on CDITCK-191:
----------------------------------
Ok, comments updated, thanks for the feedback! As you guessed, we run this very much as an
OSS project, and so appreciate the communities involvement!
I've removed that test in the branch, that was a mistake on my part! I will also fix
Gurkan's issue and do a new release later today.
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:29 a.m.
New subject: [JBoss JIRA] Closed: (CDITCK-191) double slash in Conversation test urls break redirect
[
https://issues.jboss.org/browse/CDITCK-191?page=com.atlassian.jira.plugin...
]
Pete Muir closed CDITCK-191.
----------------------------
Fix Version/s: 1.0.3.Final
Resolution: Done
double slash in Conversation test urls break redirect
-----------------------------------------------------
Key: CDITCK-191
URL: https://issues.jboss.org/browse/CDITCK-191
Project: CDI TCK
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Tests
Affects Versions: 1.0.2.CR3
Reporter: David Jencks
Assignee: Pete Muir
Fix For: 1.0.3.Final, 1.1.0.CR1, 1.0.2.Final
Attachments: CDITCK-191.diff
The Conversation tests all call AbstractConversationTest.getPath() with strings starting
with / such as /storm.jspx. Since the method tacks a / at the end of the context root you
end up with urls for the form foo//bar.jsf. While tomcat appears to think that this is
the same url as foo/bar.jsf, jetty doesn't. This breaks the redirect in
LongRunningConversationPropagatedByFacesContextTest.testConversationPropagatedOverRedirect.
Removing the / from the arguments to getPath fixes the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4907
days inactive
4946
days old
13 comments
2 participants
participants (2)
-
David Jencks (JIRA) -
Pete Muir (JIRA)