[JBoss JIRA] Created: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[JBoss JIRA] Created: (WELD-782)...

[JBoss JIRA] Updated: (WELD-53)...

George Gastaldi (JIRA)

Wednesday, 6 October 2010 Wed, 6 Oct '10

11:39 p.m.

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.1.0.Beta1, 1.0.1.Final Reporter: George Gastaldi Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. {code} Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational); {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

George Gastaldi (JIRA)

Wednesday, 6 October Wed, 6 Oct

11:39 p.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] George Gastaldi updated WELD-711: --------------------------------- Attachment: report.txt YourKit report attached. The object annotated is "UfAction". This report was generated after two sucessive creation and destroying of the instance.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. {code} Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational); {code}

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

George Gastaldi (JIRA)

11:41 p.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] George Gastaldi updated WELD-711: --------------------------------- Description: Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational); was: Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. {code} Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational); {code}

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

Pete Muir (JIRA)

Thursday, 7 October Thu, 7 Oct

2:03 a.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-711: --------------------------- Fix Version/s: 1.1.0.Beta2 Caused by the use of anonymous inner classes hence the class holds a reference to the outer class instance. Not sure why we are allowing this to be resolved, as it's not a valid bean type.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Fix For: 1.1.0.Beta2 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

Pete Muir (JIRA)

Friday, 15 October Fri, 15 Oct

5:57 a.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-711: --------------------------- Fix Version/s: 1.1.0.CR1 (was: 1.1.0.Beta2)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

George Gastaldi (JIRA)

Tuesday, 2 November Tue, 2 Nov

10:28 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

Pete Muir (JIRA)

Saturday, 13 November Sat, 13 Nov

5:45 a.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-711: --------------------------- Priority: Minor (was: Major)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Stuart Douglas (JIRA)

Monday, 15 November Mon, 15 Nov

2 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Stuart Douglas commented on WELD-711: ------------------------------------- This issue is due to the use of AnnotationLiterals as anonymous inner classes. The annotations are cached as part of welds resolution process, but because they are non static inner classes they hold a reference to the outer class, which will never get released.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

George Gastaldi (JIRA)

2:12 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Stuart Douglas (JIRA)

2:24 p.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Stuart Douglas updated WELD-711: -------------------------------- Workaround Description: Avoid the use of new AnnotationListeral<MyAnnotation>{} in your code. Instead make AnnotationLiterals either top level or static inner classes. Workaround: [Workaround Exists]

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Stuart Douglas (JIRA)

2:28 p.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Stuart Douglas updated WELD-711: -------------------------------- Workaround Description: Avoid the use of new AnnotationLiteral<MyAnnotation>{} in your code. Instead make AnnotationLiterals either top level or static inner classes. (was: Avoid the use of new AnnotationListeral<MyAnnotation>{} in your code. Instead make AnnotationLiterals either top level or static inner classes.)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

Tuesday, 16 November Tue, 16 Nov

10:06 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir commented on WELD-711: -------------------------------- Ok we'll just have to make this a FAQ.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

George Gastaldi (JIRA)

7:59 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

George Gastaldi (JIRA)

8:03 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] George Gastaldi commented on WELD-711: -------------------------------------- Itt would be better if it logged: "Using AnnotationLiterals as anonymous inner classes can lead to a memory leak. Avoid using this and make it top or static inner class"

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

Monday, 29 November Mon, 29 Nov

12:59 p.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir commented on WELD-711: -------------------------------- Actually, we could just not cache such resolutions...

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

Monday, 6 December Mon, 6 Dec

3:03 p.m.

New subject: [JBoss JIRA] Assigned: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir reassigned WELD-711: ------------------------------ Assignee: Martin Gencur Martin, could you pull from https://github.com/pmuir/weld-core/tree/WELD-711 and run the stress tests over this, verifying against current master's head? This is does impact on some perf critical areas so would be good to confirm I guarded against any perf degrade...

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

4:01 p.m.

New subject: [JBoss JIRA] Resolved: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir resolved WELD-711. ---------------------------- Resolution: Done

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

4:03 p.m.

New subject: [JBoss JIRA] Updated: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-711: --------------------------- Fix Version/s: 1.1.0.Beta3 (was: 1.1.0.CR1)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.Beta3 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Martin Gencur (JIRA)

Tuesday, 7 December Tue, 7 Dec

12:39 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Martin Gencur commented on WELD-711: ------------------------------------ Yes, I will check this ASAP. (I'm waiting for SmartFrog to be working in Hudson). Hope this could be done today or tomorrow.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.Beta3 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Martin Gencur (JIRA)

Thursday, 9 December Thu, 9 Dec

5:17 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://jira.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.sys... ] Martin Gencur commented on WELD-711: ------------------------------------ This commit (or series of commits) had crucial impact on performance, but the bad way. The stress test now reaches only 4500 sessions while before it reached 10900 sessions. I compared these two builds: 1) weld/master with head=7c9120c263 and 2) the WELD-711 branch from https://github.com/pmuir/weld-core with head=610e3d977b, both were tested with JSF 2.0. The resulting statistics are as follows: https://hudson.qa.jboss.com/hudson/view/Weld/job/perf-weld-numberguess-st... , https://hudson.qa.jboss.com/hudson/view/Weld/job/perf-weld-numberguess-st...

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://jira.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

6:06 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir commented on WELD-711: -------------------------------- Martin, can you do a jprofiler run for both of these states so we can compare snapshots. I've also rebased the WELD-711 branch in my fork onto master, so would be worth running stress test again to make sure we are just seeing the impact of the one commit.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

6:08 a.m.

New subject: [JBoss JIRA] Reopened: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir reopened WELD-711: ---------------------------- Reopen as my solution is clearly not viable in production. We may want to consider introducing a development mode for things like this.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Martin Gencur (JIRA)

6:27 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Martin Gencur commented on WELD-711: ------------------------------------ Pete, I think the most effective way is to do a stress test for both of the new states which are there now, it means weld/master: head=f8b0445fd and you branch: head=c3ee8a971 and if the difference is in the one commit - make jprofiler snapshots for both of these states . Otherwise (since you've changed your branch) I would have to create my fork of your branch and get it into the previous state which was tested. Agreed? I have to do it sequentially.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Martin Gencur (JIRA)

7:39 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Martin Gencur commented on WELD-711: ------------------------------------ I just found out that the commit slowed it down but not that much as I wrote. The previous commits between the 2 mentioned commits caused even bigger slowdown. I will try to find where the problem is (in which commit).

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

7:41 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir commented on WELD-711: -------------------------------- Ok, that all sounds good.

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Martin Gencur (JIRA)

Friday, 10 December Fri, 10 Dec

5:17 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Martin Gencur commented on WELD-711: ------------------------------------ After recent tests I made I have to say that this fix (WELD-711) doesn't affect performance (or at least I couldn't have found any differences). On the other hand I found out that commit=362b515c93 (Minor refactor and fix test to be more robust ) caused all the performance decline. I ran stress test on weld/master with head=d40606dab and it was just good: https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-stress-singl..., then I ran the test with head=362b515c and the performance really went down: https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-stress-singl.... (nevertheless, I'd had to run a few more tests before I found out where the bottleneck was). As the last thing I tried to run your branch, Pete, removing the 362b515c and also WELD-549 (because removing just the former one resulted in some conflicts) and the results are very good: https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-stress-singl...

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Martin Gencur Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

5:58 a.m.

New subject: [JBoss JIRA] Assigned: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir reassigned WELD-711: ------------------------------ Assignee: Pete Muir (was: Martin Gencur)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Pete Muir Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

6 a.m.

New subject: [JBoss JIRA] Commented: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir commented on WELD-711: -------------------------------- Ok, I will merge this commit to trunk. Martin please open a new issue for the commit that caused the regression :-)

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Pete Muir Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

Pete Muir (JIRA)

Saturday, 11 December Sat, 11 Dec

7:17 a.m.

New subject: [JBoss JIRA] Closed: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager

[ https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.s... ] Pete Muir closed WELD-711. -------------------------- Resolution: Done Merged to trunk

...

Calling Contextual.destroy on an instance still references an instance on BeanManager ------------------------------------------------------------------------------------- Key: WELD-711 URL: https://issues.jboss.org/browse/WELD-711 Project: Weld Issue Type: Bug Components: Scopes & Contexts Affects Versions: 1.0.1.Final, 1.1.0.Beta1 Reporter: George Gastaldi Assignee: Pete Muir Priority: Minor Labels: AnnotationLiteral, MemoryLeak Fix For: 1.1.0.CR1 Attachments: report.txt Using the seam-faces module @ViewScoped extension, when the object is destroyed by Contextual.destroy, weld still references an instance, avoiding being garbage-collected. Pseudo Code: Contextual contextual = ... Object instance = ... CreationalContext creational = ... contextual.destroy(instance, creational);

-- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

4901

days inactive

4966

days old

weld-issues@lists.jboss.org

Manage subscription

28 comments

4 participants

tags (0)

participants (4)

George Gastaldi (JIRA)
Martin Gencur (JIRA)
Pete Muir (JIRA)
Stuart Douglas (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

[JBoss JIRA] Created: (WELD-711) Calling Contextual.destroy on an instance still references an instance on BeanManager