[ https://jira.jboss.org/jira/browse/WELD-510?page=com.atlassian.jira.plugi... ] Nicklas Karlsson commented on WELD-510: --------------------------------------- I think the entire JSFHelper is "considered harmful". Where we have JSF we also have Servlet so I think we should go in the direction of seam-servlet listeners + ServletContext storage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELD-510?page=com.atlassian.jira.plugi... ] Nicklas Karlsson commented on WELD-510: --------------------------------------- I'm not that into portlets - is it so that the external context instance is a PortalContext instead of ServletContext in this case? And there is the javax.servlet.ServletContextListener for Servlets, is there a way to pick up the PortalContext (or whatever it is) before the first request comes in? Or is it just undefined then and should be picked up from the request/session? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-510: --------------------------- Fix Version/s: 1.1.0.BETA2 (was: 1.1.0.BETA1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.sys... ] Pete Muir updated WELD-510: --------------------------- Fix Version/s: 1.1.0.CR1 (was: 1.1.0.Beta2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Pete Muir updated WELD-510: --------------------------- Fix Version/s: 1.2.0.Beta1 (was: 1.1.0.CR1) Slipping, need help from GateIn team developing reproduction and testing env -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Kito Mann commented on WELD-510: -------------------------------- Is there any activity on this issue? How did the GateIn folks solve this with the JBoss Portlet Bridge? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Ales Justin reassigned WELD-510: -------------------------------- Assignee: Marko Strukelj -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Brian Leathem commented on WELD-510: ------------------------------------ It's a shame that what seems like a relatively simple fix is being held up by waiting for the testing infrastructure in place. This issue is becoming more of a concern as one of the considerations on the table for JSR-344 is to consider using CDI as the managed bean facility for JSF. Until CDI/Weld can run everywhere where JSF currently runs (in this case portlets), then the existing JSF bean management facility is (@ManagedBean/@ManagedProperty) required. Can we move forward with a fix, and come back to this issue when the testing infrastructure is ready to support it? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Marko Strukelj commented on WELD-510: ------------------------------------- I think we can move forward. While the idea was to set up testing infrastructure first, the real challenge was reproducing the issue in the first place, so it got stuck on hold a bit. But I managed to reproduce it. The exception in the description is only the first issue - it looks like Weld-1.1.2.AS7 does not suffer from it any more. The real issue is that Weld at the moment can't handle cross-context includes, and the reason is that cross-context includes don't trigger request initialization events - meaning RequestContexts don't get activated. One solution for that would be to install an optional filter that gets triggered on INCLUDE only, and also check that current request context is not yet activated (to avoid double init on in-context includes). Ideally the solution would not require additional web.xml configuration ... -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Neil Griffin commented on WELD-510: ----------------------------------- Is the problem that the Weld JAR is in the global classloader of the app server? Is that what causes the cross-context problem? Perhaps you could elaborate. Thanks. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Ales Justin updated WELD-510: ----------------------------- Fix Version/s: 1.2.0.Beta1 (was: 1.1.2.Final) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Sverker Abrahamsson commented on WELD-510: ------------------------------------------ I've done some tests on the combination JBoss AS 7.0.2, Weld 1.1.2.Final, JBoss Portlet Bridge 3.0 Beta1, Liferay trunk (which will be the 6.1 release). I've configured my test package so that I can access it as a web application (which works fine) as well as a portlet. When accessing it as a portlet I get the following stacktrace which seems like the cross-context problem described above (since the stacktraces are very long I only include down to the GenericPortlet): 21:40:09,507 ALLVARLIG [org.jboss.portletbridge.faces] (http--127.0.0.1-8080-3) Error to execute beforePhase RESTORE_VIEW 1 method for listener: java.lang.IllegalStateException: Must call associate() before calling activate() at org.jboss.weld.context.AbstractConversationContext.activate(AbstractConversationContext.java:277) [weld-core-1.1.2.Final.jar:2011-07-26 15:02] at org.jboss.weld.jsf.WeldPhaseListener.activateConversations(WeldPhaseListener.java:114) [weld-core-1.1.2.Final.jar:2011-07-26 15:02] at org.jboss.weld.jsf.WeldPhaseListener.beforePhase(WeldPhaseListener.java:88) [weld-core-1.1.2.Final.jar:2011-07-26 15:02] at org.jboss.portletbridge.lifecycle.LifecyclePhase.execute(LifecyclePhase.java:67) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.lifecycle.RestoreViewPhase.execute(RestoreViewPhase.java:81) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.lifecycle.PortletLifecycle.execute(PortletLifecycle.java:143) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.AjaxPortletBridge.execute(AjaxPortletBridge.java:1186) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.AjaxPortletBridge.doFacesRequest(AjaxPortletBridge.java:656) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.faces.GenericFacesPortlet.doFacesDispatch(GenericFacesPortlet.java:567) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.faces.GenericFacesPortlet.doView(GenericFacesPortlet.java:475) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:328) [portlet.jar:private-2011/04/13-23:33:42] at javax.portlet.faces.GenericFacesPortlet.doDispatch(GenericFacesPortlet.java:446) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.GenericPortlet.render(GenericPortlet.java:233) [portlet.jar:private-2011/04/13-23:33:42] --- cut ---- 21:40:10,304 ALLVARLIG [javax.enterprise.resource.webcontainer.jsf.application] (http--127.0.0.1-8080-3) Error Rendering View[/index.xhtml]: java.lang.IllegalStateException: A request must be associated with the context in order to load the known conversations at org.jboss.weld.context.AbstractConversationContext.getCurrentConversation(AbstractConversationContext.java:416) [weld-core-1.1.2.Final.jar:2011-07-26 15:02] at org.jboss.weld.jsf.ConversationAwareViewHandler.getActionURL(ConversationAwareViewHandler.java:110) [weld-core-1.1.2.Final.jar:2011-07-26 15:02] at javax.faces.application.ViewHandlerWrapper.getActionURL(ViewHandlerWrapper.java:185) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at org.jboss.portletbridge.application.PortletViewHandler.getActionURL(PortletViewHandler.java:164) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at com.sun.faces.renderkit.html_basic.FormRenderer.getActionStr(FormRenderer.java:232) [jsf-impl-2.1.3-b02-jbossorg-2.jar:2.1.3-SNAPSHOT] at com.sun.faces.renderkit.html_basic.FormRenderer.encodeBegin(FormRenderer.java:135) [jsf-impl-2.1.3-b02-jbossorg-2.jar:2.1.3-SNAPSHOT] at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:820) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1754) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1759) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1759) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:401) [jsf-impl-2.1.3-b02-jbossorg-2.jar:2.1.3-SNAPSHOT] at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:131) [jsf-impl-2.1.3-b02-jbossorg-2.jar:2.1.3-SNAPSHOT] at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:288) [jboss-jsf-api_2.1_spec-2.0.0.Beta1.jar:2.0.0.Beta1] at org.jboss.portletbridge.application.PortletViewHandler.renderView(PortletViewHandler.java:208) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.lifecycle.RenderResponsePhase.executePhase(RenderResponsePhase.java:104) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.lifecycle.LifecyclePhase.execute(LifecyclePhase.java:74) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.lifecycle.PortletLifecycle.render(PortletLifecycle.java:188) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.AjaxPortletBridge.render(AjaxPortletBridge.java:1190) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at org.jboss.portletbridge.AjaxPortletBridge.doFacesRequest(AjaxPortletBridge.java:661) [portletbridge-impl-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.faces.GenericFacesPortlet.doFacesDispatch(GenericFacesPortlet.java:567) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.faces.GenericFacesPortlet.doView(GenericFacesPortlet.java:475) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:328) [portlet.jar:private-2011/04/13-23:33:42] at javax.portlet.faces.GenericFacesPortlet.doDispatch(GenericFacesPortlet.java:446) [portletbridge-api-3.0.0.lime-SNAPSHOT.jar:] at javax.portlet.GenericPortlet.render(GenericPortlet.java:233) [portlet.jar:private-2011/04/13-23:33:42]´ --- cut ---- What is needed to solve the cross-context issue? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Sverker Abrahamsson commented on WELD-510: ------------------------------------------ Thanks Marko, it worked fine with my simple test portlet. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Adam Michalik commented on WELD-510: ------------------------------------ Seems like the filter did not quite solve the problem. With Weld 1.1.7.Final I'm getting javax.portlet.PortletException: doBridgeDispatch failed: error from Bridge in executing the request at javax.portlet.faces.GenericFacesPortlet.doBridgeDispatch(GenericFacesPortlet.java:675) at javax.portlet.faces.GenericFacesPortlet.doRenderDispatchInternal(GenericFacesPortlet.java:638) at javax.portlet.faces.GenericFacesPortlet.doView(GenericFacesPortlet.java:274) at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:328) at javax.portlet.faces.GenericFacesPortlet.doDispatch(GenericFacesPortlet.java:245) at javax.portlet.GenericPortlet.render(GenericPortlet.java:233) at com.liferay.portlet.FilterChainImpl.doFilter(FilterChainImpl.java:100) at com.liferay.portal.kernel.portlet.PortletFilterUtil.doFilter(PortletFilterUtil.java:64) at com.liferay.portal.kernel.servlet.PortletServlet.service(PortletServlet.java:93) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at com.liferay.portal.kernel.servlet.filters.invoker.InvokerFilterChain.doFilter(InvokerFilterChain.java:72) at org.jboss.weld.servlet.WeldCrossContextFilter.doFilter(WeldCrossContextFilter.java:62) --- snip --- Caused by: javax.portlet.faces.BridgeException: java.lang.IllegalStateException: Not in a servlet environment! at com.liferay.faces.bridge.BridgePhaseRenderImpl.execute(BridgePhaseRenderImpl.java:89) at com.liferay.faces.bridge.BridgeImpl.doFacesRequest(BridgeImpl.java:85) at javax.portlet.faces.GenericFacesPortlet.doBridgeDispatch(GenericFacesPortlet.java:672) ... 118 more Caused by: java.lang.IllegalStateException: Not in a servlet environment! at org.jboss.weld.environment.servlet.jsf.WeldApplication.beanManager(WeldApplication.java:103) at org.jboss.weld.environment.servlet.jsf.WeldApplication.init(WeldApplication.java:77) at org.jboss.weld.environment.servlet.jsf.WeldApplication.delegate(WeldApplication.java:85) at org.jboss.weld.environment.servlet.jsf.ForwardingApplication.getViewHandler(ForwardingApplication.java:277) at com.sun.faces.context.FacesContextImpl.isPostback(FacesContextImpl.java:210) at com.liferay.faces.bridge.BridgePhaseRenderImpl.execute(BridgePhaseRenderImpl.java:184) at com.liferay.faces.bridge.BridgePhaseRenderImpl.execute(BridgePhaseRenderImpl.java:83) ... 120 more It seems that it's not only my problem: https://community.jboss.org/thread/197833 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Adam Michalik updated WELD-510: ------------------------------- Attachment: weld-510.zip Steps to reproduce: 1) Download Liferay Portal Community Edition 6.1.0 CE budled with Tomcat from http://www.liferay.com/downloads/liferay-portal/available-releases 2) Unpack to - let's call it - ${LIFERAY_HOME} 3) Start Liferay with {LIFERAY_HOME}/tomcat-xxx/bin/startup.sh 4) Go to http://localhost:8080 to finish setup 5) Unzip the attached project, run mvn package 6) Copy the war file to ${LIFERAY_HOME}/deploy 7)Log in as the admin user and add the weld-510 portlet 8) Observe stacktrace in Liferay's logs ({LIFERAY_HOME}/tomcat-xxx/logs/catalina.out) The portlet works fine without Weld: 1) In web.xml disable the WeldCrossContextFilter filter and filter-mapping 2) In HelloWorld class toggle from @Model to @ManagedBean 3) run mvn package -P!weld 4) deploy to Liferay 5) The portlet appears fine -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Marko Strukelj commented on WELD-510: ------------------------------------- You can give weld-core master a try: https://github.com/weld/core/commit/930fba79d08f41310f31dea3fbae50cc5347c... In your project adjust weld-servlet version: <version.weld-servlet>1.2.0-SNAPSHOT</version.weld-servlet> And make sure to uncomment the 'UNCOMMENT IN SERVLET ENVIRONMENT' and 'ENABLE WELD IN SERVLET ENVIRONMENT' sections of web.xml, which are commented out in weld-510.zip. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] G B commented on WELD-510: -------------------------- Is it correct, that I have to configure the org.jboss.weld.environment.servlet.Listener in the web.xml in a portlet environment? If the listener is not configured I get following exception: java.lang.IllegalStateException: Singleton is not set at org.jboss.weld.bootstrap.api.helpers.IsolatedStaticSingletonProvider$IsolatedStaticSingleton.get(IsolatedStaticSingletonProvider.java:52) at org.jboss.weld.Container.instance(Container.java:54) at org.jboss.weld.jsf.WeldPhaseListener.instance(WeldPhaseListener.java:161) at org.jboss.weld.jsf.WeldPhaseListener.activateConversations(WeldPhaseListener.java:98) at org.jboss.weld.jsf.WeldPhaseListener.beforePhase(WeldPhaseListener.java:85) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/WELD-510?page=com.atlassian.jira.plugin.s... ] Neil Griffin updated WELD-510: ------------------------------ Description: There are some folks trying to use the PortletFaces Bridge for JSF 2.0 + Portlet 2.0 in Glassfish V3, but Weld is causing an issue. Original Post: http://www.liferay.com/community/forums/-/message_boards/view_message/132... Here is a simple stacktrace of the problem: Caused by: java.lang.IllegalStateException: Weld doesn not support using JSF in an non-servlet environment at org.jboss.weld.jsf.JsfHelper.getModuleBeanManager(JsfHelper.java:119) at org.jboss.weld.jsf.WeldPhaseListener.initiateSessionAndConversation(WeldPhaseListener was: There are some folks trying to use the PortletFaces Bridge for JSF 2.0 + Portlet 2.0 in Glassfish V3, but Weld is causing an issue. Original Post: http://www.portletfaces.org/community/forums/-/message_boards/message/430... Here is a simple stacktrace of the problem: Caused by: java.lang.IllegalStateException: Weld doesn not support using JSF in an non-servlet environment at org.jboss.weld.jsf.JsfHelper.getModuleBeanManager(JsfHelper.java:119) at org.jboss.weld.jsf.WeldPhaseListener.initiateSessionAndConversation(WeldPhaseListener The code for the bridge API is here: http://svn.portletfaces.org/svn/portletfaces/bridge/org.portletfaces.brid... The code for the bridge IMPL is here: http://svn.portletfaces.org/svn/portletfaces/bridge/org.portletfaces.brid... And the code for a sample portlet is here: http://svn.portletfaces.org/svn/portletfaces/portlets/sample/jsf-2.0-job-... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira