[ https://jira.jboss.org/jira/browse/WELD-265?page=com.atlassian.jira.plugi... ] Pete Muir commented on WELD-265: -------------------------------- Basically, we just need to copy the logic from Validator, but I am wondering if there is a decent way to share the logic, given one path must throw exceptions, the other return a boolean. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/WELD-265?page=com.atlassian.jira.plugi... ] Marius Bogoevici commented on WELD-265: --------------------------------------- I tried to add it, but I got a passivation test failing: org.jboss.jsr299.tck.tests.context.passivating.broken.interceptorWithNonPassivatingInjectedField And that is because the Bean is not passivating anymore. Somehow, checkType did not validate passivability correctly (just checks that the class is serializable, which is wrong), I made the changes on AbstractClassBean and ManagedBean to push the checks late in the process. One outcome of this change is that PassivationCapableBeanWithNonPassivatingInterceptorTest is broken now, as the type check on the bean throws a DefinitionError. We need to couple this with WELD-272 and WELD-274 and make sure that validation (and DeploymentExceptions) take place in the validator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira