Plugging in Credential Store backed ExpressionResolver
by Darran Lofthouse
Presently working on WFCORE-4360 adding support for expression resolution
backed by a credential store - the main barrier is going to be the solution
to bridge expression resolution with a subsystem provided component.
I am wondering if the following is going to be viable to support a
configurable expression resolver from a subsystem.
I see the RuntimeExpressionResolver is created very early in the boot
process, however at the time it is created the CapabilityRegistry is also
available. This is making me think if the CapabilityRegistry can be passed
in to the RuntimeExpressionResolver.
I would then imagine the resource handling expression resolution would
register a non-dynamic capability which exposes an expression resolver
runtime API. This in turn may also need to cross reference a credential
store which would also need to be accessible using the runtime API of a
capability.
At the time of expression resolution the RuntimeExpressionResolver would
then check the CapabilityRegistry to see if an expression resolver has been
registered and attempt to use it falling back to vault then default
ModelNode resolution if it does not resolve the expression.
Using a runtime API I suspect I would likely need to trigger the
initialisation of these APIs at the start of Stage.RUNTIME - that looks
feasible by adding a stage to Stage.RUNTIME with addFirst test to true -
maybe to be safe these should also start on demand based on first access.
Regards,
Darran Lofthouse.
3 years, 9 months
Help with PRs
by Brian Stansberry
Hi everyone,
WildFly and WildFly Core get a lot of PRs, and some take quite a bit of
time to get reviewed, tested and merged. I know that can be frustrating
sometimes. Here's some info that hopefully can help.
First, if you send up a PR it's good if you know what WFLY / WFCORE
component is affected. Then you can use a PR comment @ ping the component
lead for that component for a review. The component leads should be the
default choice for getting reviews. You can find out the component leads
from JIRA:
https://issues.redhat.com/projects/WFLY?selectedItem=com.atlassian.jira.j...
https://issues.redhat.com/projects/WFCORE?selectedItem=com.atlassian.jira...
Second, there's a "Pull requests" stream in Zulip where you can start
threads to discuss a particular PR, particularly if you don't think the
discussion would be of wider interest. Wider interest items are better
discussed in the main "widlfly-developers" stream.
https://wildfly.zulipchat.com/#narrow/stream/274477-Pull-requests
Please note that we have a PR integration that will comment if a PR has no
activity for 30 days and then close the PR if there is no activity for 90.
This is to help keep the queue manageable. Such PRs can always be reopened.
Best regards,
Brian
3 years, 9 months
