Re: [wildfly-dev] Changes to the PicketLink Module

On 07/24/2013 06:23 PM, Fernando Ribeiro wrote: > I guess that is the AbstractJPARegistry class referred to in my previous > message, right? > Thanks, answering my current questions in the past is awesome! I don't see anything references that should need Hibernate or Javassist in AbstractJPARegistry. Could you try removing the PicketLink module dependency on the Hibernate and Javassist modules and show me the full exception call stack that you get as a result of doing that? > On Jul 24, 2013 6:42 PM, "Scott Marlow" <smarlow(a)redhat.com > <mailto:smarlow@redhat.com>> wrote: > > Can you give me a link to the PicketLink code that does the > bootstrap? I'd like to see why you need to reference Hibernate > directly. > > As long as the JPA subsystem JPAExtension.initialize() has run, the > default persistence provider (Hibernate) will be available to > javax.persistence.Persistence.**__createEntityManagerFactory()**. > > > On 07/24/2013 03:39 PM, Fernando Ribeiro wrote: > > Scott, > > PicketLink doesn't use any Hibernate extensions, and users are > expected > to provide a persistence unit called "picketlink-sts" in their > applications. > > Regarding the bootstraping of the persistence unit, you guessed > right [1]. > > Regards, > > -- > Fernando > > [1] > https://github.com/picketlink/**__picketlink/blob/__** > 277c5b8ec9b6eee5dcd36422763db6**__f02479f081/modules/** > federation/__src/main/java/**org/picketlink/__identity/** > federation/core/sts/__**registry/AbstractJPARegistry._**_java<https://... > > <https://github.com/**picketlink/picketlink/blob/** > 277c5b8ec9b6eee5dcd36422763db6**f02479f081/modules/federation/** > src/main/java/org/picketlink/**identity/federation/core/sts/** > registry/AbstractJPARegistry.**java<https://github.com/picketlink/pick... > > > > > r > > > > On Wed, Jul 24, 2013 at 4:17 PM, Scott Marlow > <smarlow(a)redhat.com <mailto:smarlow@redhat.com> > <mailto:smarlow@redhat.com <mailto:smarlow@redhat.com>>> wrote: > > How does PickLink bootstrap the persistence unit mentioned > in [5] + > [6]? I assume not via EE JPA container managed deployment. > I'm > guessing via direct calls to > > javax.persistence.Persistence.**____** > createEntityManagerFactory("__**__picketlink-sts"). > > > Does PicketLink use any Hibernate extensions? Or just the > JPA api? > > Do we have a more complete example than [5]+[6], that > include how > users are expected to supply datasource/database > configuration. > > > > On 07/24/2013 02:34 PM, Fernando Ribeiro wrote: > > The issue is the PicketLink module depending on a > specific JPA > implementation, which is not really desirable, and > currently looks > unavoidable. Regards. > > > On Wed, Jul 24, 2013 at 11:55 AM, Jaikiran Pai > <jpai(a)redhat.com <mailto:jpai@redhat.com> > <mailto:jpai@redhat.com <mailto:jpai@redhat.com>> > <mailto:jpai@redhat.com <mailto:jpai@redhat.com> > <mailto:jpai@redhat.com <mailto:jpai@redhat.com>>>> wrote: > > Fernando actually proposed a fix which we wanted to > be > discussed here in > the mailing list since the fix didn't look right > for a core > component > like PicketLink. The PR (which we closed) is here > https://github.com/wildfly/___**_wildfly/issues/4786<https://github.co... > <https://github.com/wildfly/__**wildfly/issues/4786<https://github.com/... > > > > <https://github.com/wildfly/__**wildfly/issues/4786<https://github.com/... > <https://github.com/wildfly/**wildfly/issues/4786<https://github.com/wi... > >> > > -Jaikiran > On Wednesday 24 July 2013 08:22 PM, Darran > Lofthouse wrote: > > > > On 24/07/13 15:46, Fernando Ribeiro wrote: > >> All, > >> > >> There is an issue in PicketLink [1] that > requires the > module > descriptor > >> in WildFly to depend on "org.hibernate" and > "org.javassist" to > support > >> two components called "JPABasedTokenRegistry" > [2] and > >> "JPABasedRevocationRegistry" [3]. > >> > >> How would you suggest this issue to be fixed? > > If you already have the proposed fix I would > suggest > sending over > a pull > > request. > > > > > https://community.jboss.org/__**__wiki/HackingOnWildFly<https://commun... > <https://community.jboss.org/_**_wiki/HackingOnWildFly<https://communit... > > > > <https://community.jboss.org/_**_wiki/HackingOnWildFly<https://communit... > <https://community.jboss.org/**wiki/HackingOnWildFly<https://community.... > >> > > > > If you are an EAP customer I would suggest > opening a > support case so > > that the support team can request the fix is > included in > EAP. > > > >> The issue has also been logged in WildFly > already [4]. > There are > samples > >> of the JPA registries available in my blog > [5][6]. > >> > >> Regards, > >> > >> -- > >> Fernando > >> > >> [1] > https://issues.jboss.org/____**browse/PLINK2-97<https://issues.jboss.o... > <https://issues.jboss.org/__**browse/PLINK2-97<https://issues.jboss.org... > > > > <https://issues.jboss.org/__**browse/PLINK2-97<https://issues.jboss.org... > <https://issues.jboss.org/**browse/PLINK2-97<https://issues.jboss.org/b... > >> > >> [2] > >> > https://access.redhat.com/____**site/documentation/en-US/____** > JBoss_Enterprise_Application__**___Platform/6.1/html/API_____** > Documentation/files/javadoc/__**__org/picketlink/identity/____** > federation/core/sts/registry/_**___JPABasedTokenRegistry.html<https://... > <https://access.redhat.com/__**site/documentation/en-US/__** > JBoss_Enterprise_Application__**_Platform/6.1/html/API___** > Documentation/files/javadoc/__**org/picketlink/identity/__** > federation/core/sts/registry/_**_JPABasedTokenRegistry.html<https://ac... > > > > > <https://access.redhat.com/__**site/documentation/en-US/__** > JBoss_Enterprise_Application__**_Platform/6.1/html/API___** > Documentation/files/javadoc/__**org/picketlink/identity/__** > federation/core/sts/registry/_**_JPABasedTokenRegistry.html<https://ac... > <https://access.redhat.com/**site/documentation/en-US/** > JBoss_Enterprise_Application_**Platform/6.1/html/API_** > Documentation/files/javadoc/**org/picketlink/identity/** > federation/core/sts/registry/**JPABasedTokenRegistry.html<https://acce... > >> > >> [3] > >> > https://access.redhat.com/____**site/documentation/en-US/____** > JBoss_Enterprise_Application__**___Platform/6.1/html/API_____** > Documentation/files/javadoc/__**__org/picketlink/identity/____** > federation/core/sts/registry/_**___JPABasedRevocationRegistry.**____html&... > <https://access.redhat.com/__**site/documentation/en-US/__** > JBoss_Enterprise_Application__**_Platform/6.1/html/API___** > Documentation/files/javadoc/__**org/picketlink/identity/__** > federation/core/sts/registry/_**_JPABasedRevocationRegistry.__**html<h... > > > > > <https://access.redhat.com/__**site/documentation/en-US/__** > JBoss_Enterprise_Application__**_Platform/6.1/html/API___** > Documentation/files/javadoc/__**org/picketlink/identity/__** > federation/core/sts/registry/_**_JPABasedRevocationRegistry.__**html<h... > <https://access.redhat.com/**site/documentation/en-US/** > JBoss_Enterprise_Application_**Platform/6.1/html/API_** > Documentation/files/javadoc/**org/picketlink/identity/** > federation/core/sts/registry/**JPABasedRevocationRegistry.**html<https... > >> > >> [4] > https://issues.jboss.org/____**browse/WFLY-1691<https://issues.jboss.o... > <https://issues.jboss.org/__**browse/WFLY-1691<https://issues.jboss.org... > > > > <https://issues.jboss.org/__**browse/WFLY-1691<https://issues.jboss.org... > <https://issues.jboss.org/**browse/WFLY-1691<https://issues.jboss.org/b... > >> > >> [5] > >> > http://simplesassim.wordpress.**____com/2013/07/12/how-to-use-** > __the-__jpa-based-token-__**registry-in-__picketlink/ > > <http://simplesassim.__wordpre**ss.com/2013/07/12/how-__to-** > use-the-jpa-based-token-__**registry-in-picketlink/<http://wordpress.c... > <http://simplesassim.**wordpress.com/2013/07/12/how-** > to-use-the-jpa-based-token-**registry-in-picketlink/<http://simplesass... > >> > >> [6] > >> > http://simplesassim.wordpress.**____com/2013/07/21/how-to-use-** > __the-__jpa-based-revocation-_**_registry-__in-picketlink/ > > <http://simplesassim.__wordpre**ss.com/2013/07/21/how-__to-** > use-the-jpa-based-__**revocation-registry-in-__**picketlink/<http://wo... > <http://simplesassim.**wordpress.com/2013/07/21/how-** > to-use-the-jpa-based-**revocation-registry-in-**picketlink/<http://sim... > >> > >> > >> > >> > ______________________________**_____________________ > > >> wildfly-dev mailing list > >> wildfly-dev(a)lists.jboss.org > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > > > <mailto:wildfly-dev@lists.__jb**oss.org<http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >> > <mailto:wildfly-dev@lists. > <mailto:wildfly-dev@lists.>__j**b__oss.org <http://jb__oss.org> < > http://jboss.org> > <mailto:wildfly-dev@lists.__jb**oss.org<http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >>> > > >> > https://lists.jboss.org/____**mailman/listinfo/wildfly-dev<https://lis... > <https://lists.jboss.org/__**mailman/listinfo/wildfly-dev<https://lists... > > > <https://lists.jboss.org/__** > mailman/listinfo/wildfly-dev<https://lists.jboss.org/__mailman/listinf... > <https://lists.jboss.org/**mailman/listinfo/wildfly-dev<https://lists.j... > >> > >> > > ______________________________** > _____________________ > > > wildfly-dev mailing list > > wildfly-dev(a)lists.jboss.org > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > > > <mailto:wildfly-dev@lists.__jb**oss.org<http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >> > <mailto:wildfly-dev@lists. > <mailto:wildfly-dev@lists.>__j**b__oss.org <http://jb__oss.org> < > http://jboss.org> > <mailto:wildfly-dev@lists.__jb**oss.org<http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >>> > > > > https://lists.jboss.org/____**mailman/listinfo/wildfly-dev<https://lis... > <https://lists.jboss.org/__**mailman/listinfo/wildfly-dev<https://lists... > > > <https://lists.jboss.org/__** > mailman/listinfo/wildfly-dev<https://lists.jboss.org/__mailman/listinf... > <https://lists.jboss.org/**mailman/listinfo/wildfly-dev<https://lists.j... > >> > > ______________________________** > _____________________ > > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > > > <mailto:wildfly-dev@lists.__jb**oss.org <http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >> > <mailto:wildfly-dev@lists. > <mailto:wildfly-dev@lists.>__j**b__oss.org <http://jb__oss.org> < > http://jboss.org> > <mailto:wildfly-dev@lists.__jb**oss.org<http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >>> > > https://lists.jboss.org/____**mailman/listinfo/wildfly-dev<https://lis... > <https://lists.jboss.org/__**mailman/listinfo/wildfly-dev<https://lists... > > > > <https://lists.jboss.org/__** > mailman/listinfo/wildfly-dev<https://lists.jboss.org/__mailman/listinf... > <https://lists.jboss.org/**mailman/listinfo/wildfly-dev<https://lists.j... > >> > > > > > -- > Fernando Ribeiro > Upic > +55 11 9 8111 4078 <tel:%2B55%2011%209%208111%**204078> > > > ______________________________**_____________________ > > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > > > <mailto:wildfly-dev@lists.__jb**oss.org <http://jboss.org> > <mailto:wildfly-dev@lists.**jboss.org<wildfly-dev@lists.jboss.org> > >> > https://lists.jboss.org/____**mailman/listinfo/wildfly-dev<https://lis... > <https://lists.jboss.org/__**mailman/listinfo/wildfly-dev<https://lists... > > > > <https://lists.jboss.org/__** > mailman/listinfo/wildfly-dev<https://lists.jboss.org/__mailman/listinf... > <https://lists.jboss.org/**mailman/listinfo/wildfly-dev<https://lists.j... > >> > > > > > > -- > Fernando Ribeiro > Upic > +55 11 9 8111 4078 <tel:%2B55%2011%209%208111%**204078> > > >