Re: [wildfly-dev] Changes to the PicketLink Module

I guess that is the AbstractJPARegistry class referred to in my previous message, right?

On Jul 24, 2013 6:42 PM, "Scott Marlow" <smarlow(a)redhat.com <mailto:smarlow@redhat.com>> wrote: Can you give me a link to the PicketLink code that does the bootstrap? I'd like to see why you need to reference Hibernate directly. As long as the JPA subsystem JPAExtension.initialize() has run, the default persistence provider (Hibernate) will be available to javax.persistence.Persistence.__createEntityManagerFactory(). On 07/24/2013 03:39 PM, Fernando Ribeiro wrote: Scott, PicketLink doesn't use any Hibernate extensions, and users are expected to provide a persistence unit called "picketlink-sts" in their applications. Regarding the bootstraping of the persistence unit, you guessed right [1]. Regards, -- Fernando [1] https://github.com/picketlink/__picketlink/blob/__277c5b8ec9b6eee5dcd3642... <https://github.com/picketlink/picketlink/blob/277c5b8ec9b6eee5dcd36422763... r On Wed, Jul 24, 2013 at 4:17 PM, Scott Marlow <smarlow(a)redhat.com <mailto:smarlow@redhat.com> <mailto:smarlow@redhat.com <mailto:smarlow@redhat.com>>> wrote: How does PickLink bootstrap the persistence unit mentioned in [5] + [6]? I assume not via EE JPA container managed deployment. I'm guessing via direct calls to javax.persistence.Persistence.____createEntityManagerFactory("____picketlink-sts"). Does PicketLink use any Hibernate extensions? Or just the JPA api? Do we have a more complete example than [5]+[6], that include how users are expected to supply datasource/database configuration. On 07/24/2013 02:34 PM, Fernando Ribeiro wrote: The issue is the PicketLink module depending on a specific JPA implementation, which is not really desirable, and currently looks unavoidable. Regards. On Wed, Jul 24, 2013 at 11:55 AM, Jaikiran Pai <jpai(a)redhat.com <mailto:jpai@redhat.com> <mailto:jpai@redhat.com <mailto:jpai@redhat.com>> <mailto:jpai@redhat.com <mailto:jpai@redhat.com> <mailto:jpai@redhat.com <mailto:jpai@redhat.com>>>> wrote: Fernando actually proposed a fix which we wanted to be discussed here in the mailing list since the fix didn't look right for a core component like PicketLink. The PR (which we closed) is here https://github.com/wildfly/____wildfly/issues/4786 <https://github.com/wildfly/__wildfly/issues/4786> <https://github.com/wildfly/__wildfly/issues/4786 <https://github.com/wildfly/wildfly/issues/4786>> -Jaikiran On Wednesday 24 July 2013 08:22 PM, Darran Lofthouse wrote: > > On 24/07/13 15:46, Fernando Ribeiro wrote: >> All, >> >> There is an issue in PicketLink [1] that requires the module descriptor >> in WildFly to depend on "org.hibernate" and "org.javassist" to support >> two components called "JPABasedTokenRegistry" [2] and >> "JPABasedRevocationRegistry" [3]. >> >> How would you suggest this issue to be fixed? > If you already have the proposed fix I would suggest sending over a pull > request. > > https://community.jboss.org/____wiki/HackingOnWildFly <https://community.jboss.org/__wiki/HackingOnWildFly> <https://community.jboss.org/__wiki/HackingOnWildFly <https://community.jboss.org/wiki/HackingOnWildFly>> > > If you are an EAP customer I would suggest opening a support case so > that the support team can request the fix is included in EAP. > >> The issue has also been logged in WildFly already [4]. There are samples >> of the JPA registries available in my blog [5][6]. >> >> Regards, >> >> -- >> Fernando >> >> [1] https://issues.jboss.org/____browse/PLINK2-97 <https://issues.jboss.org/__browse/PLINK2-97> <https://issues.jboss.org/__browse/PLINK2-97 <https://issues.jboss.org/browse/PLINK2-97>> >> [2] >> https://access.redhat.com/____site/documentation/en-US/____JBoss_Enterpri... <https://access.redhat.com/__site/documentation/en-US/__JBoss_Enterprise_A... <https://access.redhat.com/__site/documentation/en-US/__JBoss_Enterprise_A... <https://access.redhat.com/site/documentation/en-US/JBoss_Enterprise_Appli... >> [3] >> https://access.redhat.com/____site/documentation/en-US/____JBoss_Enterpri... <https://access.redhat.com/__site/documentation/en-US/__JBoss_Enterprise_A... <https://access.redhat.com/__site/documentation/en-US/__JBoss_Enterprise_A... <https://access.redhat.com/site/documentation/en-US/JBoss_Enterprise_Appli... >> [4] https://issues.jboss.org/____browse/WFLY-1691 <https://issues.jboss.org/__browse/WFLY-1691> <https://issues.jboss.org/__browse/WFLY-1691 <https://issues.jboss.org/browse/WFLY-1691>> >> [5] >> http://simplesassim.wordpress.____com/2013/07/12/how-to-use-__the-__jpa-b... <http://simplesassim.__wordpress.com/2013/07/12/how-__to-use-the-jpa-based... <http://simplesassim.wordpress.com/2013/07/12/how-to-use-the-jpa-based-tok... >> [6] >> http://simplesassim.wordpress.____com/2013/07/21/how-to-use-__the-__jpa-b... <http://simplesassim.__wordpress.com/2013/07/21/how-__to-use-the-jpa-based... <http://simplesassim.wordpress.com/2013/07/21/how-to-use-the-jpa-based-rev... >> >> >> ___________________________________________________ >> wildfly-dev mailing list >> wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>> <mailto:wildfly-dev@lists. <mailto:wildfly-dev@lists.>__jb__oss.org <http://jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>>> >> https://lists.jboss.org/____mailman/listinfo/wildfly-dev <https://lists.jboss.org/__mailman/listinfo/wildfly-dev> <https://lists.jboss.org/__mailman/listinfo/wildfly-dev <https://lists.jboss.org/mailman/listinfo/wildfly-dev>> >> > ___________________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>> <mailto:wildfly-dev@lists. <mailto:wildfly-dev@lists.>__jb__oss.org <http://jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>>> > https://lists.jboss.org/____mailman/listinfo/wildfly-dev <https://lists.jboss.org/__mailman/listinfo/wildfly-dev> <https://lists.jboss.org/__mailman/listinfo/wildfly-dev <https://lists.jboss.org/mailman/listinfo/wildfly-dev>> ___________________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>> <mailto:wildfly-dev@lists. <mailto:wildfly-dev@lists.>__jb__oss.org <http://jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>>> https://lists.jboss.org/____mailman/listinfo/wildfly-dev <https://lists.jboss.org/__mailman/listinfo/wildfly-dev> <https://lists.jboss.org/__mailman/listinfo/wildfly-dev <https://lists.jboss.org/mailman/listinfo/wildfly-dev>> -- Fernando Ribeiro Upic +55 11 9 8111 4078 <tel:%2B55%2011%209%208111%204078> ___________________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org <mailto:wildfly-dev@lists.jboss.org> <mailto:wildfly-dev@lists.__jboss.org <mailto:wildfly-dev@lists.jboss.org>> https://lists.jboss.org/____mailman/listinfo/wildfly-dev <https://lists.jboss.org/__mailman/listinfo/wildfly-dev> <https://lists.jboss.org/__mailman/listinfo/wildfly-dev <https://lists.jboss.org/mailman/listinfo/wildfly-dev>> -- Fernando Ribeiro Upic +55 11 9 8111 4078 <tel:%2B55%2011%209%208111%204078>