1:41 p.m.
Hi,
I'm sorry that this is a little bit off-topic question but I already asked in the
forum and nobody answered me. How do you guys deal with the line endings unification in
your github repo? I saw that you don't have for example .jsp files in the
.gitattributes file however all .jsp files in the WF repo uses LF ending. How do you check
that windows CRLF won't get merged with some PR?
We are currently discussing the unification of the line endings in the Keycloak repo so I
would like to kindly ask you for any advice.
Thank you for the answer.
Regards,
Lukas
1:52 p.m.
I believe that this is done by checkstyle.
I found this on the checkstyle project:
https://github.com/checkstyle/checkstyle/issues/893
<module name="RegexpMultiline">
<property name="format" value="\r\n"/>
<property name="message" value="Do not use Windows line
endings"/>
</module>
2015-06-10 8:41 GMT-03:00 Lukas Kubik <lkubik(a)redhat.com>:
Hi,
I'm sorry that this is a little bit off-topic question but I already asked
in the forum and nobody answered me. How do you guys deal with the line
endings unification in your github repo? I saw that you don't have for
example .jsp files in the .gitattributes file however all .jsp files in the
WF repo uses LF ending. How do you check that windows CRLF won't get merged
with some PR?
We are currently discussing the unification of the line endings in the
Keycloak repo so I would like to kindly ask you for any advice.
Thank you for the answer.
Regards,
Lukas
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
__________________________
Eduardo Sant'Ana da Silva - Dr.
Pesquisador / Consultor de TI
8:30 p.m.
Hi Eduardo,
I haven't found this settings in the Wildfly checkstyle settings so that's one of
the reasons why I asked about the line endings.
Thanks for the possible solution.
Regards,
Lukas
----- Original Message -----
From: "Eduardo Sant´Ana da Silva" <eduardo.santanadasilva(a)gmail.com>
To: "Lukas Kubik" <lkubik(a)redhat.com>
Cc: wildfly-dev(a)lists.jboss.org
Sent: Wednesday, June 10, 2015 1:52:50 PM
Subject: Re: [wildfly-dev] Github repo line endings unification advice
I believe that this is done by checkstyle.
I found this on the checkstyle project:
https://github.com/checkstyle/checkstyle/issues/893
<module name="RegexpMultiline">
<property name="format" value="\r\n"/>
<property name="message" value="Do not use Windows line
endings"/>
</module>
2015-06-10 8:41 GMT-03:00 Lukas Kubik <lkubik(a)redhat.com>:
Hi,
I'm sorry that this is a little bit off-topic question but I already asked
in the forum and nobody answered me. How do you guys deal with the line
endings unification in your github repo? I saw that you don't have for
example .jsp files in the .gitattributes file however all .jsp files in the
WF repo uses LF ending. How do you check that windows CRLF won't get merged
with some PR?
We are currently discussing the unification of the line endings in the
Keycloak repo so I would like to kindly ask you for any advice.
Thank you for the answer.
Regards,
Lukas
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
--
__________________________
Eduardo Sant'Ana da Silva - Dr.
Pesquisador / Consultor de TI
2:04 p.m.
It's a mistake that the jsp files aren't in gitatttibutes. The reason that it
hasn't gotten CRLF is probably a bit of luck, and a bit of the fact that most code
editors try to preserve them on their own even on windows.
On Jun 10, 2015, at 6:41 AM, Lukas Kubik <lkubik(a)redhat.com>
wrote:
Hi,
I'm sorry that this is a little bit off-topic question but I already asked in the
forum and nobody answered me. How do you guys deal with the line endings unification in
your github repo? I saw that you don't have for example .jsp files in the
.gitattributes file however all .jsp files in the WF repo uses LF ending. How do you check
that windows CRLF won't get merged with some PR?
We are currently discussing the unification of the line endings in the Keycloak repo so I
would like to kindly ask you for any advice.
Thank you for the answer.
Regards,
Lukas
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
8:23 p.m.
Hi Jason,
Thanks for the explanation. Is there any reason why you don't use "*
text=auto" option?
Lukas
----- Original Message -----
From: "Jason T. Greene" <jason.greene(a)redhat.com>
To: "Lukas Kubik" <lkubik(a)redhat.com>
Cc: wildfly-dev(a)lists.jboss.org
Sent: Wednesday, June 10, 2015 2:04:53 PM
Subject: Re: [wildfly-dev] Github repo line endings unification advice
It's a mistake that the jsp files aren't in gitatttibutes. The reason that it
hasn't gotten CRLF is probably a bit of luck, and a bit of the fact that most code
editors try to preserve them on their own even on windows.
On Jun 10, 2015, at 6:41 AM, Lukas Kubik <lkubik(a)redhat.com>
wrote:
Hi,
I'm sorry that this is a little bit off-topic question but I already asked in the
forum and nobody answered me. How do you guys deal with the line endings unification in
your github repo? I saw that you don't have for example .jsp files in the
.gitattributes file however all .jsp files in the WF repo uses LF ending. How do you check
that windows CRLF won't get merged with some PR?
We are currently discussing the unification of the line endings in the Keycloak repo so I
would like to kindly ask you for any advice.
Thank you for the answer.
Regards,
Lukas
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev
3237
days inactive
3242
days old
4 comments
3 participants
participants (3)
-
Eduardo Sant´Ana da Silva -
Jason T. Greene -
Lukas Kubik