Re: [forge-dev] Wondering about coding convention #philosophy

----- Original Message ----- +1. I would consider these architectural styles more than coding conventions, and I believe it would be wise to 'standardize' some of these for Java EE 6+. They do look similar, but they're not the same in all respects. The one in REST will contain JOIN FETCH expressions when relationships (@OneToMany, @ManyToMany etc.) are found in the class. This was done to ensure that serialization would not emit incomplete object graphs. There are various factors that would be at work here in determining what JPQL queries should be generated. Obviously in this context, exposing JPA entities directly is bad idea and projections/views of the entities should be used instead. IMHO we should not be putting persistence concerns in either the JSF beans or the REST resources. They should go into a service or a repository or whatever data access pattern is suitable for the context. This is where we lack any standardization at the moment, and it would be better to not limit this exercise to improving the conventions alone, but also the architecture. I don't believe in packing in persistence concerns however small, into these beans for * we run the risk of generating God classes, and * we'd leave users with the task of creating/extracting the persistence layer (which should have been done by Forge in the first place).