Re: [Hawkular-dev] [process] tickets and PRs
Le 26/05/2015 16:27, Thomas Heute a écrit :
On 05/26/2015 04:18 PM, Heiko W.Rupp wrote:
> >On 26 May 2015, at 16:11, John Sanda wrote:
> >
>> >>Does there need to be a pull request for every ticket? Put another
>> >>way, do all commits to master need to come by way of PRs? I think that
>> >>there are scenarios where a manual merge makes more sense.
> >
> >I think the pull-request itself is not the issue here, but the case that
> >something that goes into master should have seen some peer-review
> >before.
> >How that happens - via pull-request, patch in email or a separate branch
> >that gets merged is secondary.
Pull-request is more visible, triggers a build and is wired with JIRA,
so it must be used.
But how that gets merged is indeed separate, I know some teams (like
GateIn) forbid the use of the green button, but that doesn't prevent a
PR to be made and merged via CLI.
I agree with Heiko and Thomas.
That said, I think John is wondering about merging the rx-migration into
master. In this case, I don't think there's a need for a PR, as many of
the commits to the branch have been sent as PR already.