11:12 p.m.
The Typescript project has really put some thought into PR Labels:
https://github.com/Microsoft/TypeScript/labels
<https://github.com/Microsoft/TypeScript/labels>
Thoughts on us using and standardising these across our projects?
— Mike
12:06 a.m.
----- Original Message -----
From: "mike thompson" <mithomps(a)redhat.com>
To: "Discussions around Hawkular development"
<Hawkular-dev(a)lists.jboss.org>
Sent: Thursday, May 14, 2015 5:12:23 PM
Subject: [Hawkular-dev] Github Labels for PR
The Typescript project has really put some thought into PR Labels:
https://github.com/Microsoft/TypeScript/labels
Thoughts on us using and standardising these across our projects?
+1 on standardisation
Can this be managed in one place? Or would each of the components have to manage their own
list of labels?
12:43 a.m.
On 14 May 2015, at 15:06, Matthew Wringe <mwringe(a)redhat.com>
wrote:
----- Original Message -----
> From: "mike thompson" <mithomps(a)redhat.com>
> To: "Discussions around Hawkular development"
<Hawkular-dev(a)lists.jboss.org>
> Sent: Thursday, May 14, 2015 5:12:23 PM
> Subject: [Hawkular-dev] Github Labels for PR
>
> The Typescript project has really put some thought into PR Labels:
>
> https://github.com/Microsoft/TypeScript/labels
>
> Thoughts on us using and standardising these across our projects?
+1 on standardisation
Can this be managed in one place? Or would each of the components have to manage their
own list of labels?
Unfortunately, this would have to happen on each git repo (that
has PR enabled). The labels are quick to create though and the standard ones would likely
remain static.
This also facilitates faster historical lookup of say ‘Documentation’ PRs or ‘API’ PRs.
If we want to do this, the first step would be to setup a google doc spreadsheet and agree
on the labels.
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
3:14 p.m.
Hi,
I hope we're not duplicating the JIRA here? Since we're using JIRA anyway for
issues, why not handle the PR status there also?
- Micke
----- Original Message -----
From: "mike thompson" <mithomps(a)redhat.com>
To: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Sent: Friday, May 15, 2015 1:43:14 AM
Subject: Re: [Hawkular-dev] Github Labels for PR
On 14 May 2015, at 15:06, Matthew Wringe <mwringe(a)redhat.com>
wrote:
----- Original Message -----
> From: "mike thompson" <mithomps(a)redhat.com>
> To: "Discussions around Hawkular development"
<Hawkular-dev(a)lists.jboss.org>
> Sent: Thursday, May 14, 2015 5:12:23 PM
> Subject: [Hawkular-dev] Github Labels for PR
>
> The Typescript project has really put some thought into PR Labels:
>
> https://github.com/Microsoft/TypeScript/labels
>
> Thoughts on us using and standardising these across our projects?
+1 on standardisation
Can this be managed in one place? Or would each of the components have to manage their
own list of labels?
Unfortunately, this would have to happen on each git repo (that
has PR enabled). The labels are quick to create though and the standard ones would likely
remain static.
This also facilitates faster historical lookup of say ‘Documentation’ PRs or ‘API’ PRs.
If we want to do this, the first step would be to setup a google doc spreadsheet and agree
on the labels.
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
4:18 p.m.
On 15 May 2015, at 06:14, Michael Burman <miburman(a)redhat.com>
wrote:
Hi,
I hope we're not duplicating the JIRA here? Since we're using JIRA anyway for
issues, why not handle the PR status there also?
We are not duplicating JIRA here, because we are not using PRs for our issue tracking. We
still have PRs, and they still need status labels like the ‘Don’t Merge Yet’ label that we
have now. The typescript example does have some examples of Issue type labels though, so
it can be confusing (but we shouldn’t take those labels).
- Micke
----- Original Message -----
From: "mike thompson" <mithomps(a)redhat.com>
To: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Sent: Friday, May 15, 2015 1:43:14 AM
Subject: Re: [Hawkular-dev] Github Labels for PR
> On 14 May 2015, at 15:06, Matthew Wringe <mwringe(a)redhat.com> wrote:
>
>
>
> ----- Original Message -----
>> From: "mike thompson" <mithomps(a)redhat.com>
>> To: "Discussions around Hawkular development"
<Hawkular-dev(a)lists.jboss.org>
>> Sent: Thursday, May 14, 2015 5:12:23 PM
>> Subject: [Hawkular-dev] Github Labels for PR
>>
>> The Typescript project has really put some thought into PR Labels:
>>
>> https://github.com/Microsoft/TypeScript/labels
>>
>> Thoughts on us using and standardising these across our projects?
>
> +1 on standardisation
>
> Can this be managed in one place? Or would each of the components have to manage
their own list of labels?
Unfortunately, this would have to happen on each git repo (that has PR enabled). The
labels are quick to create though and the standard ones would likely remain static.
This also facilitates faster historical lookup of say ‘Documentation’ PRs or ‘API’ PRs.
If we want to do this, the first step would be to setup a google doc spreadsheet and
agree on the labels.
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
9:55 a.m.
On 15 May 2015, at 0:43, mike thompson wrote:
If we want to do this, the first step would be to setup a google doc
spreadsheet and agree on the labels.
And if agreed upon, document them on the hawkular.org web site.
3:45 p.m.
On 18 May 2015, at 00:55, Heiko W.Rupp <hrupp(a)redhat.com>
wrote:
On 15 May 2015, at 0:43, mike thompson wrote:
> If we want to do this, the first step would be to setup a google doc
> spreadsheet and agree on the labels.
And if agreed upon, document them on the hawkular.org web site.
On Friday, Villiam found an issue with labels that only admins of the repo can change the
labels. This can still be useful for organization of PRs but makes it not as useful for
marking the WIP or ‘Don’t Merge Yet’ for non-admins.
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
3327
days inactive
3331
days old
6 comments
4 participants
participants (4)
-
Heiko W.Rupp -
Matthew Wringe -
Michael Burman -
mike thompson