Hi, This morning I've fixed the remaining issues in the JAX-RS 1.1 implementation branch. The REST API test suite is now fully passing against both JAX-RS 1.1 and 2.0 implementations. I've added a 'diff.txt' file in the 'api' [1]. Reviewers should carefully look at handler code differences. Regards, Thomas [1] diff -r --exclude=target metrics-api-jaxrs metrics-api-jaxrs-1.1 > diff.txt _______________________________________________ hawkular-dev mailing list hawkular-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hawkular-dev

From: "Thomas Segismont" <tsegismo(a)redhat.com&gt; To: hawkular-dev(a)lists.jboss.org Sent: Friday, August 28, 2015 8:28:22 AM Subject: Re: [Hawkular-dev] [Metrics] JAX-RS 1.1 implementation update I've been playing with GitHub API this morning, and I figured out to post the diff as a comment in pull requests.

@metrics-dev would you find that useful? Or too noisy?

I thought about this as I noted we don't always remind to make changes on both implementations.

Le 13/08/2015 12:38, Thomas Segismont a écrit : > Forgot this: I believe this branch should be reviewed and merged ASAP. > > And, in the future, REST API PR reviewers should make sure changes/fixes > are applied to both implementations. > > Le 13/08/2015 12:32, Thomas Segismont a écrit : >> Hi, >> >> This morning I've fixed the remaining issues in the JAX-RS 1.1 >> implementation branch. The REST API test suite is now fully passing >> against both JAX-RS 1.1 and 2.0 implementations. >> >> I've added a 'diff.txt' file in the 'api' [1]. Reviewers should >> carefully look at handler code differences. >> >> Regards, >> Thomas >> >> >> [1] diff -r --exclude=target metrics-api-jaxrs metrics-api-jaxrs-1.1 > >> diff.txt >> _______________________________________________ >> hawkular-dev mailing list >> hawkular-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hawkular-dev >> > > _______________________________________________ > hawkular-dev mailing list > hawkular-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hawkular-dev > _______________________________________________ hawkular-dev mailing list hawkular-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hawkular-dev

I've created this PR "Pre-commit hook sample for JAX-RS diffs" #331 https://github.com/hawkular/hawkular-metrics/pull/331 As the name suggests, it adds a pre-commit hook sample to the "api" directory. If we go this way, metrics devs should add this commit hook to their local repository. Then whenever a PR changes the diff, it will be committed and show on GitHub review pages. Compared to the Travis based solution: - diff shows up on GitHub only if new differences were introduced - the diff file is kept up-to-date without developer intervention - diff shows up on GitHub as a file change, so it looks much nicer on review pages and can be downloaded easily I believe it's a better solution. Le 28/08/2015 17:28, Stefan Negrea a écrit : > > ----- Original Message ----- >> From: "Thomas Segismont" <tsegismo(a)redhat.com&gt; >> To: hawkular-dev(a)lists.jboss.org >> Sent: Friday, August 28, 2015 8:28:22 AM >> Subject: Re: [Hawkular-dev] [Metrics] JAX-RS 1.1 implementation update >> >> I've been playing with GitHub API this morning, and I figured out to >> post the diff as a comment in pull requests. > > Could the developer creating the PR add this diff manually? Or it has to be automatic on every PR? There are some PRs that do not touch the REST implementations. If we can selectively attach this to PRs that need it, I think we should do it even if it is verbose. > >> >> @metrics-dev would you find that useful? Or too noisy? > > I would like to see an example first. > >> >> I thought about this as I noted we don't always remind to make changes >> on both implementations. > > We should require adding integration tests for any change in the REST interface. And since we started this dual implementation, we have been good at doing it. Adding this diff would be an excellent second check for the tedious configuration we currently have. > >> >> Le 13/08/2015 12:38, Thomas Segismont a écrit : >>> Forgot this: I believe this branch should be reviewed and merged ASAP. >>> >>> And, in the future, REST API PR reviewers should make sure changes/fixes >>> are applied to both implementations. >>> >>> Le 13/08/2015 12:32, Thomas Segismont a écrit : >>>> Hi, >>>> >>>> This morning I've fixed the remaining issues in the JAX-RS 1.1 >>>> implementation branch. The REST API test suite is now fully passing >>>> against both JAX-RS 1.1 and 2.0 implementations. >>>> >>>> I've added a 'diff.txt' file in the 'api' [1]. Reviewers should >>>> carefully look at handler code differences. >>>> >>>> Regards, >>>> Thomas >>>> >>>> >>>> [1] diff -r --exclude=target metrics-api-jaxrs metrics-api-jaxrs-1.1 > >>>> diff.txt >>>> _______________________________________________ >>>> hawkular-dev mailing list >>>> hawkular-dev(a)lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/hawkular-dev >>>> >>> >>> _______________________________________________ >>> hawkular-dev mailing list >>> hawkular-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hawkular-dev >>> >> >> _______________________________________________ >> hawkular-dev mailing list >> hawkular-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hawkular-dev >> > > _______________________________________________ > hawkular-dev mailing list > hawkular-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hawkular-dev > _______________________________________________ hawkular-dev mailing list hawkular-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hawkular-dev

Just a line to tell you the hook has been updated in master branch, in order to ignore IDE specific files. Please update your git config as needed.

This morning I've fixed the remaining issues in the JAX-RS 1.1 implementation branch. The REST API test suite is now fully passing against both JAX-RS 1.1 and 2.0 implementations.