In the standalone.xml we can define system properties with default values. But not sure what you mean by hook, a primitive way could be to create a bin/hawkular.sh or similar to call into standalone.sh or simply customize standalone.conf as well. Not sure if you are refering to this. But it is interesting topic as it is linked with the installer thread which I think we should continue talking about it and reach some agreement. ----- Original Message ----- > From: "John Mazzitelli" <mazz(a)redhat.com&gt; > To: "Discussions around Hawkular development" > <hawkular-dev(a)lists.jboss.org&gt; > Sent: Thursday, January 28, 2016 2:12:17 PM > Subject: [Hawkular-dev] how to avoid required sysprops > > I saw Juca posted this in a github comment: > > > That happens because the `keycloak.server.url` property is not set, so, > > it > > defaults to localhost:8080 . You can start the server with > > `-Dkeycloak.server.url=http://localhost:8180/auth` > > > > --- > > Reply to this email directly or view it on GitHub: > > https://github.com/hawkular/hawkular-btm/pull/281#issuecomment-176169067 > > I think this is the problem I saw yesterday with my inventory going screwy > (not sure, but I was using port offset, and didn't set that sysprop). > > I bring this up to ask - is there anything we can do to not require that > sysprop to be set? For example, is there some startup hook we can have that > sets this automatically? I don't know if it's possible, but, it is pretty > clear this is going to be a common problem that people will forget to set > this anytime they bind to a different address (using -b) or using a > different port offset. > > Is there a JIRA on this so we can try to address it in the future? > > I suppose if we do have some kind of installer, one solution would be the > installer would add this sysprop to the startup .conf file. > _______________________________________________ > hawkular-dev mailing list > hawkular-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hawkular-dev >

Before the keycloak.server.url, we did have a feature where we would try to determine the IPs and ports that we are running. The problem is that a Keycloak "ticket" issued via "localhost:8080" cannot be validated by a server on "127.0.0.1:8080" (there's an "issuer" field on the OAuth, and any mismatch there *has* to fail the validation). So, we need a "consistent" way to reach the Keycloak server, hence the property. We could try to tweak the port offset, but that solves only part of the problem. Note also that Keycloak *will* be somewhere else in production environments, so, we do need this property in a way or another. What we could improve, though, is how to make the "default" value smarter. If we have some sort of installer, do we assume then that users won't change the port offset? If so, I could make a "first boot" routine that would set the default value of the property to the appropriate offset, while leaving the host as "localhost". - Juca. _______________________________________________ hawkular-dev mailing list hawkular-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/hawkular-dev