October 2011 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-3718) call to id getter initializes proxy when using AccessType( "field" )

by Paul Lorenz (JIRA)

call to id getter initializes proxy when using AccessType( "field" ) -------------------------------------------------------------------- Key: HHH-3718 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3718 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.3.1 Environment: hibernate 3.3.1, hibernate annotations 3.4.0, running on windows, linux and solaris, using sybase 15 Reporter: Paul Lorenz Calling getter for id when using AccessType( "field" ) causes proxy initialization. In org.hibernate.proxy.proxy.pojo.BasicLazyInitializer there is the code else if ( isUninitialized() && method.equals(getIdentifierMethod) ) { return getIdentifier(); } However, when using field access, the getIdentifierMethod will be null. I fixed this for us by changing DirectPropertyAccessor by adding a Method attribute to the DirectGetter inner class, and looking up the appropriate getter in the constructor. As far as I can tell, getMethod is only used in two places. In the above case, to the get the identity getter and in PojoComponentTupilizer.isMethodOf. This doesn't seem to break anything. I don't know if this is a clean solution, seems a little hacky to me, however, it would be great if the issue could be fixed somehow. public static final class DirectGetter implements Getter { private final transient Field field; private final Class clazz; private final String name; private Method method; DirectGetter(Field field, Class clazz, String name) { this.field = field; this.clazz = clazz; this.name = name; try { BeanInfo beanInfo = Introspector.getBeanInfo( clazz ); PropertyDescriptor[] pdArray = beanInfo.getPropertyDescriptors(); if ( pdArray != null ) { for (PropertyDescriptor pd : pdArray ) { if ( pd.getName().equals( name ) ) { this.method = pd.getReadMethod(); } } } } catch ( Exception e ) { // ignore } } public Object get(Object target) throws HibernateException { try { return field.get(target); } catch (Exception e) { throw new PropertyAccessException(e, "could not get a field value by reflection", false, clazz, name); } } public Object getForInsert(Object target, Map mergeMap, SessionImplementor session) { return get( target ); } public Method getMethod() { return method; } public String getMethodName() { return method == null ? null : method.getName(); } public Class getReturnType() { return field.getType(); } Object readResolve() { return new DirectGetter( getField(clazz, name), clazz, name ); } public String toString() { return "DirectGetter(" + clazz.getName() + '.' + name + ')'; } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

10
18
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-798) Make use of categories instead of fqcn for logging

by Emmanuel Bernard (JIRA)

Make use of categories instead of fqcn for logging -------------------------------------------------- Key: HSEARCH-798 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-798 Project: Hibernate Search Issue Type: Improvement Components: engine Reporter: Emmanuel Bernard Fix For: 4.0 http://community.jboss.org/wiki/HowToLogInJBossProjects We need to define the set of categories we wish to have eg: * org.hibernate.search.query * org.hibernate.search.hcore * org.hibernate.search.batchindexing etc The idea behind category is that they are more stable than classes and thus better for the user WDYT? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

3
9
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-295) Generate the "right" FilterKey instance even on parameterized filters

by Emmanuel Bernard (JIRA)

Generate the "right" FilterKey instance even on parameterized filters --------------------------------------------------------------------- Key: HSEARCH-295 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-295 Project: Hibernate Search Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard Priority: Minor Rules around object equality are the most tricky. Not sure we can do a good job at it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

2
4
0 / 0

[Hibernate-JIRA] Created: (HV-416) Get documentation onto translate.jboss.org

by Hardy Ferentschik (JIRA)

Get documentation onto translate.jboss.org ------------------------------------------- Key: HV-416 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-416 Project: Hibernate Validator Issue Type: Task Components: build, documentation Affects Versions: 4.2.0.Beta1 Reporter: Hardy Ferentschik Assignee: Hardy Ferentschik Fix For: 4.2.0.CR1 Need to setup project on translate.jboss.org and integrate with flies maven plugin * http://community.jboss.org/wiki/Flies * http://community.jboss.org/wiki/FliesIntegration -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

1
7
0 / 0

[Hibernate-JIRA] Created: (HHH-5743) Criteria isMember() creates broken SQL in joined queries

by David Momper (JIRA)

Criteria isMember() creates broken SQL in joined queries -------------------------------------------------------- Key: HHH-5743 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5743 Project: Hibernate Core Issue Type: Bug Components: entity-manager Affects Versions: 3.6.0, 3.6.1 Environment: Hibernate 3.6.0,3.6.1, all databases Reporter: David Momper Priority: Critical Attachments: Test.zip This problem occurred both when using Oracle, or Derby. I assume it occurs for all databases. I also ran my test case with EclipseLink, and the test passed. A criteria query like this: {quote} CriteriaQuery<Group> groupQuery = cb.createQuery(Group.class); Root<Group> gRoot = groupQuery.from(Group.class); //Get all groups whose leader's name is John, and has a valid visa for given country groupQuery.where(cb.and( cb.like(gRoot.get(Group_.groupLeader) .get(Person_.personName), "%John%"), cb.isMember(country, gRoot.get(Group_.groupLeader) .get(Person_.validVisas) ) )); {quote} produces the following query: {quote} select group0_.GROUP_ID as GROUP1_2_, group0_.LEADER_ID as LEADER3_2_, group0_.GROUP_NAME as GROUP2_2_ from GROUPS group0_, PERSON person1_ where group0_.LEADER_ID=person1_.PERSON_ID and ( person1_.PERSON_NAME like ? ) and ( ? in ( select person1_.PERSON_ID from PERSON person1_ ) ) {quote} The query fails because a (character) country code is being checked for inclusion in a subquery of (int) person ids. The subselect in the above query should be on a country, not a person. I think the whole query should look like this: {quote} select group0_.GROUP_ID as GROUP1_2_, group0_.LEADER_ID as LEADER3_2_, group0_.GROUP_NAME as GROUP2_2_ from GROUPS group0_, PERSON person1_ where group0_.LEADER_ID=person1_.PERSON_ID and ( person1_.PERSON_NAME like ? ) and ( ? in ( select country3_.COUNTRY_CODE from PERSON person1_, PERSON_COUNTRY_VISA validvisas2_, COUNTRY country3_ where group0_.LEADER_ID=person1_.PERSON_ID and person1_.PERSON_ID=validvisas2_.PERSON_ID and validvisas2_.COUNTRY_CODE=country3_.COUNTRY_CODE ) ) {quote} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

4
9
0 / 0

[Hibernate-JIRA] Created: (HHH-5130) Add pointers to Infinispan second level cache

by Sanne Grinovero (JIRA)

Add pointers to Infinispan second level cache --------------------------------------------- Key: HHH-5130 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5130 Project: Hibernate Core Issue Type: Improvement Components: caching (L2), documentation Affects Versions: 3.5.1 Reporter: Sanne Grinovero Assignee: Sanne Grinovero Priority: Trivial Fix For: 3.5.x Infinispan is not mentioned in the docs, it should be listed at least in the existing table having all caches. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

2
4
0 / 0

[Hibernate-JIRA] Created: (HHH-6405) setFetchMode ignored in certain cases when using criteria queries

by David Mansfield (JIRA)

setFetchMode ignored in certain cases when using criteria queries ----------------------------------------------------------------- Key: HHH-6405 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6405 Project: Hibernate Core Issue Type: Bug Affects Versions: 4.0.0.Beta2, 3.6.5 Reporter: David Mansfield Description: Setting join type (e.g.) criteria.setJoinType("association.path", FetchType.JOIN) is ignored if the association being set is one of a few types. I believe many-to-many, and any association off of a collection-of-component. For these types of associations, the specified fetch type is ignored. This worked in prior versions. This has nothing to do with having additional restrictions on the same association, which is a different issue altogether. Technical analysis: This regression was introduced in git commit fbae6db0abaeb6f050ee97ce53d09d74886a7e47, and the fix for a possibly related issue in git commit 1c556dc775708706b6ca84251cb170d3c46f729f was not a complete fix, or rather did not fix this case scenario. The first referenced commit split the JoinWalker.getJoinType(...) api into two methods, one with more parameters. In the base class implementation, one method or the other is called based on the type of association (see above). However, in the CriteriaJoinWalker (a subclass), the existing implementation only overrode one of these two methods, (the one with more arguments) causing calls into the other method to be handled by the base class, which did not function appropriately. The second referenced commit introduced an override for the second method, however the implementation was incomplete, and was missing the crucial piece, specifically: FetchMode fetchMode = translator.getRootCriteria().getFetchMode( path.getFullPath() ); which examined the explicitly set join types in the translator. A fix will be supplied on github for 3.6.x and 4.0. The implementation re-unifies the two methods in the CriteriaJoinWalker, using if/else to delegate to the correct super.getJoinType(...) method as appropriate. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

4
9
0 / 0

[Hibernate-JIRA] Created: (HHH-6328) Hibernate's "Table" annotations does not cooperate well with custom quoting naming strategy

by Richard Eckart de Castilho (JIRA)

Hibernate's "Table" annotations does not cooperate well with custom quoting naming strategy ------------------------------------------------------------------------------------------- Key: HHH-6328 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6328 Project: Hibernate Core Issue Type: Bug Components: annotations Affects Versions: 3.6.5 Reporter: Richard Eckart de Castilho I have implemented a custom QuotingNamingStrategy that quotes table names, so that they are properly treated as case sensitive and to avoid issues with reserved names. I also have auxiliary "Table" annotations to have Hibernate create indexes on my behalf. Of course the table name is not quoted in these annotations: {code} @org.hibernate.annotations.Table(appliesTo="MyTable",indexes = { @Index(name="column1", columnNames="column2")}) {code} Now I get the exception: {noformat} org.hibernate.AnnotationException: @org.hibernate.annotations.Table references an unknown table: MyTable at org.hibernate.cfg.annotations.EntityBinder.processComplementaryTableDefinitions(EntityBinder.java:877) at org.hibernate.cfg.AnnotationBinder.bindClass(AnnotationBinder.java:733) {noformat} Debugging the issue, I find that the EntityBinder tries to match the quoted name against the "appliesTo" attribute of the Table annotation, but the value of this attribute is not processed by my custom QuotingNamingStrategy. Thus, the table cannot be found: {code} public void processComplementaryTableDefinitions(org.hibernate.annotations.Table table) { //comment and index are processed here if ( table == null ) return; String appliedTable = table.appliesTo(); Iterator tables = persistentClass.getTableClosureIterator(); Table hibTable = null; while ( tables.hasNext() ) { Table pcTable = (Table) tables.next(); // -=> Here the quoted name is compared to the unquoted name from "appliedTable" if ( pcTable.getQuotedName().equals( appliedTable ) ) { //we are in the correct table to find columns hibTable = pcTable; break; } hibTable = null; } if ( hibTable == null ) { //maybe a join/secondary table for ( Join join : secondaryTables.values() ) { if ( join.getTable().getQuotedName().equals( appliedTable ) ) { hibTable = join.getTable(); break; } } } if ( hibTable == null ) { throw new AnnotationException( "@org.hibernate.annotations.Table references an unknown table: " + appliedTable ); } if ( !BinderHelper.isEmptyAnnotationValue( table.comment() ) ) hibTable.setComment( table.comment() ); TableBinder.addIndexes( hibTable, table.indexes(), mappings ); } {code} I do believe that the value of the "appliedTo" attribute should be passed through the naming strategy before comparing against the table name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-6504) Develop Map-style plural attribute support for new metamodel

by Steve Ebersole (JIRA)

Develop Map-style plural attribute support for new metamodel ------------------------------------------------------------ Key: HHH-6504 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6504 Project: Hibernate Core Issue Type: Task Components: core, metamodel Reporter: Steve Ebersole Assignee: Steve Ebersole Fix For: 4.0.0.next -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

2
4
0 / 0

[Hibernate-JIRA] Created: (HHH-6167) "Mixing nullable" Error Message Correction

by David (JIRA)

"Mixing nullable" Error Message Correction ------------------------------------------ Key: HHH-6167 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-6167 Project: Hibernate Core Issue Type: Improvement Components: annotations, core Affects Versions: 3.6.1 Environment: Hibernate 3.6.1.FINAL Reporter: David Priority: Trivial I got the following exception: AnnotationException: Mixing nullable and non nullable columns in a property is not allowed: org.test.domain.PersonlastName Please consider changing it to: property is not allowed: org.test.domain.Person.lastName or property is not allowed: lastName of org.test.domain.Person -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 11 months

2
2
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues October 2011