June 2011 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HV-373) Investigate XML-based configuration of method-level constraints

by Gunnar Morling (JIRA)

Investigate XML-based configuration of method-level constraints --------------------------------------------------------------- Key: HV-373 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-373 Project: Hibernate Validator Issue Type: Sub-task Components: engine Reporter: Gunnar Morling Assignee: Gunnar Morling Fix For: 4.2.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
11
0 / 0

[Hibernate-JIRA] Created: (BVAL-199) New convenience methods on Validator: void assertValid(Object o)/assertValidProperty(...)/assertValidValue(...) which throw a runtime ValidationException

by Geoffrey De Smet (JIRA)

New convenience methods on Validator: void assertValid(Object o)/assertValidProperty(...)/assertValidValue(...) which throw a runtime ValidationException --------------------------------------------------------------------------------------------------------------------------------------------------------- Key: BVAL-199 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-199 Project: Bean Validation Issue Type: New Feature Components: spec-general Affects Versions: 1.0 final Reporter: Geoffrey De Smet 90% of the time we want to do: {code} Set<ConstraintViolation<Car>> constraintViolations = validator.validate(car); if (constraintViolations.size() > 0) { throw new MyValidationException(decentErrorMessage); } {code} >From http://docs.jboss.org/hibernate/stable/validator/reference/en/html_single... So why not supply a facade method to make it easy for us developers (especially those migrating from hibernate validator 3)? {code} validator.assertValid(car); {code} That allows the bean validation to standarize the Exception too: a ValidationException (or InvalidStateException or whatever you call it), which is of course a runtime exception. That in turn, allows the front-end frameworks to deal with that exception more cleanly (give the user a clue why the business method failed when it imported that address without a street from an import addresses file). Give special care to the message of that exception. It should clearly state at least 1 of the validations that failed (in english, not i18n) so when we find such an exception in the log we can easily see what caused it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

4
6
0 / 0

[Hibernate-JIRA] Created: (BVAL-225) JSR303 1.1: support resource bundles in constraint annotation packages

by Gabriele Del Prete (JIRA)

JSR303 1.1: support resource bundles in constraint annotation packages ---------------------------------------------------------------------- Key: BVAL-225 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-225 Project: Bean Validation Issue Type: Improvement Affects Versions: 1.1 Reporter: Gabriele Del Prete Attachments: ResourceBundleMessageInterpolator.java (I published this same proposal also on the forum, and copying it here so that it does not get lost) This is a proposal for the new version of JSR 303 (v1.1 ?). The proposal is: modify the default message interpolation algorithm (section 4.3.1.1) so that the validation engine looks for a Resource Bundle called "ValidationMessages" in the constraint annotation's own package. For example, when validating constraint annotation com.gdpcons.constraints.MustEqual, validator should also look for messages in a resource bundle called com.gdpcons.constraints.ValidationMessages. The constraint annotation package ValidationMessages resource bundle should be checked after the "user" ValidationMessages resource bundle, but before the BeanValidation provider's own private ValidationMessages resource bundle, so as to allow users to override the string provided by the constraint annotation resource bundle. This would allow people to write redistributable collections of constraint annotations, since as of today it's not possible to use multiple ValidationMessages resource bundles files (one will override all the others in the classpath); and it would still allow users to override the provided messages just by a new definition for the message key in their own ValidationMessages resource bundle. I've written an example implementation, by modifying Hibernate Validator's own ResourceBundleMessageInterpolator. It seams to work without side effects, and is a very straightforward implementation. See it attached to this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
4
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-735) Create a test for HSEARCH-734

by Sanne Grinovero (JIRA)

Create a test for HSEARCH-734 ----------------------------- Key: HSEARCH-735 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-735 Project: Hibernate Search Issue Type: Task Reporter: Sanne Grinovero Assignee: Sanne Grinovero Fix For: 3.5 Preventing the NPE reported as HSEARCH-734 was trivial, but we are missing a test for it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

1
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-209) Upload schema where they are due

by Emmanuel Bernard (JIRA)

Upload schema where they are due -------------------------------- Key: BVAL-209 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-209 Project: Bean Validation Issue Type: Bug Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Like http://java.sun.com/xml/ns/javaee/ we should have http://jboss.org/xml/ns/javax/validation/configuration should point to a descriptive html page. This page pointing to validation-configuration-1.0.xsd http://jboss.org/xml/ns/javax/validation/mapping should point to a descriptive html page. This page pointing to validation-mapping-1.0.xsd -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-211) Consider making javax.validation.ValidatorContext a self-referential generic type

by Gunnar Morling (JIRA)

Consider making javax.validation.ValidatorContext a self-referential generic type --------------------------------------------------------------------------------- Key: BVAL-211 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-211 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.0 final Reporter: Gunnar Morling Priority: Minor It should be investigated whether the interface javax.validation.ValidatorContext could be re-defined as self-referential generic type as follows: {code:java} public interface ValidatorContext <V extends ValidatorContext<V>> { V messageInterpolator(MessageInterpolator messageInterpolator); V traversableResolver(TraversableResolver traversableResolver); V constraintValidatorFactory(ConstraintValidatorFactory factory); Validator getValidator(); } {code} Provider-specific extensions of this interface (such as [HibernateValidatorContext|https://github.com/hibernate/hibernate-validato...]) then wouldn't have to re-define all of ValidatorContext's methods returning their own type (which they currently must do in order to allow for the method chaining pattern to work correctly). Generally this is a breaking change, as existing implementations wouldn't compile with the proposed new version of the interface. But as it is intended to be implemented by BV providers only, this seems acceptable. API users would get a raw type warning if they have variables of type ValidatorContext. This should happen very rarely though, as ValidatorContext typically is only used in chained method calls (with a final getValidator() invocation) but not assigned to a variable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
1
0 / 0

[Hibernate-JIRA] Created: (BVAL-222) Add a ALL group to validate all groups instead of DEFAULT or the selected ones

by Emmanuel Bernard (JIRA)

Add a ALL group to validate all groups instead of DEFAULT or the selected ones ------------------------------------------------------------------------------ Key: BVAL-222 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-222 Project: Bean Validation Issue Type: New Feature Components: spec-general Reporter: Emmanuel Bernard Gerhard #2 it would be nice to have #validateAll or a group called javax.validation.groups.All to validate all groups without knowing the concrete groups. Emmanuel What's the use case they were invoking? ( my favorite mantra :) ) Gerhard i think it was just: if you are using groups for partial validation you might have a wizard and in every step you validate with a different group and they needed the concept instead of collecting all groups manually (e.g. in the service which finally saves the new entry) -> they requested an api for validating every constraint which is available in the given object-graph -> the service can perform a full validation before it processes the data. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

1
2
0 / 0

[Hibernate-JIRA] Created: (HV-462) Allow ordered validator's annotations

by Pavla Nováková (JIRA)

Allow ordered validator's annotations ------------------------------------- Key: HV-462 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-462 Project: Hibernate Validator Issue Type: New Feature Affects Versions: 4.1.0.Final Reporter: Pavla Nováková 1) Consider domain object with simple constraints (just to demonstrate required feature, my real example uses custom cost-expensive validation of pictures): {code} public class DomainObject { @Size(max=50) // constraint 1a @Pattern(regexp="[a-z]*") // constraint 1b private String name; @Size(max=20) // constraint 2a @URL // constraint 2b private String email; @Size(max=100) // constraint 3a @Pattern(regexp="[0-9]*") // constraint 3b private String password; {code} 2) Consider validation requirements: * all properties should be validated together (like one virtual group) * FOR EACH PROPERTY validation should occur in ordered steps given by order of annotations for given property (if first validation step fails, SKIP following validation process on given property and add validation message specific to failed / last validated constraint for the property) 3) Why it is useful: * simple cost-effective validation followed by cost-expensive validation (not executed if simple constraint fails) * we get just the "main and specific validation error" (otherwise we have to iterate over all errors "to find the cause" or we display two or more errors for one property which is not user-friendly according my opinion) 3) What is unusable: * groups and group sequences (it is not possible to create proper combination of groups and sequences for more than one property with two or more constraints) * composed constraints (@ReportAsSingleViolation included) ** we cannot use @ReportAsSingleViolation since we want specific message for each failed constraint ** and main problem is: if we use composed constraints all constraints are evaluated for given property 4) Proposed solution: * add optional order attribute to validator annotations and stop validation on first failure if order is specified * possibly this can be configured on global validator level with property "skipOnFirstFailure" together with some given convention for annotation order Please let me know if need better explanation or working examples. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
8
0 / 0

[Hibernate-JIRA] Created: (HHH-3502) getIdentifierMethod of BasicLazyInitializer does not match if method invoked through an interface with different return type

by Sean Bridges (JIRA)

getIdentifierMethod of BasicLazyInitializer does not match if method invoked through an interface with different return type ---------------------------------------------------------------------------------------------------------------------------- Key: HHH-3502 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3502 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.3.1 Reporter: Sean Bridges Priority: Minor I have an entity interface, public interface IEntity { public Object getId(); } and I have an entity, say User that implements this interface with an id method @Id public Long getId() { return id; } I can call getId() on an uninitialized proxy with, user.getId() however, if I call getId() in this way, ((IEntity) user)).getId() I get org.hibernate.LazyInitializationException: could not initialize proxy - no Session Looking at the code, BasicLazyInitializer has these lines, else if ( isUninitialized() && method.equals(getIdentifierMethod) ) { return getIdentifier(); } the method.equals(getIdentifierMethod) returns false. The methods are not equal() because they have different return types (this is allowed in 1.5 with covariant return types). Hibernate should not use Method.equals(), but should instead use the code below (modified from Method.equals(Object)), public boolean equalsIgnoringReturnType(Method m1, Method m2) { if ((m1.getDeclaringClass() != m2.getDeclaringClass()) { return false; } if (m1.getName() != m2.getName()) { return false; } Class[] params1 = m1.getParameterTypes(); Class[] params2 = m2.getParameterTypes(); if (params1.length != params2.length) { return false; } for (int i = 0; i < params1.length; i++) { if (params1[i] != params2[i]) return false; } return true; } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
2
0 / 0

[Hibernate-JIRA] Created: (JPA-12) Cannot use { in string literal of native SQL query

by Neil Buesing (JIRA)

Cannot use { in string literal of native SQL query -------------------------------------------------- Key: JPA-12 URL: http://opensource.atlassian.com/projects/hibernate/browse/JPA-12 Project: Java Persistence API Issue Type: Bug Affects Versions: 1.0.0 Environment: Hibernate 3.3.2.GA_CP01, Oracle 10g, Windows 32bit, Java 1.6 Reporter: Neil Buesing a JPA Native query will throw an exception if a { is within a string literal. Rejected Hibernate Defect: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2744 Exception: Caused by: java.lang.IllegalArgumentException: org.hibernate.QueryException: Unmatched braces for alias path Query example (taken from HHH-2744) select count(distinct v.id) from some_table v left join other_table p on v.id = p.foreign_id where upper(v.last_name) like upper('{%'); No where do I find in the JPA specification that SQL queries can be limited; if the SQL is valid, it should be able to be parsed by the JPA Native Query support. I understand there is a work around, but it should be allowed. The {} balance check shouldn't count {} that are within string literals. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
3
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2011