April 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-3889) Exception Predicate targets unexpected fields when use nested() in sort filter

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3889 ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiYmI... ) Re: Exception Predicate targets unexpected fields when use nested() in sort filter ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiYmI... ) I know you can do that. But then you need to submit the filter for sorting and searching separately. The idea is to use the same filtering query and not worry about how to use it when sorting and searching differently. This is important for very complex filters, where it is necessary to use the nesting predicate once and in other cases it should not be used. PR should be able to adapt himself. Do not throw exceptions, require some complex actions. I know you can do that. But then you need to submit the filter for sorting and searching separately. The idea is to use the same filtering query and not worry about how to use it when sorting and searching differently. This is important for very complex filters, where it is necessary to use the nesting predicate once and in other cases it should not be used. PR should be able to adapt himself. Do not throw exceptions, require some complex actions. PermissionQuery allowQuery = new PermissionQuery( "prices.permissions" , operation, user, true ); filter = createComplexFilter(...); sort.add(sorter.field( "prices.bruttoPrice_sort" ) .asc() .mode(SortMode.MIN) .filter(filter)); SearchQuery<Assortment> query = session.search(scope) .where((f) -> f.bool().must(select) .filter(filter) .sort(sort.toSort()) .toQuery(); ..... public static SearchPredicate createComplexFilter(...) { PermissionQuery allowQuery = new PermissionQuery( "prices.prmissions" , "share" , user, true ); PermissionQuery dannyQuery = new PermissionQuery( "prices.prmissions" , "share" , user, false ); BooleanQuery query = new BooleanQuery.Builder() .add(allowQuery, BooleanClause.Occur.MUST) .add(dannyQuery, BooleanClause.Occur.MUST_NOT) .build(); SearchPredicate permfilter = predicate .nested().objectField( "prices" ) .nest(predicate .extension(LuceneExtension.get()) .fromLuceneQuery(query)) .toPredicate(); SearchPredicate activefilter = ctx.predicate() .match().field( "prices.active" ) .matching( true ) .toPredicate(); SearchPredicate filter = predicate.bool() .must(activefilter) .must(permfilter) .toPredicate(); return filter; } In this case it would not be possible. My patch makes it possible. Just when building a query, it decides by context how to build a filter. ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

5 years, 12 months

1
0
0 / 0

[JIRA] (HSEARCH-3889) Exception Predicate targets unexpected fields when use nested() in sort filter

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3889 ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiZWE... ) Re: Exception Predicate targets unexpected fields when use nested() in sort filter ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiZWE... ) I know you can do that. But then you need to submit the filter for sorting and searching separately. The idea is to use the same filtering query and not worry about how to use it when sorting and searching differently. This is important for very complex filters, where it is necessary to use the nesting predicate once and in other cases it should not be used. PR should be able to adapt himself. Do not throw exceptions, require some complex actions. PermissionQuery allowQuery = new PermissionQuery( "prices.permissions" , operation, user, true ); PermissionQuery dannyQuery = new PermissionQuery( "prices.permissions" , operation, user, false ); BooleanQuery query = new BooleanQuery.Builder() .add(allowQuery, BooleanClause.Occur.MUST) .add(dannyQuery, BooleanClause.Occur.MUST_NOT) .build(); filter = createComplexFilter(...); sort.add(sorter.field( "prices.bruttoPrice_sort" ) .asc() .mode(SortMode.MIN) .filter(filter)); SearchQuery<Assortment> query = session.search(scope) .where((f) -> f.bool().must(select) .filter(filter) .sort(sort.toSort()) .toQuery(); ..... public static SearchPredicate createComplexFilter(...) { PermissionQuery allowQuery = new PermissionQuery( "prices.prmissions" , "share" , user, true ); PermissionQuery dannyQuery = new PermissionQuery( "prices.prmissions" , "share" , user, false ); BooleanQuery query = new BooleanQuery.Builder() .add(allowQuery, BooleanClause.Occur.MUST) .add(dannyQuery, BooleanClause.Occur.MUST_NOT) .build(); SearchPredicate permfilter = predicate .nested().objectField( "prices" ) .nest(predicate .extension(LuceneExtension.get()) .fromLuceneQuery(query)) .toPredicate(); SearchPredicate activefilter = ctx.predicate() .match().field( "prices.active" ) .matching( true ) .toPredicate(); SearchPredicate filter = predicate.bool() .must(activefilter) .must(permfilter) .toPredicate(); return filter; } In this case it would not be possible. My patch makes it possible. Just when building a query, it decides by context how to build a filter. ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

5 years, 12 months

1
0
0 / 0

[JIRA] (HSEARCH-3892) Aggregations on fields in nested documents

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZGVkOGE0... ) / New Feature ( https://hibernate.atlassian.net/browse/HSEARCH-3892?atlOrigin=eyJpIjoiZGV... ) HSEARCH-3892 ( https://hibernate.atlassian.net/browse/HSEARCH-3892?atlOrigin=eyJpIjoiZGV... ) Aggregations on fields in nested documents ( https://hibernate.atlassian.net/browse/HSEARCH-3892?atlOrigin=eyJpIjoiZGV... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) We don't have tests for this, and some testing I did locally revealed it just doesn't work yet: * For Lucene text fields, aggregations on fields in nested documents always return empty results. * - For Lucene numeric fields, aggregations on fields in nested documents seem to ignore some values. - => Actually no, that was a bug in my code in HSEARCH-1929. Fixed it in HSEARCH-1929 as the PR was still pending review. * For Elasticsearch, aggregations on fields in nested documents always return empty results. ( https://hibernate.atlassian.net/browse/HSEARCH-3892#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3892#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

5 years, 12 months

1
0
0 / 0

[JIRA] (HHH-13937) Remove JUnit 5 as compile-time dependency

by Andrea Boriero (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HHH-13890) Add support for custom EventType and listeners

by Sanne Grinovero (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HHH-13682) Generate Java 13/14 bytecode for tests when building with JDK13/14

by Sanne Grinovero (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HHH-13682) Generate Java 13/14 bytecode for tests when building with JDK13/14

by Sanne Grinovero (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HHH-13682) Generate Java 13/14 bytecode for tests when building with JDK13/14

by Sanne Grinovero (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HBX-2016) Update version identifier to 5.4.14.Final

by Koen Aers (JIRA)

5 years, 12 months

1
0
0 / 0

[JIRA] (HSEARCH-1929) @Facet on multi value field breaks indexing (be it for discrete or range faceting)

by Yoann Rodière (JIRA)

5 years, 12 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues April 2020