April 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-3890) Upgrade to Hibernate ORM 5.4.14.Final

by Yoann Rodière (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HSEARCH-3890) Upgrade to Hibernate ORM 5.4.14.Final

by Yoann Rodière (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HBX-2015) Allow custom reverse engineering strategy to enrich table/column metaattributes provided by hibernate.reveng.xml

by Jordi Hernández (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HBX-2015) Allow custom reverse engineering strategy to enrich table/column metaattributes provided by hibernate.reveng.xml

by Jordi Hernández (JIRA)

Jordi Hernández ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Tools ( https://hibernate.atlassian.net/browse/HBX?atlOrigin=eyJpIjoiZGY3MWNiODdi... ) / Improvement ( https://hibernate.atlassian.net/browse/HBX-2015?atlOrigin=eyJpIjoiZGY3MWN... ) HBX-2015 ( https://hibernate.atlassian.net/browse/HBX-2015?atlOrigin=eyJpIjoiZGY3MWN... ) Allow custom reverse engineering strategy to enrich table/column metaattributes provided by hibernate.reveng.xml ( https://hibernate.atlassian.net/browse/HBX-2015?atlOrigin=eyJpIjoiZGY3MWN... ) Issue Type: Improvement Affects Versions: 5.4.12.Final Assignee: Koen Aers ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hbm2java, reverse-engineer Created: 12/Apr/2020 14:22 PM Priority: Minor Reporter: Jordi Hernández ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Currently, when a hibernate.reveng.xml is provided alongside an implementation of ReverseEngineeringStrategy there are some cases in which the latter is completely ignored, making it pointless to implement some of its methods. An instance of the OverrideRepository is created, which creates an internal implementation of a ReverseEngineeringStrategy (which, I notice, has recently been renamed to RevengStrategy). Now, this implementation will pick when to call or not the user provided implementation. In the case of the methods that generate MetaAttributes for tables and columns, the RevengStrategy implementation is bypassed altogether. This means that you cannot enrich this metadata for template specifics at the same time as you provide some configuration via hibernate.reveng.xml. I believe that metadata from the XML file and the reveng strategy implementation do not need to be exclusive, since after all metadata is put in a Map and therefore many different bits of information can be provided from each side. So the solution to this, which I implemented in a PR, is to call the reverse engineering implementation, grab whatever metadata is generated there, and merge it with the one coming from the xml mapping file. ( https://hibernate.atlassian.net/browse/HBX-2015#add-comment?atlOrigin=eyJ... ) Add Comment ( https://hibernate.atlassian.net/browse/HBX-2015#add-comment?atlOrigin=eyJ... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

4 years, 5 months

1
0
0 / 0

[JIRA] (BVAL-748) HBM2Java uses default plattform encoding for source generation

by Jordi Hernández (JIRA)

Jordi Hernández ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on BVAL-748 ( https://hibernate.atlassian.net/browse/BVAL-748?atlOrigin=eyJpIjoiMjkwZTk... ) Re: HBM2Java uses default plattform encoding for source generation ( https://hibernate.atlassian.net/browse/BVAL-748?atlOrigin=eyJpIjoiMjkwZTk... ) Sorry about this, I created the issue under the wrong project. I have created a new issue for this request where it belongs. Please delete/close this issue. My apologies. ( https://hibernate.atlassian.net/browse/BVAL-748#add-comment?atlOrigin=eyJ... ) Add Comment ( https://hibernate.atlassian.net/browse/BVAL-748#add-comment?atlOrigin=eyJ... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

4 years, 5 months

1
0
0 / 0

[JIRA] (HBX-2014) HBM2Java uses default plattform encoding for source generation

by Jordi Hernández (JIRA)

4 years, 5 months

1
0
0 / 0

[JIRA] (HBX-2014) HBM2Java uses default plattform encoding for source generation

by Jordi Hernández (JIRA)

Jordi Hernández ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Tools ( https://hibernate.atlassian.net/browse/HBX?atlOrigin=eyJpIjoiMzQzNDdiNGYw... ) / Improvement ( https://hibernate.atlassian.net/browse/HBX-2014?atlOrigin=eyJpIjoiMzQzNDd... ) HBX-2014 ( https://hibernate.atlassian.net/browse/HBX-2014?atlOrigin=eyJpIjoiMzQzNDd... ) HBM2Java uses default plattform encoding for source generation ( https://hibernate.atlassian.net/browse/HBX-2014?atlOrigin=eyJpIjoiMzQzNDd... ) Issue Type: Improvement Affects Versions: 5.4.13.Final Assignee: Koen Aers ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hbm2java Created: 12/Apr/2020 13:08 PM Priority: Minor Reporter: Jordi Hernández ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I am using hbm2java via Maven integration in a project where we are doing database first development. I have used a custom ReverseEngineeringStrategy in order to import the comments from tables and fields into the generated classes. The project language is spanish, so usually the comments in the database will contain characters with accents (á, é, í…) etc. When the code is generated, it will produce errors because the files have the wrong encoding and these characters are mangled. I took a look at the hbm2x sources and turns out that the code that does the actual writing of the files looks as follows (in the class org.hibernate.tool.hbm2x.TemplateProducer) : fileWriter = new FileWriter(destination); fileWriter.write(tempResult); The ‘destination’ variable is a File reference, and tempResult is the templates output. Well, turns out that with this code, java will write the file using the default plattform encoding, which in my case, being a Windows user, will end up being CP-1512. So, for international character codes support I think this code should at least write UTF-8, or even better, let the user select the encoding. ( https://hibernate.atlassian.net/browse/HBX-2014#add-comment?atlOrigin=eyJ... ) Add Comment ( https://hibernate.atlassian.net/browse/HBX-2014#add-comment?atlOrigin=eyJ... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

4 years, 5 months

1
0
0 / 0

[JIRA] (HSEARCH-3889) Exception Predicate targets unexpected fields when use nested() in sort filter

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3889 ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiMGQ... ) Re: Exception Predicate targets unexpected fields when use nested() in sort filter ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiMGQ... ) This has to do with the "AbstractLuceneNestablePredicateBuilder.checkNestableWithin" function. For nested queries for which nesting is the same as the nesting value, this check should not be performed. Check only when required. To fix this error is to swap "#checkNestableWithin" in the "#build" function. diff --git a/backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java b/backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java index d6624fa..f502e67 100644 --- a/backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java +++ b/backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/predicate/impl/AbstractLuceneNestablePredicateBuilder.java @@ -33,8 +33,6 @@ @Override public final Query build(LuceneSearchPredicateContext context) { - checkNestableWithin( context.getNestedPath() ); - List<String> nestedPathHierarchy = getNestedPathHierarchy(); String expectedNestedPath = nestedPathHierarchy.isEmpty() ? null : nestedPathHierarchy.get( nestedPathHierarchy.size() - 1 ); @@ -44,6 +42,8 @@ return super.build( context ); } + checkNestableWithin( context.getNestedPath() ); + // The context we expect this predicate to be built in. // We'll make sure to wrap it in nested predicates as appropriate in the next few lines, // so that the Query is actually executed in this context. ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

4 years, 5 months

1
0
0 / 0

[JIRA] (HSEARCH-3889) Exception Predicate targets unexpected fields when use nested() in sort filter

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiYzYwYzZi... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiYzY... ) HSEARCH-3889 ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiYzY... ) Exception Predicate targets unexpected fields when use nested() in sort filter ( https://hibernate.atlassian.net/browse/HSEARCH-3889?atlOrigin=eyJpIjoiYzY... ) Issue Type: Improvement Affects Versions: 6.0.0.Beta6 Assignee: Unassigned Components: backend-lucene Created: 11/Apr/2020 14:20 PM Priority: Major Reporter: Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) When use: PermissionQuery allowQuery = new PermissionQuery( "prices.permissions" , operation, user, true ); PermissionQuery dannyQuery = new PermissionQuery( "prices.permissions" , operation, user, false ); BooleanQuery query = new BooleanQuery.Builder() .add(allowQuery, BooleanClause.Occur.MUST) .add(dannyQuery, BooleanClause.Occur.MUST_NOT) .build(); filter = predicate.nested().objectField( "prices" ) .nest(f -> f.extension(LuceneExtension.get()).fromLuceneQuery(query)) .toPredicate(); sort.add(sorter.field( "prices.bruttoPrice_sort" ) .asc() .mode(SortMode.MIN) .filter(filter)); SearchQuery<Assortment> query = session.search(scope) .where((f) -> f.bool().must(select) .filter(filter)) .sort(sort.toSort()) .toQuery(); An exception was thrown: Caused by: org.hibernate.search.util.common.SearchException: HSEARCH600121: Predicate targets unexpected fields [prices]. Only fields that are contained in the nested object with path 'prices' are allowed here. at org.hibernate.search.backend-lucene(a)6.0.0-SNAPSHOT //org.hibernate.search.backend.lucene.search.predicate.impl.AbstractLuceneNestablePredicateBuilder.checkNestableWithin(AbstractLuceneNestablePredicateBuilder.java:27) at org.hibernate.search.backend-lucene(a)6.0.0-SNAPSHOT //org.hibernate.search.backend.lucene.search.predicate.impl.AbstractLuceneSingleFieldPredicateBuilder.checkNestableWithin(AbstractLuceneSingleFieldPredicateBuilder.java:12) at org.hibernate.search.backend-lucene(a)6.0.0-SNAPSHOT //org.hibernate.search.backend.lucene.search.predicate.impl.AbstractLuceneNestablePredicateBuilder.build(AbstractLuceneNestablePredicateBuilder.java:36) at org.hibernate.search.backend-lucene(a)6.0.0-SNAPSHOT //org.hibernate.search.backend.lucene.search.predicate.impl.LuceneSearchPredicate.build(LuceneSearchPredicate.java:32) at org.hibernate.search.backend-lucene(a)6.0.0-SNAPSHOT //org.hibernate.search.backend.lucene.search.predicate.impl.LuceneFilterPredicateBuilder.doBuild(LuceneFilterPredicateBuilder.java:68) ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100124- sha1:185bad4 )

4 years, 5 months

1
0
0 / 0

[JIRA] (BVAL-748) HBM2Java uses default plattform encoding for source generation

by Jordi Hernández (JIRA)

4 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues April 2020