November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15728) Consider parameter values in QueryKey hashCode but disregard firstResult/maxResults

by Christian Beikov (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15719) Hint UniqueSematics.NONE for entity queries without collection join fetches

by Christian Beikov (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15719) Hint UniqueSematics.NONE for entity queries without collection join fetches

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjRmMTM3YTA2... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15719?atlOrigin=eyJpIjoiNjRmMT... ) HHH-15719 ( https://hibernate.atlassian.net/browse/HHH-15719?atlOrigin=eyJpIjoiNjRmMT... ) Hint UniqueSematics.NONE for entity queries without collection join fetches ( https://hibernate.atlassian.net/browse/HHH-15719?atlOrigin=eyJpIjoiNjRmMT... ) Change By: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In the constructor of {{org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan}} we currently always choose {{ListResultsConsumer.UniqueSemantic.ALLOW}}, but it would be better to use this instead: { noformat {NONE } sqm } if we know for sure that the cardinality is preserved. containsCollectionFetches() ? ListResultsConsumer.UniqueSemantic.ALLOW : ListResultsConsumer.UniqueSemantic.NONE{noformat} The deduplication showed up on some flame graphs and I realized that in that particular case it is not even necessary, because only collection join fetches alter the cardinality such that duplicates are possible. Maybe non-attribute joins could alter the cardinality as well, so it might be worth being pessimistic about this for now. We could detect some non-cardinality altering cases though if we want. ( https://hibernate.atlassian.net/browse/HHH-15719#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15719#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15728) Consider parameter values in QueryKey hashCode but disregard firstResult/maxResults

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOWMwNjdiZGY5... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) HHH-15728 ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) Consider parameter values in QueryKey hashCode but disregard firstResult/maxResults ( https://hibernate.atlassian.net/browse/HHH-15728?atlOrigin=eyJpIjoiOWMwNj... ) Issue Type: Improvement Affects Versions: 6.1.5 Assignee: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 16/Nov/2022 02:03 AM Fix Versions: 6.1.6 Priority: Major Reporter: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) In flame graphs we saw that not considering the parameter values of a query in the QueryKey#hashCode will lead to many hash collisions. It doesn’t seem to be very useful to include the firstResult / maxResults though IMO, as such queries probably aren’t cached often. Experiments with SpecJ showed that this improve performance and eliminate collisions in the benchmark scenario. ( https://hibernate.atlassian.net/browse/HHH-15728#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15728#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15727) Regression: 'replace" function on property of enum type results in type mismatch

by Emond Papegaaij (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Emond Papegaaij (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15727) Regression: 'replace" function on property of enum type results in type mismatch

by Emond Papegaaij (JIRA)

Emond Papegaaij ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNGQ4Y2VmN2Nh... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15727?atlOrigin=eyJpIjoiNGQ4Y2... ) HHH-15727 ( https://hibernate.atlassian.net/browse/HHH-15727?atlOrigin=eyJpIjoiNGQ4Y2... ) Regression: 'replace" function on property of enum type results in type mismatch ( https://hibernate.atlassian.net/browse/HHH-15727?atlOrigin=eyJpIjoiNGQ4Y2... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Created: 16/Nov/2022 01:18 AM Priority: Major Reporter: Emond Papegaaij ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) While working on the upgrade to WildFly 27, we ran into the issue below. The case runs fine on Hibernate ORM 5.6.14 and 5.3.28 (on WildFly 26.1.2). An enum property mapped with @Enumerated(EnumType.STRING) , cannot be used in the replace function, because it expects a STRING. As the property is mapped with EnumType.STRING, I would expect this to work (as it did in older versions of Hibernate ORM). org.hibernate.QueryException: Parameter 1 of function replace() has type STRING, but argument is of type org.hibernate.bugs.entities.MyEnum at org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.throwError(ArgumentTypesValidator.java:214) at org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.checkType(ArgumentTypesValidator.java:169) at org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.validate(ArgumentTypesValidator.java:74) at org.hibernate.query.sqm.function.AbstractSqmFunctionDescriptor.generateSqmExpression(AbstractSqmFunctionDescriptor.java:104) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.function(SqmCriteriaNodeBuilder.java:1493) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.function(SqmCriteriaNodeBuilder.java:153) at org.hibernate.bugs.JPAUnitTestCase.hhh15727Test(JPAUnitTestCase.java:44) ( https://hibernate.atlassian.net/browse/HHH-15727#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15727#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Christian Beikov (JIRA)

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15726 ( https://hibernate.atlassian.net/browse/HHH-15726?atlOrigin=eyJpIjoiM2FlOG... ) Re: Disjunction with treat results in too restrictive query ( https://hibernate.atlassian.net/browse/HHH-15726?atlOrigin=eyJpIjoiM2FlOG... ) Thanks for the reproducer. Note for myself, the usage of PAccountDirectory through the path root.active should actually trigger that the subtype pruning optimization is disabled. ( https://hibernate.atlassian.net/browse/HHH-15726#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15726#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )

1 year, 11 months

1
0
0 / 0

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Christian Beikov (JIRA)

1 year, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022