November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Emond Papegaaij (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15726) Disjunction with treat results in too restrictive query

by Emond Papegaaij (JIRA)

Emond Papegaaij ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMWMwNDY3MWFi... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15726?atlOrigin=eyJpIjoiMWMwND... ) HHH-15726 ( https://hibernate.atlassian.net/browse/HHH-15726?atlOrigin=eyJpIjoiMWMwND... ) Disjunction with treat results in too restrictive query ( https://hibernate.atlassian.net/browse/HHH-15726?atlOrigin=eyJpIjoiMWMwND... ) Issue Type: Bug Affects Versions: 5.3.28, 6.1.5, 5.6.14 Assignee: Unassigned Components: hibernate-core Created: 16/Nov/2022 01:05 AM Priority: Major Reporter: Emond Papegaaij ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) When selecting on a disjunction of a property in a base class and a property in a subclass (treat), the restriction on the dtype is placed incorrectly causing on the matches of the subclass to be returned. Similar behavior was already present in older versions of Hibernate ORM (tested in 5.3.28 and 5.6.14), however it seems 6.1.5 is more consistent in rendering the incorrect restriction, which causes queries in our application to miss results. In 5.3.28 these queries did return results because the dtype restriction was missing entirely (which also is incorrect). In the example of a query rendered by 6.1.5 below, it is clear that this can only return records of type PLDAPDirectory: select p1_0.id, p1_0.DTYPE, p1_0.active, p1_0.openldap from ( select * from PAccountDirectory t where t.DTYPE= 'PLDAPDirectory' ) p1_0 where p1_0.active=? or case when p1_0.DTYPE= 'PLDAPDirectory' then p1_0.openldap else null end =? Corresponding Java code: CriteriaBuilder cb = entityManager.getCriteriaBuilder(); CriteriaQuery<PAccountDirectory> query = cb.createQuery(PAccountDirectory.class); Root<PAccountDirectory> root = query.from(PAccountDirectory.class); From<?, PLDAPDirectory> ldap = cb.treat(root, PLDAPDirectory.class); Predicate exp = cb.or(cb.equal(root.get( "active" ), true ), cb.equal(ldap.get( "openldap" ), true )); entityManager.createQuery(query.select(root).where(exp)).getResultList(); ( https://hibernate.atlassian.net/browse/HHH-15726#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15726#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15724) Upgrade to Jandex 3.0.3

by Sanne Grinovero (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15725) Criteria API Expression.as adds cast to sql string negatively affecting performance

by Hernan (JIRA)

Hernan ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=62fba63... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZWZhNjk2NDcz... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15725?atlOrigin=eyJpIjoiZWZhNj... ) HHH-15725 ( https://hibernate.atlassian.net/browse/HHH-15725?atlOrigin=eyJpIjoiZWZhNj... ) Criteria API Expression.as adds cast to sql string negatively affecting performance ( https://hibernate.atlassian.net/browse/HHH-15725?atlOrigin=eyJpIjoiZWZhNj... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Components: hibernate-core Created: 15/Nov/2022 11:34 AM Environment: Hibernate ORM core version 6.1.5.Final, openjdk version "11" 2018-09-25, Ubuntu 20.04.4 LTS, SQL Server 2008 R2 (SP3) Priority: Major Reporter: Hernan ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=62fba63... ) When calling method jakarta.persistence.criteria.Expression.as ( http://jakarta.persistence.criteria.Expression.as ) , in all cases, the code is adding "cast" to predicate even if the expression type is the same as the resulting type This affect negatively the query performance as the resulting query plan is not using indexes in the correct way As an example, using SQLServer2005Dialect, a simple string “equals” predicate on field named "empresa" with sql type char(4) results in: cast(a1_0.empresa as varchar(max))=? as this field is part of the primary key the resulting query plan performs a scan over the associated clustered index instead of a seek. The code is located in the class org.hibernate.query.sqm.tree.expression.AbstractSqmExpression : public <X> SqmExpression<X> as(Class<X> type) { return nodeBuilder().cast(this, type); } and then org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder : public <X, T> SqmExpression<X> cast(JpaExpression<T> expression, Class<X> castTargetJavaType) { final BasicDomainType<X> type = getTypeConfiguration().standardBasicTypeForJavaType( castTargetJavaType ); return getFunctionDescriptor( "cast" ).generateSqmExpression( asList( (SqmTypedNode<?>) expression, new SqmCastTarget<>( type, this ) ), type, queryEngine, getJpaMetamodel().getTypeConfiguration() ); } Equivalent code in HB 5.0.12 (org.hibernate.jpa.criteria.expression.ExpressionImpl) first evaluates types, and only adds cast when needed: public <X> Expression<X> as(Class<X> type) { return type.equals( getJavaType() ) ? (Expression<X>) this : new CastFunction<X, T>( criteriaBuilder(), type, this ); } But also from JPA documentation I undestand that even on different types the cast must not be done (from https://jakarta.ee/specifications/persistence/3.1/apidocs/jakarta.persist... ( https://jakarta.ee/specifications/persistence/3.1/apidocs/jakarta.persist... ) ) " Perform a typecast upon the expression, returning a new expression object. This method *does not cause type conversion: the runtime type is not changed*. Warning: may result in a runtime failure. " Thanks in advance ( https://hibernate.atlassian.net/browse/HHH-15725#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15725#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:28a3636 )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15724) Upgrade to Jandex 3.0.3

by Sanne Grinovero (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15720) Using multiple select in a multiselect generates java.lang.ArrayIndexOutOfBoundsException

by Florent Marquier (JIRA)

Florent Marquier ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6373676... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmNmZDQ3YmJj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15720?atlOrigin=eyJpIjoiYmNmZD... ) HHH-15720 ( https://hibernate.atlassian.net/browse/HHH-15720?atlOrigin=eyJpIjoiYmNmZD... ) Using multiple select in a multiselect generates java.lang.ArrayIndexOutOfBoundsException ( https://hibernate.atlassian.net/browse/HHH-15720?atlOrigin=eyJpIjoiYmNmZD... ) Change By: Florent Marquier ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6373676... ) Using any kind of entity this test will fail with java.lang.ArrayIndexOutOfBoundsException. Full stack: {code:java} java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1 at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter$SqmAliasedNodePositionTracker.resolveSqlSelection(BaseSqmToSqlAstConverter.java:7356) at org.hibernate.metamodel.mapping.internal.BasicEntityIdentifierMappingImpl.resolveSqlSelection(BasicEntityIdentifierMappingImpl.java:275) at org.hibernate.metamodel.mapping.internal.BasicEntityIdentifierMappingImpl.createDomainResult(BasicEntityIdentifierMappingImpl.java:207) at org.hibernate.query.sqm.sql.internal.AbstractSqmPathInterpretation.createDomainResult(AbstractSqmPathInterpretation.java:55) at org.hibernate.sql.results.graph.instantiation.internal.DynamicInstantiationArgument.buildArgumentDomainResult(DynamicInstantiationArgument.java:37) at org.hibernate.sql.results.graph.instantiation.internal.DynamicInstantiation.lambda$createDomainResult$0(DynamicInstantiation.java:106) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) at org.hibernate.sql.results.graph.instantiation.internal.DynamicInstantiation.createDomainResult(DynamicInstantiation.java:107) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.lambda$visitSelection$25(BaseSqmToSqlAstConverter.java:2063) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitSelection(BaseSqmToSqlAstConverter.java:2058) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitSelectClause(BaseSqmToSqlAstConverter.java:1961) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitQuerySpec(BaseSqmToSqlAstConverter.java:1829) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitQuerySpec(BaseSqmToSqlAstConverter.java:414) at org.hibernate.query.sqm.tree.select.SqmQuerySpec.accept(SqmQuerySpec.java:122) at org.hibernate.query.sqm.spi.BaseSemanticQueryWalker.visitQueryPart(BaseSemanticQueryWalker.java:213) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitQueryPart(BaseSqmToSqlAstConverter.java:1689) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitSelectStatement(BaseSqmToSqlAstConverter.java:1487) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.visitSelectStatement(BaseSqmToSqlAstConverter.java:414) at org.hibernate.query.sqm.tree.select.SqmSelectStatement.accept(SqmSelectStatement.java:199) at org.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter.translate(BaseSqmToSqlAstConverter.java:709) at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.buildCacheableSqmInterpretation(ConcreteSqmSelectQueryPlan.java:350) at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.withCacheableSqmInterpretation(ConcreteSqmSelectQueryPlan.java:270) at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.performList(ConcreteSqmSelectQueryPlan.java:246) at org.hibernate.query.sqm.internal.QuerySqmImpl.doList(QuerySqmImpl.java:546) at org.hibernate.query.spi.AbstractSelectionQuery.list(AbstractSelectionQuery.java:363) at org.hibernate.query.sqm.internal.QuerySqmImpl.list(QuerySqmImpl.java:1032) at org.hibernate.query.Query.getResultList(Query.java:94) at com.iterop.bpm.engine.impl.HibernateBug.testFail2ParamsOrder(HibernateBug.java:57) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38) at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) {code} I tried to reduce reproduce with minimum code: {code:java} public class HibernateBug { record R1(String a) { } record R2(String a, String b) { } @Test public void testWorks1ParamOrder() { try (EntityManagerFactory emf = RepositoryUtil.createEntityManagerFactory()) { try (EntityManager em = emf.createEntityManager()) { CriteriaBuilder criteriaBuilder = em.getCriteriaBuilder(); CriteriaQuery<Tuple> critQuery = criteriaBuilder.createTupleQuery(); Root<TaskEntity> root = critQuery.from(TaskEntity.class); critQuery.multiselect(criteriaBuilder.construct(R1.class, root.get("id"))); critQuery.orderBy(criteriaBuilder.asc(root.get("id"))); em.createQuery(critQuery).getResultList(); } } } @Test public void testWorks2ParamsNoOrder() { try (EntityManagerFactory emf = RepositoryUtil.createEntityManagerFactory()) { try (EntityManager em = emf.createEntityManager()) { CriteriaBuilder criteriaBuilder = em.getCriteriaBuilder(); CriteriaQuery<Tuple> critQuery = criteriaBuilder.createTupleQuery(); Root<TaskEntity> root = critQuery.from(TaskEntity.class); critQuery.multiselect(criteriaBuilder.construct(R2.class, root.get("id"), root.get("id"))); em.createQuery(critQuery).getResultList(); } } } @Test public void testFail2ParamsOrder() { try (EntityManagerFactory emf = RepositoryUtil.createEntityManagerFactory()) { try (EntityManager em = emf.createEntityManager()) { CriteriaBuilder criteriaBuilder = em.getCriteriaBuilder(); CriteriaQuery<Tuple> critQuery = criteriaBuilder.createTupleQuery(); Root<TaskEntity> root = critQuery.from(TaskEntity.class); critQuery.multiselect(criteriaBuilder.construct(R2.class, root.get("id"), root.get("id"))); critQuery.orderBy(criteriaBuilder.asc(root.get("id"))); em.createQuery(critQuery).getResultList(); } } } } {code} ( https://hibernate.atlassian.net/browse/HHH-15720#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15720#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:28a3636 )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15694) Regression: HibernateException: Unable to resolve property xyz on ManyToOne with BatchSize

by Andrea Boriero (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HSEARCH-4748) Use UUID for outbox-polling agent IDs

by Marko Bekhta (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HSEARCH-4750) Fix a flaky test for BatchExecutor

by Marko Bekhta (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HSEARCH-4749) MSSQL cannot acuire locks properly on outbox event table

by Marko Bekhta (JIRA)

1 year, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022