May 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiMDdiZT... ) Re: Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiMDdiZT... ) The reasoning behind this change is just common sense. You can’t compare an entity expression with e.g. an integer because these types are simply not comparable. In Java, you also can’t write entity == 1 , because how would Java do the comparison? We just apply the same strictness in HQL/Criteria. As unfortunate as this may sound, but you’ll simply have to fix your code. ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Alexander B (JIRA)

Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) *commented* on HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiYjg3ZW... ) Re: Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiYjg3ZW... ) Thank you for the quick answer. So if I understand it correctly, this was never supposed to work in Hibernate 6 but until 6.2 it worked (magically ) and now it was fixed so that it’s compliant. Sadly, the migration guide ( https://github.com/hibernate/hibernate-orm/blob/6.0/migration-guide.adoc#... ) doesn’t state why it was changed and I also couldn’t find why it was changed when searching after it. Is this documented somewhere, why it was actually changed? A link to an issue/discussion somewhere would be great 🙂 ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16676) SqmQuerySpec#toHqlString doesn't handle treat expressions

by Christian Beikov (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16675) Reenable native query OffsetDateTime test after Oracle JDBC update

by Christian Beikov (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16443) Convert SqlStatementLogger into a Service

by Sanne Grinovero (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16443) Convert SqlStatementLogger into a Service

by Sanne Grinovero (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiZWE4OG... ) Re: Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiZWE4OG... ) Hi Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) , as specified in the migration guide ( https://github.com/hibernate/hibernate-orm/blob/6.0/migration-guide.adoc#... ) it is not anymore allowed to compare an entity path {{ root.get(UserAuthLog_.user)}} against a literal userId. ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Alexander B (JIRA)

Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZGY0MWM0NDVl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiZGY0MW... ) HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiZGY0MW... ) Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiZGY0MW... ) Change By: Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) Before Version 6.2 it was possible to just write the primary key (mostly a {{long}}) of the type referenced in CriteriaBuilder's {{equal}}, {{in}}, ...-Methods. Since Version 6.2 this no longer works. This is mentioned in the [https://docs.jboss.org/hibernate/orm/6.2/migration-guide/migration-guide....] however I assume that the Primary Keys have been overlooked. e.g. the following Code fails {code:java}... final CriteriaBuilder cb = this.getEntityManager().getCriteriaBuilder(); final CriteriaQuery<UserAuthLog> cq = cb.createQuery(UserAuthLog.class); final Root<UserAuthLog> root = cq.from(UserAuthLog.class); cq.select(root); // Problem here cq.where(cb.equal(root.get(UserAuthLog_.user), userId)); ...{code} where the class {{UserAuthLog}} looks like this: {noformat} ... @NotNull @ManyToOne(fetch = FetchType.EAGER) @JoinColumn( name = "user_id", foreignKey = @jakarta.persistence.ForeignKey(value = ConstraintMode.CONSTRAINT) ) private UserDetail user; ...{noformat} and {{UserDetail}} like this {code:java}public class UserDetail { ... @Id @GeneratedValue(strategy = IDENTITY) @Column(name = "id", unique = true, nullable = false) private long id; ...{code} with the following exception {code:java}Caused by: java.lang.IllegalArgumentException: Can't compare test expression of type [UserDetail] with element of type [basicType(a)1228(java.lang.Long,-5)] at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.assertComparable(SqmCriteriaNodeBuilder.java:2098) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:2121) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:182) at XXX.getUserLoginLogs(XXX.java:39) ...{code} Also consider that some methods like {{in}} use collections with primary keys. The changes were done here: [https://github.com/hibernate/hibernate-orm/pull/6189|https://github.com/h... [https://hibernate.atlassian.net/browse/HHH-15802|https://hibernate.atlass...] If this can’t be fixed it would be great if we could somehow disable this early query path comparison, so that we don’t have to check our entire DAL-Layer (we are talking about thousands of lines of code) for problems. ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Alexander B (JIRA)

Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMmViYjJiMjZi... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiMmViYj... ) HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiMmViYj... ) Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiMmViYj... ) Change By: Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) Before Version 6.2 it was possible to just write the primary key (mostly a {{long}}) of the type referenced in CriteriaBuilder's {{equal}}, {{in}}, ...-Methods. Since Version 6.2 this no longer works. This is mentioned in the [https://docs.jboss.org/hibernate/orm/6.2/migration-guide/migration-guide....] however I assume that the Primary Keys have been overlooked. e.g. the following Code fails {code:java}... final CriteriaBuilder cb = this.getEntityManager().getCriteriaBuilder(); final CriteriaQuery<UserAuthLog> cq = cb.createQuery(UserAuthLog.class); final Root<UserAuthLog> root = cq.from(UserAuthLog.class); cq.select(root); // Problem here cq.where(cb.equal(root.get(UserAuthLog_.user), userId)); ...{code} where the class {{UserAuthLog}} looks like this: {noformat} ... @NotNull @ManyToOne(fetch = FetchType.EAGER) @JoinColumn( name = "user_id", foreignKey = @jakarta.persistence.ForeignKey(value = ConstraintMode.CONSTRAINT) ) private UserDetail user; ...{noformat} and {{UserDetail}} like this { noformat code:java }public class UserDetail { ... @Id @GeneratedValue(strategy = IDENTITY) @Column(name = "id", unique = true, nullable = false) private long id; ...{ noformat code } with the following exception { noformat code:java }Caused by: java.lang.IllegalArgumentException: Can't compare test expression of type [UserDetail] with element of type [basicType(a)1228(java.lang.Long,-5)] at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.assertComparable(SqmCriteriaNodeBuilder.java:2098) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:2121) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:182) at XXX.getUserLoginLogs(XXX.java:39) ...{ noformat code } Also consider that some methods like {{in}} use collections with primary keys. The changes were done here: [https://github.com/hibernate/hibernate-orm/pull/6189|https://github.com/h... [https://hibernate.atlassian.net/browse/HHH-15802|https://hibernate.atlass...] If this can’t be fixed it would be great if could somehow disable this early query path comparison, so that we don’t have to check our entire DAL-Layer (we are talking about thousands of lines of code) for problems. ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-16674) Query Path comparison not working for primary keys

by Alexander B (JIRA)

Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDBlOTdmYjQ4... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiNDBlOT... ) HHH-16674 ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiNDBlOT... ) Query Path comparison not working for primary keys ( https://hibernate.atlassian.net/browse/HHH-16674?atlOrigin=eyJpIjoiNDBlOT... ) Issue Type: Bug Assignee: Unassigned Components: hibernate-core Created: 23/May/2023 02:31 AM Environment: Spring Boot 3.1.0 Hibernate Core 6.2.2.Final Java 17 Temurin OS independent MySQL/MariaDB Priority: Major Reporter: Alexander B ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5be2b57... ) Before Version 6.2 it was possible to just write the primary key (mostly a long ) of the type referenced in CriteriaBuilder's equal , in , ...-Methods. Since Version 6.2 this no longer works. This is mentioned in the https://docs.jboss.org/hibernate/orm/6.2/migration-guide/migration-guide.... however I assume that the Primary Keys have been overlooked. e.g. the following Code fails ... final CriteriaBuilder cb = this.getEntityManager().getCriteriaBuilder(); final CriteriaQuery<UserAuthLog> cq = cb.createQuery(UserAuthLog.class); final Root<UserAuthLog> root = cq.from(UserAuthLog.class); cq.select(root); // Problem here cq.where(cb.equal(root.get(UserAuthLog_.user), userId)); ... where the class UserAuthLog looks like this: ... @NotNull @ManyToOne(fetch = FetchType.EAGER) @JoinColumn( name = "user_id", foreignKey = @jakarta.persistence.ForeignKey(value = ConstraintMode.CONSTRAINT) ) private UserDetail user; ... and UserDetail like this public class UserDetail { ... @Id @GeneratedValue(strategy = IDENTITY) @Column(name = "id", unique = true, nullable = false) private long id; ... with the following exception Caused by: java.lang.IllegalArgumentException: Can't compare test expression of type [UserDetail] with element of type [basicType(a)1228(java.lang.Long,-5)] at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.assertComparable(SqmCriteriaNodeBuilder.java:2098) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:2121) at org.hibernate.query.sqm.internal.SqmCriteriaNodeBuilder.equal(SqmCriteriaNodeBuilder.java:182) at XXX.getUserLoginLogs(XXX.java:39) ... Also consider that some methods like in use collections with primary keys. The changes were done here: https://github.com/hibernate/hibernate-orm/pull/6189 / https://hibernate.atlassian.net/browse/HHH-15802 If this can’t be fixed it would be great if could somehow disable this early query path comparison, so that we don’t have to check our entire DAL-Layer (we are talking about thousands of lines of code) for problems. ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16674#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:bbd69a1 )

1 year, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues May 2023