July 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15661) ClassCastException in Select

by Christian Beikov (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17002) Query plan caching for CriteriaQuery based on query structure

by Christian Beikov (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17002) Query plan caching for CriteriaQuery based on query structure

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMTMzOWViMjU3... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-17002?atlOrigin=eyJpIjoiMTMzOW... ) HHH-17002 ( https://hibernate.atlassian.net/browse/HHH-17002?atlOrigin=eyJpIjoiMTMzOW... ) Query plan caching for CriteriaQuery based on query structure ( https://hibernate.atlassian.net/browse/HHH-17002?atlOrigin=eyJpIjoiMTMzOW... ) Issue Type: Improvement Assignee: Unassigned Created: 26/Jul/2023 10:22 AM Fix Versions: 6.wishlist Priority: Major Reporter: Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Introduce a way to cache query plans for CriteriaQuery based on the query structure. One way to do that would be to generate HQL with stable aliases and use that as cache key. Another way could be to implement hashing and equality based on the query structure. ( https://hibernate.atlassian.net/browse/HHH-17002#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17002#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17000) Do not keep static references to log levels

by James Perkins (JIRA)

James Perkins ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17000 ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiYzA1ZT... ) Re: Do not keep static references to log levels ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiYzA1ZT... ) I’m not sure what we could do to make levels immutable really. The JBoss Log Manager is an extension of JUL so we’re tied to that. I can see arguments for using debug/trace levels at runtime. For example if they are seeing an issue they can’t explain, likely happening at random times, it could be useful to enable trace logging at runtime as restarting the JVM may cause the issue to go away. ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-15378) Don't *always* Use JDBC bind variables for handling JPA Criteria query literals (or not)

by Christian Beikov (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17000) Do not keep static references to log levels

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17000 ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiYjcwYT... ) Re: Do not keep static references to log levels ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiYjcwYT... ) James Perkins ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I’m aware that all Loggers work like this, yet I wonder if we could do better. Regarding WildFly.. I don’t expect users to reboot, but I also don't expect them to need the lowest level (trace), which we use exclusively for complex debugging cases - as mentioned, the alternative is that we strip them out. But yes this is just my general answer about “the pattern”, we certainly do want users to be able to log binding parameters - that shouldn’t be done in that case. ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17000) Do not keep static references to log levels

by James Perkins (JIRA)

James Perkins ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17000 ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiZDMxYz... ) Re: Do not keep static references to log levels ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiZDMxYz... ) I’m not sure how we could support an immutable level in the JBoss Log Manager. That’s how, to my knowledge, all log managers work. They allow levels to be changed at runtime. By keeping a static final reference, that makes it a requirement to restart the JVM if you want to see messages at that level logged. This would be an issue for any app that allows for log level changes, not just WildFly. However, this definitely affects WildFly as changing a log level shouldn’t really require restarting the server. ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17001) An "on"-clause referencing the affected join node causes a StackOverflowException

by ortwin.escher (JIRA)

ortwin.escher ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e89d19... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYzMxYmQ1MGEw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-17001?atlOrigin=eyJpIjoiYzMxYm... ) HHH-17001 ( https://hibernate.atlassian.net/browse/HHH-17001?atlOrigin=eyJpIjoiYzMxYm... ) An "on"-clause referencing the affected join node causes a StackOverflowException ( https://hibernate.atlassian.net/browse/HHH-17001?atlOrigin=eyJpIjoiYzMxYm... ) Issue Type: Bug Affects Versions: 6.3.0.CR1 Assignee: Unassigned Attachments: hibernate-stackoverflowerror.zip Components: query-criteria Created: 26/Jul/2023 09:13 AM Priority: Major Reporter: ortwin.escher ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e89d19... ) When referencing a join node in an “on”-clause the lookup of the join node causes a StackOverflowError. This worked in Hibernate 5 and blocks us from migrating to Hibernate 6. A reproducer project is attached. I adapted the reproducer of https://hibernate.atlassian.net/browse/HHH-16968 to demonstrate the problem. Example Stacktrace excerpt: at org.hibernate.query.sqm.SemanticQueryWalker.visitSetJoin(SemanticQueryWalker.java:211) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.domain.SqmSetJoin.accept(SqmSetJoin.java:85) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.lambda$visitComparisonPredicate$14(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.withTypeInference(ParameterCollector.java:147) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.visitComparisonPredicate(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.predicate.SqmComparisonPredicate.accept(SqmComparisonPredicate.java:104) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.spi.BaseSemanticQueryWalker.visitQualifiedAttributeJoin(BaseSemanticQueryWalker.java:296) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.SemanticQueryWalker.visitSetJoin(SemanticQueryWalker.java:211) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.domain.SqmSetJoin.accept(SqmSetJoin.java:85) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.lambda$visitComparisonPredicate$14(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.withTypeInference(ParameterCollector.java:147) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.visitComparisonPredicate(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.predicate.SqmComparisonPredicate.accept(SqmComparisonPredicate.java:104) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.spi.BaseSemanticQueryWalker.visitQualifiedAttributeJoin(BaseSemanticQueryWalker.java:296) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.SemanticQueryWalker.visitSetJoin(SemanticQueryWalker.java:211) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.domain.SqmSetJoin.accept(SqmSetJoin.java:85) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.lambda$visitComparisonPredicate$14(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.withTypeInference(ParameterCollector.java:147) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.jpa.ParameterCollector.visitComparisonPredicate(ParameterCollector.java:272) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.predicate.SqmComparisonPredicate.accept(SqmComparisonPredicate.java:104) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.spi.BaseSemanticQueryWalker.visitQualifiedAttributeJoin(BaseSemanticQueryWalker.java:296) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.SemanticQueryWalker.visitSetJoin(SemanticQueryWalker.java:211) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] at org.hibernate.query.sqm.tree.domain.SqmSetJoin.accept(SqmSetJoin.java:85) ~[hibernate-core-6.3.0.CR1.jar:6.3.0.CR1] ( https://hibernate.atlassian.net/browse/HHH-17001#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17001#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17000) Do not keep static references to log levels

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17000 ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiMWI4ZW... ) Re: Do not keep static references to log levels ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiMWI4ZW... ) > > > > The alternative to this pattern being to fully remove such statements from > the source code. > > I personally think that we could remove quite a lot of the logging that Hibernate does, but the logging in JdbcBindingLogging is actually super-useful and important. These are the log messages we really can’t remove. ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-17000) Do not keep static references to log levels

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17000 ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiOGQxYT... ) Re: Do not keep static references to log levels ( https://hibernate.atlassian.net/browse/HHH-17000?atlOrigin=eyJpIjoiOGQxYT... ) Hi James, this was a “convention” started at first by the Infinispan team, but then applied across several projects. There’s certainly tradeoffs, and perhaps it’s time to revisit them as I don’t know how much it’s applicable today, but this was intentional. Essentially expressing it as a final constant has two benefits (which might be out of date): * it helps code elimination in GraalVM * the performance help in JVM - like you say, it’s extemely marginal but it has been show to exist, and in some cases it matters. Now as it happens, both of the above points are highly contexctual, but we had some situations in which they did matter. The alternative to this pattern being to fully remove such statements from the source code. Rather than fully removing it, we decided that we consider the “trace” level as something that is allowed to be folded as a constant. So I’d not consider it as a bug because if people want to “flip” this dynamically… if I remove such statements instead they won’t be able to log them at all. Perhaps JBoss Logger could address this need explicitly? As I see it, what puzzles our users most is that this “convention” isn’t advertised enough. What we could do, if these are particularly useful, is to re-evaluate if they should be upgraded to debug. It wasn’t intention to fold as a constant anything at debug level, only for tracing. ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17000#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:62cfdef )

2 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues July 2023