July 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16928) Subquery in 'where' clause causes additional 'join' creation in SQM

by Damian Majer (JIRA)

Damian Majer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMjE5OWU5Yzgw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiMjE5OW... ) HHH-16928 ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiMjE5OW... ) Subquery in 'where' clause causes additional 'join' creation in SQM ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiMjE5OW... ) Change By: Damian Majer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) When you create a subquery on entity which is joined then additional inner join is created in SQM query. Entities: {code:java}@Entity public class EntityA { @Id private Integer id; @OneToMany private List<EntityB> bCollection; }{code} {code:java}@Entity public class EntityB { @Id private Integer id; @ManyToOne private EntityA a; @ElementCollection private final Set<EntityC> cCollection = new HashSet<>(); }{code} {code:java}@Embeddable public class EntityC { private LocalDateTime date; private Long value; }{code} Query creation: {code:java}entityManager.createQuery(""" select distinct a.id, b.id, c.value from EntityA a left join EntityB b on b.a.id = a.id left join b.cCollection as c where (c.date = (select max(c2.date) from b.cCollection as c2) or c.date is null) """);{code} {code:java}entityManager.createQuery(""" select distinct b.id, c.value from EntityB b left join b.cCollection as c where (c.date = (select max(c2.date) from b.cCollection as c2) or c.date is null) """);{code} In the first query we receive following result: {noformat}select distinct e1_0.id, e2_0.id, c1_0.value from entitya e1_0 left join entityb e2_0 on e2_0.a_id=e1_0.id left join entityb_c_collection c1_0 on e2_0.id=c1_0.entityb_id join entityb_c_collection c2_0 on e2_0.id=c2_0.entityb_id where ( c1_0.date=( select max(c3_0.date) from entityb_c_collection c3_0 where e2_0.id=c3_0.entityb_id ) or c1_0.date is null ){noformat} There’s the additional inner join to {{c2_0}}, which is never used. In the second query this is the result: {noformat}select distinct e1_0.id, c1_0.value from entityb e1_0 left join entityb_c_collection c1_0 on e1_0.id=c1_0.entityb_id where ( c1_0.date=( select max(c2_0.date) from entityb_c_collection c2_0 where e1_0.id=c2_0.entityb_id ) or c1_0.date is null ){noformat} There are not additional joins. First query with Hibernate 5.6.15: {noformat}select distinct entitya0_.id as col_0_0_, entityb1_.id as col_1_0_, ccollectio2_.value as col_2_0_ from entitya entitya0_ left outer join entityb entityb1_ on ( entityb1_.a_id=entitya0_.id ) left outer join entityb_c_collection ccollectio2_ on entityb1_.id=ccollectio2_.entityb_id where ccollectio2_.date=( select max(ccollectio3_.date) from entityb_c_collection ccollectio3_ where entityb1_.id=ccollectio3_.entityb_id ) or ccollectio2_.date is null{noformat} It doesn’t have any additional inner join. Test case - [https://github.com/damianmajer/hibernate-test-case-templates|https://gith...] I have created same test case in orm-5 and orm-6. In orm-5 it works and it fails in orm-6. ( https://hibernate.atlassian.net/browse/HHH-16928#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16928#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16930) Return type of createQuery() not validated any more

by T3rm1 (JIRA)

T3rm1 ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZGJkZjk2NjM0... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16930?atlOrigin=eyJpIjoiZGJkZj... ) HHH-16930 ( https://hibernate.atlassian.net/browse/HHH-16930?atlOrigin=eyJpIjoiZGJkZj... ) Return type of createQuery() not validated any more ( https://hibernate.atlassian.net/browse/HHH-16930?atlOrigin=eyJpIjoiZGJkZj... ) Issue Type: Bug Affects Versions: 6.2.6 Assignee: Unassigned Attachments: bug.zip Created: 12/Jul/2023 06:00 AM Priority: Major Reporter: T3rm1 ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) List<A> aList = entityManager.createQuery(""" select new org.hibernate.bugs.Result(a, b) from A a join B b ON a.bSpecialId = b.specialId """, A.class).getResultList(); The query returns a org.hibernate.bugs.Result but the second parameter of createQuery is A.class , which is wrong. However, Hibernate does not report an error. The same code does throw an IllegalArgumentException with Hibernate 5.6.15. Test case is attached. ( https://hibernate.atlassian.net/browse/HHH-16930#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16930#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16929) introduce Pager API

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMWY1Zjc4NTRi... ) / New Feature ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiMWY1Zj... ) HHH-16929 ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiMWY1Zj... ) introduce Pager API ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiMWY1Zj... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) To make query result pagination slightly easier to use, introduce {{Pager}}, which may be used as follows: {code:java} Pager<Book> bookPager = session.createSelectionQuery("from Book where title like :title", Book.class) .setParameter("title", titlePattern) .getResultPager(Page.first(pageSize)); while (bookPager.hasResults()) { List<Book> books = bookPager.getResultList(); ... session.clear(); bookPager.next(); }{code} Or as follows: {code:java} session.createSelectionQuery("from Book where title like :title", Book.class) .setParameter("title", titlePattern) .getResultPager(Page.first(pageSize)) .forEachRemainingPage(books -> { ... session.clear(); });{code} Or even, more practically for most programs, something like this: {code:java}scope.inSession(s -> { Page page = Page.first(10); boolean hasMore; do { Pager<Book> pager = s.createSelectionQuery("from Book", Book.class) .getResultPager( Page.first(15 page ) ) ; List<Book> books = pager.getResultList(); hasMore = pager.hasResultsOnNextPage(); page = page.next(); } while ( hasMore ); });{code} Here we do not need to keep a {{Pager}} open between requests. Still need to add {{Page.getTotalPages()}} delegating to a new method {{Query.getResultCount()}}. ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16929) introduce Pager API

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTdhOTU2NzQx... ) / New Feature ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiNTdhOT... ) HHH-16929 ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiNTdhOT... ) introduce Pager API ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiNTdhOT... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) To make query result pagination slightly easier to use, introduce {{Pager}}, which may be used as follows: {code:java} Pager<Book> bookPager = session.createSelectionQuery("from Book where title like :title", Book.class) .setParameter("title", titlePattern) .getResultPager(Page.first(pageSize)); while (bookPager.hasResults()) { List<Book> books = bookPager.getResultList(); ... session.clear(); bookPager.next(); }{code} Or as follows: {code:java} session.createSelectionQuery("from Book where title like :title", Book.class) .setParameter("title", titlePattern) .getResultPager(Page.first(pageSize)) .forEachRemainingPage(books -> { ... session.clear(); });{code} Or even, more practically for most programs, something like this: { noformat code:java }scope.inSession(s -> { Page page = Page.first(10); boolean hasMore; do { Pager<Book> pager = s.createSelectionQuery("from Book", Book.class) .getResultPager(Page.first(15)); List<Book> books = pager.getResultList(); hasMore = pager.hasResultsOnNextPage(); page = page.next(); } while ( hasMore ); });{ noformat code } Here we do not need to keep a {{Pager}} open between requests. Still need to add {{Page.getTotalPages()}} delegating to a new method {{Query.getResultCount()}}. ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16929) introduce Pager API

by Gavin King (JIRA)

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16929) introduce Pager API

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYzBlNzg1M2I5... ) / New Feature ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiYzBlNz... ) HHH-16929 ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiYzBlNz... ) introduce Pager API ( https://hibernate.atlassian.net/browse/HHH-16929?atlOrigin=eyJpIjoiYzBlNz... ) Issue Type: New Feature Assignee: Unassigned Created: 12/Jul/2023 05:56 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) To make query result pagination slightly easier to use, introduce Pager , which may be used as follows: Pager<Book> bookPager = session.createSelectionQuery( "from Book where title like :title" , Book.class) .setParameter( "title" , titlePattern) .getResultPager(Page.first(pageSize)); while (bookPager.hasResults()) { List<Book> books = bookPager.getResultList(); ... session.clear(); bookPager.next(); } Or as follows: session.createSelectionQuery( "from Book where title like :title" , Book.class) .setParameter( "title" , titlePattern) .getResultPager(Page.first(pageSize)) .forEachRemainingPage(books -> { ... session.clear(); }); Or even, more practically for most programs, something like this: scope.inSession(s -> { Page page = Page.first(10); boolean hasMore; do { Pager<Book> pager = s.createSelectionQuery("from Book", Book.class) .getResultPager(Page.first(15)); List<Book> books = pager.getResultList(); hasMore = pager.hasResultsOnNextPage(); page = page.next(); } while ( hasMore ); }); Here we do not need to keep a Pager open between requests. Still need to add Page.getTotalPages() delegating to a new method Query.getResultCount(). ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16929#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16927) Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal

by Morgan PEYRE (JIRA)

Morgan PEYRE ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16927 ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiMGNjYm... ) Re: Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiMGNjYm... ) Okay, so not a bug then. Thanks for your help and sorry I bothered you. I can try and write a 6.0 migration guide PR if you think it would be useful. ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16928) Subquery in 'where' clause causes additional 'join' creation in SQM

by Damian Majer (JIRA)

Damian Majer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDlkZTQ3Mjk2... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiNDlkZT... ) HHH-16928 ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiNDlkZT... ) Subquery in 'where' clause causes additional 'join' creation in SQM ( https://hibernate.atlassian.net/browse/HHH-16928?atlOrigin=eyJpIjoiNDlkZT... ) Issue Type: Bug Affects Versions: 6.2.5 Assignee: Unassigned Components: hibernate-core Created: 12/Jul/2023 05:20 AM Environment: Hibernate: 6.2.5 Spring Boot: 3.1.1 JVM: 17 Postgresql: 42.6.0 Priority: Major Reporter: Damian Majer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) When you create a subquery on entity which is joined then additional inner join is created in SQM query. Entities: @Entity public class EntityA { @Id private Integer id; @OneToMany private List<EntityB> bCollection; } @Entity public class EntityB { @Id private Integer id; @ManyToOne private EntityA a; @ElementCollection private final Set<EntityC> cCollection = new HashSet<>(); } @Embeddable public class EntityC { private LocalDateTime date; private Long value; } Query creation: entityManager.createQuery(""" select distinct a.id, b.id, c.value from EntityA a left join EntityB b on b.a.id = a.id left join b.cCollection as c where (c.date = (select max(c2.date) from b.cCollection as c2) or c.date is null ) """); entityManager.createQuery(""" select distinct b.id, c.value from EntityB b left join b.cCollection as c where (c.date = (select max(c2.date) from b.cCollection as c2) or c.date is null ) """); In the first query we receive following result: select distinct e1_0.id, e2_0.id, c1_0.value from entitya e1_0 left join entityb e2_0 on e2_0.a_id=e1_0.id left join entityb_c_collection c1_0 on e2_0.id=c1_0.entityb_id join entityb_c_collection c2_0 on e2_0.id=c2_0.entityb_id where ( c1_0.date=( select max(c3_0.date) from entityb_c_collection c3_0 where e2_0.id=c3_0.entityb_id ) or c1_0.date is null ) There’s the additional inner join to c2_0 , which is never used. In the second query this is the result: select distinct e1_0.id, c1_0.value from entityb e1_0 left join entityb_c_collection c1_0 on e1_0.id=c1_0.entityb_id where ( c1_0.date=( select max(c2_0.date) from entityb_c_collection c2_0 where e1_0.id=c2_0.entityb_id ) or c1_0.date is null ) There are not additional joins. First query with Hibernate 5.6.15: select distinct entitya0_.id as col_0_0_, entityb1_.id as col_1_0_, ccollectio2_.value as col_2_0_ from entitya entitya0_ left outer join entityb entityb1_ on ( entityb1_.a_id=entitya0_.id ) left outer join entityb_c_collection ccollectio2_ on entityb1_.id=ccollectio2_.entityb_id where ccollectio2_.date=( select max(ccollectio3_.date) from entityb_c_collection ccollectio3_ where entityb1_.id=ccollectio3_.entityb_id ) or ccollectio2_.date is null It doesn’t have any additional inner join. ( https://hibernate.atlassian.net/browse/HHH-16928#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16928#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16927) Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16927 ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiMDQ3Nm... ) Re: Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiMDQ3Nm... ) Right. The change to the major version number 5->6 was made to indicate that this is a version of Hibernate which introduces breaking changes. In principle this should be mentioned in the migration guide, but it might easily have slipped through. ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

[JIRA] (HHH-16927) Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal

by Morgan PEYRE (JIRA)

Morgan PEYRE ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16927 ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiZmYzOG... ) Re: Some NUMBER column types now get mapped to Boolean/Integer/Long instead of BigDecimal ( https://hibernate.atlassian.net/browse/HHH-16927?atlOrigin=eyJpIjoiZmYzOG... ) To further clarify my problem: the last line of code in my previous comment throws a java.lang.ClassCastException with Hibernate 6 ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16927#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100231- sha1:2d13be9 )

2 years, 9 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues July 2023