[hibernate-issues] [Hibernate-JIRA] Commented: (BVAL-198) Simplify creation of ConstraintViolationExceptions

Simplify creation of ConstraintViolationExceptions -------------------------------------------------- Key: BVAL-198 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-198 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.0 final Reporter: Gunnar Morling Attachments: bval-198.diff javax.validation.ConstraintViolationException wraps a set of constraint violations, currently in the following form: Set<ConstraintViolation<?>> constraintViolations As the exception's constructors have a parameter of the same type, instantiating it is not as easy as expected: Validator validator = ...; DomainObject domainObject = new DomainObject(); Set<ConstraintViolation<DomainObject>> constraintViolations = validator.validate(domainObject); //compiler error: ("The constructor ConstraintViolationException(Set<ConstraintViolation<DomainObject>>) is undefined") throw new ConstraintViolationException(constraintViolations); //this works throw new ConstraintViolationException(new HashSet<ConstraintViolation<?>>(constraintViolations)); This problem can be solved by changing the collection type to Set<? extends ConstraintViolation<?>> The exception then would read as follows: public class ConstraintViolationException extends ValidationException { private final Set<? extends ConstraintViolation<?>> constraintViolations; public ConstraintViolationException(String message, Set<? extends ConstraintViolation<?>> constraintViolations) { super( message ); this.constraintViolations = constraintViolations; } public ConstraintViolationException(Set<? extends ConstraintViolation<?>> constraintViolations) { super(); this.constraintViolations = constraintViolations; } public Set<ConstraintViolation<?>> getConstraintViolations() { return new HashSet<ConstraintViolation<?>>(constraintViolations); } } This makes the exception easier to use for producers, while maintaining simplicity for clients (since getConstraintViolations() still returns a Set<ConstraintViolation<?>>, clients don't have to do deal with the bound wildcard expression).