[hibernate-issues] [Hibernate-JIRA] Resolved: (HSHARDS-5) Syntax errors in documentation code for Obtaining a ShardedSessionFactory

Syntax errors in documentation code for Obtaining a ShardedSessionFactory ------------------------------------------------------------------------- Key: HSHARDS-5 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-5 Project: Hibernate Shards Issue Type: Bug Components: documentation Affects Versions: 3.0.0.Beta1 Reporter: Nathan Silberman Assignee: Max Ross Priority: Trivial Fix For: 3.0.0.beta2 Original Estimate: 1 minute Remaining Estimate: 1 minute The 3rd code block in section 2.2. Obtaining a ShardedSessionFactory contains several trivial syntax errors. The following block contains the corrected code with commonts pointing out the corrections. 1 public SessionFactory createSessionFactory() { 2 Configuration prototypeConfig = new Configuration().configure("shard0.hibernate.cfg.xml"); 3 prototypeConfig.addResource("weather.hbm.xml"); 4 List<Configuration> shardConfigs = new ArrayList<Configuration>(); 5 shardConfigs.add(new Configuration().configure("shard0.hibernate.cfg.xml") ); // added parenthasis 6 shardConfigs.add(new Configuration().configure("shard1.hibernate.cfg.xml") ); // added parenthasis 7 shardConfigs.add(new Configuration().configure("shard2.hibernate.cfg.xml") ); // added parenthasis 8 ShardStrategyFactory shardStrategyFactory = buildShardStrategyFactory(); 9 ShardedConfiguration shardedConfig = new ShardedConfiguration( 10 prototypeConfig, 11 shardConfigs, 12 shardStrategyFactory); 13 return shardedConfig.buildShardedSessionFactory(); 14 } 15 16 ShardStrategyFactory buildShardStrategyFactory() { 17 ShardStrategyFactory shardStrategyFactory = new ShardStrategyFactory() { // classname changed FROM StrategyFactory 18 public ShardStrategy newShardStrategy(List shardIds) { 19 RoundRobinShardLoadBalancer loadBalancer = new RoundRobinShardLoadBalancer(shardIds); 20 ShardSelectionStrategy pss = new RoundRobinShardSelectionStrategy(loadBalancer); 21 ShardResolutionStrategy prs = new AllShardsShardResolutionStrategy(shardIds); 22 ShardAccessStrategy pas = new SequentialShardAccessStrategy(); 23 return new ShardStrategyImpl(pss, prs, pas); 24 } 25 }; // added semi-colon here 26 return shardStrategyFactory; 27 }