[hibernate-issues] [Hibernate-JIRA] Closed: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method

org.hibernate.cache.QueryKey has a fragile equals() method ---------------------------------------------------------- Key: HHH-2021 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.1.3 Reporter: Kenny MacLeod Assignee: Gail Badner Priority: Trivial Fix For: 3.2.x, 3.3.0.GA Attachments: patch.zip This one is no great shakes, but the first line of QueryKey.equals() casts the argument to QueryKey without checking for its type. As such, the method is fragile. It should be consistent with CacheKey, which does an instanceof check before the cast.